Bug-report and fix (was: Frequency Shifting & Hilbert Transforms)
Date | 1999-03-17 23:38 |
From | Richard Dobson |
Subject | Bug-report and fix (was: Frequency Shifting & Hilbert Transforms) |
It's just one of those things; I decide to run someone's orc, after a ~looong~ time of not doing such a thing... and I find a weee buglet. If ksamps divides exactly into the number of samples in the infile, diskin blows up. The fix is happily simple: at the very end of the function soundinew() in diskin.c, the block of code following the label 'filend' needs to be wrapped in the test: if(ntogo > 0) { ... } and all is well with the world. The great musician and human being Yehudi Menuhin passed away last week - I have only just heard about it. My father worked with him for most of his professional life. We shall not see his like again. If it were a practical thing, I would ask for a minute's internet silence. Richard Dobson -- Test your DAW with my Soundcard Attrition Page! http://wkweb5.cableinet.co.uk/rwd |
Date | 1999-03-18 00:50 |
From | "Matt J. Ingalls" |
Subject | Re: Bug-report and fix (was: Frequency Shifting & Hilbert Transforms) |
this fix probably needs to be in soundin as well - as that part of code is directly lifted from soundin. -matt On Wed, 17 Mar 1999, Richard Dobson wrote: > It's just one of those things; I decide to run someone's orc, after a > ~looong~ time of not doing such a thing... and I find a weee buglet. > > If ksamps divides exactly into the number of samples in the infile, > diskin blows up. The fix is happily simple: > > at the very end of the function soundinew() in diskin.c, > the block of code following the label 'filend' needs to be wrapped in > the test: > > if(ntogo > 0) { > ... > > } > > and all is well with the world. > > The great musician and human being Yehudi Menuhin passed away last week > - I have only just heard about it. My father worked with him for most of > his professional life. We shall not see his like again. If it were a > practical thing, I would ask for a minute's internet silence. > > > > Richard Dobson > > > > -- > Test your DAW with my Soundcard Attrition Page! > http://wkweb5.cableinet.co.uk/rwd > CDP homepage: http://www.bath.ac.uk/~masjpf/CDP/CDP.htm > |