| Okay, I didn't get that float-version.h gets picked up by make from
the build folder.
I did not look there for my failed Emscripten build (which currently
is succeeding) for float-version.h because I did not know that.
Best,
Mike
-----------------------------------------------------
Michael Gogins
Irreducible Productions
http://michaelgogins.tumblr.com
Michael dot Gogins at gmail dot com
On Fri, Nov 17, 2017 at 11:38 AM, Steven Yi wrote:
> Okay, that's helpful. Yes, float-version.h is compiled into the
> current build folder (it's in include/CMakeLists.txt, line 5). If
> CMake doesn't run, that float-version.h won't get created from the
> float-version.h.in file. The generated float-version.h in the build
> folder gets used by CMake as a source file (same as generated c files
> from flex/bison). The install script also copies the float-version.h
> into the target include directory, but that only comes up for
> distribution, not build-time.
>
> So the problem with Francesco's build *should* be the misconfigured
> Emscripten. That looks to cause Cmake not to run to completion (which
> was reported in the log) and then the failure to compile because no
> float-version.h exists.
>
> If you have a problem building with Emscripten, I would guess it was
> something like the above rather than a problem with float-version.h.
> (This is a guess as I've compiled with Emscripten on OSX and multiple
> Linuxes without problems with float-version.h)
>
> On Fri, Nov 17, 2017 at 11:28 AM, Michael Gogins
> wrote:
>> I'm not sure what the concrete steps I took to get to my problem were,
>> but it happened when trying to build for Emscripten using the existing
>> scripts.
>>
>> The existence of float-version.h implies, to me, that the Emscripten
>> build will fail if float-version.h does not exist or exists with MYFLT
>> defined as double.
>>
>> Are you saying that different builds will re-create float-version.h
>> for the correct MYFLT type? I don't see what building in different
>> directories has to do with this.
>>
>> Best,
>> Mike
>>
>> -----------------------------------------------------
>> Michael Gogins
>> Irreducible Productions
>> http://michaelgogins.tumblr.com
>> Michael dot Gogins at gmail dot com
>>
>>
>> On Fri, Nov 17, 2017 at 11:10 AM, Steven Yi wrote:
>>> So again, I ask, for the last time, could you explain what problem you
>>> are talking about? Please explain *exactly* what issue is occurring,
>>> like "I can't compile something when doing a" or "this is breaking
>>> here because of b". I honestly don't understand what the problem is
>>> you are referring to and, therefore, what is solved by removing
>>> float-version.h. Is it that you want to use the same physical headers
>>> (from the same folder) even when compiling to multiple configurations
>>> or something? (Which Victor addressed in that email thread by saying
>>> use different folders?)
>>>
>>> On my systems, I have been compiling with various configurations for
>>> doubles with Emscripten, Windows (VS and MinGW), OSX, Android, iOS,
>>> Linux. With the exception of iOS, I have done builds on all of those
>>> platforms in the last few days. Over the years, I've had separate
>>> build folders for doubles and float builds and have had no problems.
>>>
>>> So *please* frame what you are saying in concrete terms that I can
>>> understand. I'm going to assume there's something you're doing or
>>> wanting to do that is outside of the things I'm doing, but I need you
>>> to explain the issue because I haven't seen any problems here.
>>>
>>>
>>>
>>>
>>> On Fri, Nov 17, 2017 at 10:51 AM, Michael Gogins
>>> wrote:
>>>> When Victor introduced this for the purpose of installing Csound for
>>>> plugin developers etc., the set of Csound targets was not so large as
>>>> it is now.
>>>>
>>>> At that time, you commented:
>>>>
>>>> Hi Victor,
>>>>
>>>> Won't doing this mean one will not be able to compile both a float and
>>>> a double lib on the same system? I see how this will set a default for
>>>> an installation but I don't see exactly where it allows overriding.
>>>>
>>>> Thanks!
>>>> steven
>>>>
>>>> This is my point, or at least part of my point. We need to allow
>>>> overriding for developers who target different platforms. Of course
>>>> one can have multiple Csound repositories, one for each target, but I
>>>> would prefer that not be necessary.
>>>>
>>>> In this case, the default MYFLT is double but for Emscripten it is float.
>>>>
>>>> Best,
>>>> Mike
>>>>
>>>>
>>>> -----------------------------------------------------
>>>> Michael Gogins
>>>> Irreducible Productions
>>>> http://michaelgogins.tumblr.com
>>>> Michael dot Gogins at gmail dot com
>>>>
>>>>
>>>> On Fri, Nov 17, 2017 at 10:37 AM, Steven Yi wrote:
>>>>> I still don't understand by "float version" problem as you haven't
>>>>> explained what the problem is, but just keep insisting there is a
>>>>> problem. So I ask again, what is the problem that needs addressing?
>>>>>
>>>>> BTW: Looking in my email archive, this was introduced 7 years ago.
>>>>> Victor's rationale for it is here:
>>>>>
>>>>> http://csound.1045644.n5.nabble.com/defining-floating-point-type-in-installed-headers-td2257256.html
>>>>>
>>>>>
>>>>>
>>>>> On Fri, Nov 17, 2017 at 10:23 AM, Michael Gogins
>>>>> wrote:
>>>>>> Are you talking about the float version problem? This never worked for
>>>>>> me whether the Emscripten setup allowed things to complete or not.
>>>>>> This may be because I had done another build in the same CMake
>>>>>> context. But can we just remove this? What's the point besides causing
>>>>>> unnecessary problems?
>>>>>>
>>>>>> I think you're discounting the likelihood that other people may have
>>>>>> different ways of building or different levels of experience. The
>>>>>> build should work out of the box as much as possible and for as many
>>>>>> of the several targets we support as possible.
>>>>>>
>>>>>> Best,
>>>>>> Mike
>>>>>>
>>>>>> -----------------------------------------------------
>>>>>> Michael Gogins
>>>>>> Irreducible Productions
>>>>>> http://michaelgogins.tumblr.com
>>>>>> Michael dot Gogins at gmail dot com
>>>>>>
>>>>>>
>>>>>> On Fri, Nov 17, 2017 at 10:15 AM, Steven Yi wrote:
>>>>>>> I don't see the problem except that it wasn't generated because the
>>>>>>> Emscripten setup did not allow things to complete. Is there some other
>>>>>>> problem?
>>>>>>>
>>>>>>> On Fri, Nov 17, 2017 at 10:09 AM, Michael Gogins
>>>>>>> wrote:
>>>>>>>> The float version header is a real problem. We should either remove
>>>>>>>> this file or get the build to work both with, and without, it.
>>>>>>>>
>>>>>>>> Best,
>>>>>>>> Mike
>>>>>>>>
>>>>>>>> -----------------------------------------------------
>>>>>>>> Michael Gogins
>>>>>>>> Irreducible Productions
>>>>>>>> http://michaelgogins.tumblr.com
>>>>>>>> Michael dot Gogins at gmail dot com
>>>>>>>>
>>>>>>>>
>>>>>>>> On Fri, Nov 17, 2017 at 9:56 AM, Steven Yi wrote:
>>>>>>>>> It looks like the problem doesn't have to do with Csound but rather
>>>>>>>>> that your Emscripten setup has problems. The log has:
>>>>>>>>>
>>>>>>>>> + echo Using EMSCRIPTEN_ROOT: $EMSCRIPTEN
>>>>>>>>> Using EMSCRIPTEN_ROOT: $EMSCRIPTEN
>>>>>>>>> + mkdir -p build-wasm
>>>>>>>>> + cd build-wasm
>>>>>>>>> + cmake -DUSE_COMPILER_OPTIMIZATIONS=0 -DWASM=1
>>>>>>>>> -DINIT_STATIC_MODULES=1 -DUSE_DOUBLE=NO -DBUILD_MULTI_CORE=0
>>>>>>>>> -DBUILD_JACK_OPCODES=0 -DEMSCRIPTEN=1
>>>>>>>>> -DCMAKE_TOOLCHAIN_FILE=$EMSCRIPTEN/cmake/Modules/Platform/Emscripten.cmake
>>>>>>>>> -DCMAKE_MODULE_PATH=$EMSCRIPTEN/cmake -DCMAKE_BUILD_TYPE=Release
>>>>>>>>> -GUnix Makefiles -DHAVE_BIG_ENDIAN=0 -DCMAKE_16BIT_TYPE=unsigned short
>>>>>>>>> -DHAVE_STRTOD_L=0 -DBUILD_STATIC_LIBRARY=YES -DHAVE_ATOMIC_BUILTIN=0
>>>>>>>>> -DHAVE_SPRINTF_L=NO -DUSE_GETTEXT=NO
>>>>>>>>> -DLIBSNDFILE_LIBRARY=../deps/libsndfile-1.0.25/libsndfile-wasm.a
>>>>>>>>> -DSNDFILE_H_PATH=../deps/libsndfile-1.0.25/src ../..
>>>>>>>>> CMake Error at /usr/local/share/cmake-3.8/Modules/CMakeDetermineSystem.cmake:94
>>>>>>>>> (message):
>>>>>>>>> Could not find toolchain file:
>>>>>>>>> $EMSCRIPTEN/cmake/Modules/Platform/Emscripten.cmake
>>>>>>>>> Call Stack (most recent call first):
>>>>>>>>> CMakeLists.txt:8 (project)
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> CMake Error: CMAKE_C_COMPILER not set, after EnableLanguage
>>>>>>>>> CMake Error: CMAKE_CXX_COMPILER not set, after EnableLanguage
>>>>>>>>> -- Configuring incomplete, errors occurred!
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> The first line shows "+ echo Using EMSCRIPTEN_ROOT: $EMSCRIPTEN" where
>>>>>>>>> it should have some kind of real path for $EMSCRIPTEN.
>>>>>>>>>
>>>>>>>>> Did you source the emsdk_set_env.sh file that comes with emsdk?
>>>>>>>>>
>>>>>>>>> On Fri, Nov 17, 2017 at 4:41 AM, fra wrote:
>>>>>>>>>> ok, thanks Steven.
>>>>>>>>>> I'm no able to build csound wasm either with latest change but i found this:
>>>>>>>>>>
>>>>>>>>>> In file included from ../../include/csound.h:287:
>>>>>>>>>> ../../include/sysdep.h:107:10: fatal error: 'float-version.h' file not found
>>>>>>>>>> #include "float-version.h"
>>>>>>>>>> ^~~~~~~~~~~~~~~~~
>>>>>>>>>> 1 error generated.
>>>>>>>>>>
>>>>>>>>>> attached is log file.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Thanks,
>>>>>>>>>> ciao,
>>>>>>>>>> francesco.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Csound mailing list
>>>>>>>>>> Csound@listserv.heanet.ie
>>>>>>>>>> https://listserv.heanet.ie/cgi-bin/wa?A0=CSOUND
>>>>>>>>>> Send bugs reports to
>>>>>>>>>> https://github.com/csound/csound/issues
>>>>>>>>>> Discussions of bugs and features can be posted here
>>>>>>>>>
>>>>>>>>> Csound mailing list
>>>>>>>>> Csound@listserv.heanet.ie
>>>>>>>>> https://listserv.heanet.ie/cgi-bin/wa?A0=CSOUND
>>>>>>>>> Send bugs reports to
>>>>>>>>> https://github.com/csound/csound/issues
>>>>>>>>> Discussions of bugs and features can be posted here
>>>>>>>>
>>>>>>>> Csound mailing list
>>>>>>>> Csound@listserv.heanet.ie
>>>>>>>> https://listserv.heanet.ie/cgi-bin/wa?A0=CSOUND
>>>>>>>> Send bugs reports to
>>>>>>>> https://github.com/csound/csound/issues
>>>>>>>> Discussions of bugs and features can be posted here
>>>>>>>
>>>>>>> Csound mailing list
>>>>>>> Csound@listserv.heanet.ie
>>>>>>> https://listserv.heanet.ie/cgi-bin/wa?A0=CSOUND
>>>>>>> Send bugs reports to
>>>>>>> https://github.com/csound/csound/issues
>>>>>>> Discussions of bugs and features can be posted here
>>>>>>
>>>>>> Csound mailing list
>>>>>> Csound@listserv.heanet.ie
>>>>>> https://listserv.heanet.ie/cgi-bin/wa?A0=CSOUND
>>>>>> Send bugs reports to
>>>>>> https://github.com/csound/csound/issues
>>>>>> Discussions of bugs and features can be posted here
>>>>>
>>>>> Csound mailing list
>>>>> Csound@listserv.heanet.ie
>>>>> https://listserv.heanet.ie/cgi-bin/wa?A0=CSOUND
>>>>> Send bugs reports to
>>>>> https://github.com/csound/csound/issues
>>>>> Discussions of bugs and features can be posted here
>>>>
>>>> Csound mailing list
>>>> Csound@listserv.heanet.ie
>>>> https://listserv.heanet.ie/cgi-bin/wa?A0=CSOUND
>>>> Send bugs reports to
>>>> https://github.com/csound/csound/issues
>>>> Discussions of bugs and features can be posted here
>>>
>>> Csound mailing list
>>> Csound@listserv.heanet.ie
>>> https://listserv.heanet.ie/cgi-bin/wa?A0=CSOUND
>>> Send bugs reports to
>>> https://github.com/csound/csound/issues
>>> Discussions of bugs and features can be posted here
>>
>> Csound mailing list
>> Csound@listserv.heanet.ie
>> https://listserv.heanet.ie/cgi-bin/wa?A0=CSOUND
>> Send bugs reports to
>> https://github.com/csound/csound/issues
>> Discussions of bugs and features can be posted here
>
> Csound mailing list
> Csound@listserv.heanet.ie
> https://listserv.heanet.ie/cgi-bin/wa?A0=CSOUND
> Send bugs reports to
> https://github.com/csound/csound/issues
> Discussions of bugs and features can be posted here
Csound mailing list
Csound@listserv.heanet.ie
https://listserv.heanet.ie/cgi-bin/wa?A0=CSOUND
Send bugs reports to
https://github.com/csound/csound/issues
Discussions of bugs and features can be posted here |