Hi All,

I tried to build the wasm and emscripten versions of csound today and
found both failed to compile.  I tried using the tagged source for
6.10.0 and this failed in the same way:

"error: Linking globals named
'_ZN6csound20DestroyGlobalPointerEP7CSOUND_PKc': symbol multiply
defined!"

The reasons for this are a bit technical so I will write an email to
the dev list about it.

What this all means that the build that went out for 6.10.0 was
probably using artifacts from prior to December 13th (commit 35bfe6b2)
which introduced the change that caused this. (I am going to guess I
did not detect this issue as the build script doesn't outright fail
when that part of the build failed.).

This also means that the include/OpcodeBase.hpp header has a bug for 6.10.0.

What will need to happen now is that a hotfix build is necessary.  I
just tested a change that worked to build both wasm and ubuntu desktop
builds so I will be using that for the hotfix.  For the 6.10.0 file
release on Github, what I am going to do is delete the asmjs and wasm
builds for 6.10.0 and replace them with ones marked 6.10.0-1.

steven

p.s. - If you're not a developer, you might be wondering, is this kind
of thing quick and easy to fix?  Well, finding this bug, investigating
it, testing changes, and writing up this email took well over an hour
and a half from when I started until now. Branching, fixing, testing,
uploading, updating download links will probably take another 30
minutes.  That's about 2 hours of my afternoon that I'll have spent.
Not nice at all, right?

Csound mailing list
Csound@listserv.heanet.ie
https://listserv.heanet.ie/cgi-bin/wa?A0=CSOUND
Send bugs reports to
        https://github.com/csound/csound/issues
Discussions of bugs and features can be posted here

And another FYI, it turns out there were some commits I had done
locally for the 6.10.0 release that did fix up this issue with static
modules but did not make it to to the 6.10.0 tag and thus
develop/master.  It's not clear whether I didn't push those or if it
was missed before finishing the release with git-flow, but the result
is that the build for 6.10 was largely up to date for Dec 21st.  The
fix I did just now does fix the bad header. I am going to apply that
and reapply the removal of init static modules to fix Csound from
crashing and those will be pushed to master/develop etc. shortly.

On Wed, Jan 10, 2018 at 5:39 PM, Steven Yi  wrote:
> Hi All,
>
> I tried to build the wasm and emscripten versions of csound today and
> found both failed to compile.  I tried using the tagged source for
> 6.10.0 and this failed in the same way:
>
> "error: Linking globals named
> '_ZN6csound20DestroyGlobalPointerEP7CSOUND_PKc': symbol multiply
> defined!"
>
> The reasons for this are a bit technical so I will write an email to
> the dev list about it.
>
> What this all means that the build that went out for 6.10.0 was
> probably using artifacts from prior to December 13th (commit 35bfe6b2)
> which introduced the change that caused this. (I am going to guess I
> did not detect this issue as the build script doesn't outright fail
> when that part of the build failed.).
>
> This also means that the include/OpcodeBase.hpp header has a bug for 6.10.0.
>
> What will need to happen now is that a hotfix build is necessary.  I
> just tested a change that worked to build both wasm and ubuntu desktop
> builds so I will be using that for the hotfix.  For the 6.10.0 file
> release on Github, what I am going to do is delete the asmjs and wasm
> builds for 6.10.0 and replace them with ones marked 6.10.0-1.
>
> steven
>
> p.s. - If you're not a developer, you might be wondering, is this kind
> of thing quick and easy to fix?  Well, finding this bug, investigating
> it, testing changes, and writing up this email took well over an hour
> and a half from when I started until now. Branching, fixing, testing,
> uploading, updating download links will probably take another 30
> minutes.  That's about 2 hours of my afternoon that I'll have spent.
> Not nice at all, right?

Csound mailing list
Csound@listserv.heanet.ie
https://listserv.heanet.ie/cgi-bin/wa?A0=CSOUND
Send bugs reports to
        https://github.com/csound/csound/issues
Discussions of bugs and features can be posted here

I remember your fix, we discussed it in slack, I thought it had been committed. The release package is good then?
========================
Prof. Victor Lazzarini
Dean of Arts, Celtic Studies, and Philosophy,
Maynooth University,
Maynooth, Co Kildare, Ireland
Tel: 00 353 7086936
Fax: 00 353 1 7086952 

> On 10 Jan 2018, at 23:08, Steven Yi  wrote:
> 
> And another FYI, it turns out there were some commits I had done
> locally for the 6.10.0 release that did fix up this issue with static
> modules but did not make it to to the 6.10.0 tag and thus
> develop/master.  It's not clear whether I didn't push those or if it
> was missed before finishing the release with git-flow, but the result
> is that the build for 6.10 was largely up to date for Dec 21st.  The
> fix I did just now does fix the bad header. I am going to apply that
> and reapply the removal of init static modules to fix Csound from
> crashing and those will be pushed to master/develop etc. shortly.
> 
> On Wed, Jan 10, 2018 at 5:39 PM, Steven Yi  wrote:
>> Hi All,
>> 
>> I tried to build the wasm and emscripten versions of csound today and
>> found both failed to compile.  I tried using the tagged source for
>> 6.10.0 and this failed in the same way:
>> 
>> "error: Linking globals named
>> '_ZN6csound20DestroyGlobalPointerEP7CSOUND_PKc': symbol multiply
>> defined!"
>> 
>> The reasons for this are a bit technical so I will write an email to
>> the dev list about it.
>> 
>> What this all means that the build that went out for 6.10.0 was
>> probably using artifacts from prior to December 13th (commit 35bfe6b2)
>> which introduced the change that caused this. (I am going to guess I
>> did not detect this issue as the build script doesn't outright fail
>> when that part of the build failed.).
>> 
>> This also means that the include/OpcodeBase.hpp header has a bug for 6.10.0.
>> 
>> What will need to happen now is that a hotfix build is necessary.  I
>> just tested a change that worked to build both wasm and ubuntu desktop
>> builds so I will be using that for the hotfix.  For the 6.10.0 file
>> release on Github, what I am going to do is delete the asmjs and wasm
>> builds for 6.10.0 and replace them with ones marked 6.10.0-1.
>> 
>> steven
>> 
>> p.s. - If you're not a developer, you might be wondering, is this kind
>> of thing quick and easy to fix?  Well, finding this bug, investigating
>> it, testing changes, and writing up this email took well over an hour
>> and a half from when I started until now. Branching, fixing, testing,
>> uploading, updating download links will probably take another 30
>> minutes.  That's about 2 hours of my afternoon that I'll have spent.
>> Not nice at all, right?
> 
> Csound mailing list
> Csound@listserv.heanet.ie
> https://listserv.heanet.ie/cgi-bin/wa?A0=CSOUND
> Send bugs reports to
>        https://github.com/csound/csound/issues
> Discussions of bugs and features can be posted here

Csound mailing list
Csound@listserv.heanet.ie
https://listserv.heanet.ie/cgi-bin/wa?A0=CSOUND
Send bugs reports to
        https://github.com/csound/csound/issues
Discussions of bugs and features can be posted here

The 6.10.0-1 packages for asmjs and wasm should be good. (Tested last
night using examples projects in emscripten folder). Just updated the
csound.com download links.



On Thu, Jan 11, 2018 at 1:54 AM, Victor Lazzarini
 wrote:
> I remember your fix, we discussed it in slack, I thought it had been committed. The release package is good then?
> ========================
> Prof. Victor Lazzarini
> Dean of Arts, Celtic Studies, and Philosophy,
> Maynooth University,
> Maynooth, Co Kildare, Ireland
> Tel: 00 353 7086936
> Fax: 00 353 1 7086952
>
>> On 10 Jan 2018, at 23:08, Steven Yi  wrote:
>>
>> And another FYI, it turns out there were some commits I had done
>> locally for the 6.10.0 release that did fix up this issue with static
>> modules but did not make it to to the 6.10.0 tag and thus
>> develop/master.  It's not clear whether I didn't push those or if it
>> was missed before finishing the release with git-flow, but the result
>> is that the build for 6.10 was largely up to date for Dec 21st.  The
>> fix I did just now does fix the bad header. I am going to apply that
>> and reapply the removal of init static modules to fix Csound from
>> crashing and those will be pushed to master/develop etc. shortly.
>>
>> On Wed, Jan 10, 2018 at 5:39 PM, Steven Yi  wrote:
>>> Hi All,
>>>
>>> I tried to build the wasm and emscripten versions of csound today and
>>> found both failed to compile.  I tried using the tagged source for
>>> 6.10.0 and this failed in the same way:
>>>
>>> "error: Linking globals named
>>> '_ZN6csound20DestroyGlobalPointerEP7CSOUND_PKc': symbol multiply
>>> defined!"
>>>
>>> The reasons for this are a bit technical so I will write an email to
>>> the dev list about it.
>>>
>>> What this all means that the build that went out for 6.10.0 was
>>> probably using artifacts from prior to December 13th (commit 35bfe6b2)
>>> which introduced the change that caused this. (I am going to guess I
>>> did not detect this issue as the build script doesn't outright fail
>>> when that part of the build failed.).
>>>
>>> This also means that the include/OpcodeBase.hpp header has a bug for 6.10.0.
>>>
>>> What will need to happen now is that a hotfix build is necessary.  I
>>> just tested a change that worked to build both wasm and ubuntu desktop
>>> builds so I will be using that for the hotfix.  For the 6.10.0 file
>>> release on Github, what I am going to do is delete the asmjs and wasm
>>> builds for 6.10.0 and replace them with ones marked 6.10.0-1.
>>>
>>> steven
>>>
>>> p.s. - If you're not a developer, you might be wondering, is this kind
>>> of thing quick and easy to fix?  Well, finding this bug, investigating
>>> it, testing changes, and writing up this email took well over an hour
>>> and a half from when I started until now. Branching, fixing, testing,
>>> uploading, updating download links will probably take another 30
>>> minutes.  That's about 2 hours of my afternoon that I'll have spent.
>>> Not nice at all, right?
>>
>> Csound mailing list
>> Csound@listserv.heanet.ie
>> https://listserv.heanet.ie/cgi-bin/wa?A0=CSOUND
>> Send bugs reports to
>>        https://github.com/csound/csound/issues
>> Discussions of bugs and features can be posted here
>
> Csound mailing list
> Csound@listserv.heanet.ie
> https://listserv.heanet.ie/cgi-bin/wa?A0=CSOUND
> Send bugs reports to
>         https://github.com/csound/csound/issues
> Discussions of bugs and features can be posted here

Csound mailing list
Csound@listserv.heanet.ie
https://listserv.heanet.ie/cgi-bin/wa?A0=CSOUND
Send bugs reports to
        https://github.com/csound/csound/issues
Discussions of bugs and features can be posted here