I had read your email but all I saw was the mention of setting LUA_H_PATH to "".  I mentioned undoing the rest of the changes, but I see I undid that part too in the revert commit which was a mistake.  The rest of the changes though did break things here, which is why I undid those.  (I lost a fair amount of time to look into all that throughout the day and evening, and I value my time just as much as the next person.)

It seems then this is just a breakdown in communication.  The good thing is that it is resolved and looks like a good solution was found that works across platforms.  Awesome, let's move on.

Thanks!

steven

On Thu, Aug 7, 2014 at 5:44 AM, Michael Gogins <michael.gogins@gmail.com> wrote:

I redid the changes knowing they were a problem, because my perception was that you had done the same thing and were not really tracking what I was saying.

In general, I feel that most of the Csound developers make changes and commit them without testing them on windows. This has the effect of requiring me to fix what they break rather than work on music or on my own code. For the most part I don't mind, as I recognize that I do the same thing when I don't test on OS X, that weare ina cooperative community, and that usually people respond quickly when they see there's a problem. This time I felt, correctly or incorrectly, that you weren't listening to what I was saying and were pushing a problem that I had not created back at me.

Best,
Mike

On Aug 6, 2014 10:34 PM, "Steven Yi" <stevenyi@gmail.com> wrote:

I disagree. You made a change, which was fine as it was in an attempt to make things better. It however made things worse and broke things on OSX and Linux, so I restored to the previous point. At that point, I think the exchange was fine, and we probably should have discussed what was going on in more detail. However, you then just re-did the same changes again knowing they were a problem. That's the part where I have problems with.  You did not really mention the problems you were having until after the last re-commit; if you had mentioned them before hand, I could have gone ahead and taken a look as I did, without having things broken for others in the meanwhile. 

Anyways, not a big deal in the end.  The information you reported about the paths was spot on and the CMake code I had done earlier certainly should have been done differently. I'm surprised we didn't detect this issue sooner, but I'm glad that the latest should hopefully work now across all the platforms.

On Wed, Aug 6, 2014 at 9:26 PM, Michael Gogins <michael.gogins@gmail.com> wrote:

Your prior commit wasn't working for me, so your point is the same as my point.

Your latest fixes do seem to work for me. It's late and I can't test everything now, but I should know in the morning and I will let you know right away.

Thanks,

Mike

-----------------------------------------------------

Michael Gogins
Irreducible Productions
http://michaelgogins.tumblr.com
Michael dot Gogins at gmail dot com

On Wed, Aug 6, 2014 at 9:17 PM, Steven Yi <stevenyi@gmail.com> wrote:

No I had not, but re-committing something that was broke things on other platforms does not make sense if it's not at least attempting in some way to fix it for everyone.

I have replied to the other thread with fixes that *should* now work on all platforms.

On Wed, Aug 6, 2014 at 7:53 PM, Michael Gogins <michael.gogins@gmail.com> wrote:

Did you build this stuff on windows? If so, how? If not, I explained why it doesn't work in my previous email.

Best,
Mike

On Aug 6, 2014 7:40 PM, "Steven Yi" <stevenyi@gmail.com> wrote:

Michael,

Why did you re-revert the changes when I mentioned that it broke OSX? And now on Linux too?  I had spent time making sure those luajit header changes were correct some months ago.  We even had discussions here about enforcing luajit for building and thus the search for luajit-2.0/lua.h. 

You not only changed what was being searched for (lua.h instead of luajit-2.0/lua.h), you also removed the necessary dependency checks for targets depending on the existence of the headers. 

Rather than break the other platforms again, please re-re-revert and explain what's going on on Windows that requires fixing.

steven

On Wed, Aug 6, 2014 at 7:24 PM, Travis CI <notifications@travis-ci.org> wrote:

csound / csound (develop)

	Build #375 was broken.	1 minute and 0 seconds
	gogins	3f9804f Changeset →
	Re-reverting LUA_H related changes that don't work on Windows.

Documentation about Travis CI For help please join our IRC channel irc.freenode.net#travis. Choose who receives these build notification emails in your configuration file.

Would you like to test your private code?

Travis Pro could be your new best friend!

Travis CI is powered by

------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls.
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/csound-devel

------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls.
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/csound-devel

------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls.
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/csound-devel

------------------------------------------------------------------------------
Infragistics Profe

Hi,

I think it would be ideal of we could set up a nightly build system, or a Windows machine that is set up for building csound that can be accessed remotely.

Cheers,
Andres

---

From: Michael Gogins
Sent: ‎8/‎7/‎2014 7:51 AM
To: Developer discussions
Subject: Re: [Cs-dev] Broken: csound/csound#375 (develop - 3f9804f)

You're very welcome. It's hard to communicate in situations like this. I for one get mad in isolation and try to control myself, but there's not enough social feedback. Next time I'll try repeating myself more clearly before I try something else.

Best,

Mike

-----------------------------------------------------

Michael Gogins
Irreducible Productions
http://michaelgogins.tumblr.com
Michael dot Gogins at gmail dot com

On Thu, Aug 7, 2014 at 7:59 AM, Steven Yi <stevenyi@gmail.com> wrote:

I had read your email but all I saw was the mention of setting LUA_H_PATH to "".  I mentioned undoing the rest of the changes, but I see I undid that part too in the revert commit which was a mistake.  The rest of the changes though did break things here, which is why I undid those.  (I lost a fair amount of time to look into all that throughout the day and evening, and I value my time just as much as the next person.)

It seems then this is just a breakdown in communication.  The good thing is that it is resolved and looks like a good solution was found that works across platforms.  Awesome, let's move on.

Thanks!

steven

On Thu, Aug 7, 2014 at 5:44 AM, Michael Gogins <michael.gogins@gmail.com> wrote:

I redid the changes knowing they were a problem, because my perception was that you had done the same thing and were not really tracking what I was saying.

In general, I feel that most of the Csound developers make changes and commit them without testing them on windows. This has the effect of requiring me to fix what they break rather than work on music or on my own code. For the most part I don't mind, as I recognize that I do the same thing when I don't test on OS X, that weare ina cooperative community, and that usually people respond quickly when they see there's a problem. This time I felt, correctly or incorrectly, that you weren't listening to what I was saying and were pushing a problem that I had not created back at me.

Best,
Mike

On Aug 6, 2014 10:34 PM, "Steven Yi" <stevenyi@gmail.com> wrote:

I disagree. You made a change, which was fine as it was in an attempt to make things better. It however made things worse and broke things on OSX and Linux, so I restored to the previous point. At that point, I think the exchange was fine, and we probably should have discussed what was going on in more detail. However, you then just re-did the same changes again knowing they were a problem. That's the part where I have problems with.  You did not really mention the problems you were having until after the last re-commit; if you had mentioned them before hand, I could have gone ahead and taken a look as I did, without having things broken for others in the meanwhile. 

Anyways, not a big deal in the end.  The information you reported about the paths was spot on and the CMake code I had done earlier certainly should have been done differently. I'm surprised we didn't detect this issue sooner, but I'm glad that the latest should hopefully work now across all the platforms.

On Wed, Aug 6, 2014 at 9:26 PM, Michael Gogins <michael.gogins@gmail.com> wrote:

Your prior commit wasn't working for me, so your point is the same as my point.

Your latest fixes do seem to work for me. It's late and I can't test everything now, but I should know in the morning and I will let you know right away.

Thanks,

Mike

-----------------------------------------------------

Michael Gogins
Irreducible Productions
http://michaelgogins.tumblr.com
Michael dot Gogins at gmail dot com

On Wed, Aug 6, 2014 at 9:17 PM, Steven Yi <stevenyi@gmail.com> wrote:

No I had not, but re-committing something that was broke things on other platforms does not make sense if it's not at least attempting in some way to fix it for everyone.

I have replied to the other thread with fixes that *should* now work on all platforms.

On Wed, Aug 6, 2014 at 7:53 PM, Michael Gogins <michael.gogins@gmail.com> wrote:

Did you build this stuff on windows? If so, how? If not, I explained why it doesn't work in my previous email.

Best,
Mike

On Aug 6, 2014 7:40 PM, "Steven Yi" <stevenyi@gmail.com> wrote:

Michael,

Why did you re-revert the changes when I mentioned that it broke OSX? And now on Linux too?  I had spent time making sure those luajit header changes were correct some months ago.  We even had discussions here about enforcing luajit for building and thus the search for luajit-2.0/lua.h. 

You not only changed what was being searched for (lua.h instead of luajit-2.0/lua.h), you also removed the necessary dependency checks for targets depending on the existence of the headers. 

Rather than break the other platforms again, please re-re-revert and explain what's going on on Windows that requires fixing.

steven

On Wed, Aug 6, 2014 at 7:24 PM, Travis CI <notifications@travis-ci.org> wrote:

csound / csound (develop)

	Build #375 was broken.	1 minute and 0 seconds
	gogins	3f9804f Changeset →
	Re-reverting LUA_H related changes that don't work on Windows.

Documentation about Travis CI For help please join our IRC channel irc.freenode.net#travis. Choose who receives these build notification emails in your configuration file.

Would you like to test your private code?

Travis Pro could be your new best friend!

Travis CI is powered by

------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls.
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/csound-devel

------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls.
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/csound-devel

------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls.
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/csound-devel

------------------------------------------------------------------------------
Infragistics Profe

[The entire original message is not included.]

------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls.
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/csound-devel