By the way, Felipe Sateler is already doing a refactoring of SConstruct, so
I'd prefer to wait until he's finished to make any changes.

Victor
----- Original Message ----- 
From: "DavidW" 
To: "Developer discussions" 
Sent: Friday, April 04, 2008 7:47 AM
Subject: [Cs-dev] CSonstruct cosmetic surgery : (was Re: SConstruct 
fixed(was...))


> On 03/04/2008, at 10:50 PM, Victor Lazzarini wrote:
>> They should be in the top-level sources directory, if they
>> have been built (if they are not, they were not built):
>>
>> csnd.py and _csnd.so
>> CsoundAC.py and _CsoundAC.so
>>
>> Victor
> They're not being built because pythonFound ==  False resulting in
> --- CONFIGURATION DECISION: Not building Csound interfaces library
> probably because of the python OSX versions thing.
>
> I'm happy to dig in to make the build process possible on the latest
> platform.
> To begin I'd like to do some cosmetic surgery of SConstruct.
>
> Examples
> 1.  There's a mixture of tabs and used spaces for indentation,
> resulting in
> some pretty messy layout.
> I propose normalising them. Most I know use 4 spaces - any objections?
>
> 2. There's some nonsense,  like
>>         if getPlatform() != 'darwin':
>>            csoundInterfacesSources.insert(0, csoundLuaInterface)
>>            if getPlatform() == 'win32':
>>               csoundInterfacesEnvironment.Prepend(LIBS = ['lua51'])
>>            else:
>>               csoundInterfacesEnvironment.Prepend(LIBS = ['lua'])
> ---
> 3. There's the intriguing:
>>     if getPlatform() == 'win32':
>>        portaudioEnvironment.Append(LIBS = ['portaudio'])
>>     else:
>>        portaudioEnvironment.Append(LIBS = ['portaudio'])
>
> 4. Further, why say, for example
>> if commonEnvironment['useLrint'] != '0':
>
> when, given it's boolean,
>> if commonEnvironment['useLrint'] = '1':
>
> would seem to be more logical.
>
> 5. Why call getPlatform() every time the OS is needed?  Why can't this
> be executed once and stored in a variable?, eg.
> sysPlatform = getPlatform()  # do this once, then
>  if sysPlatform ='darwin':
> ...
>
> All these, and more, are natural enough multiple user accretions. But
> less spaghetti would be nice.
> If there's no problem with me doing such housekeeping, can someone add
> them, or indicate how I might go about doing so myself?
>
> thanks,
> D.
>
>> At 12:39 03/04/2008, you wrote:
>>> fixed, and now builds!
>>>
>>> [ for info re /usr/local/lib/libcrypto.* :
>>> the PIL  (Python Image Library) v1.6 installer incorrectly installs
>>> a .PPC version of this dylib.
>>> Scons probably  tries to import it - anyway life's too short for that
>>> line of speculation. ]
>>>
>>> I can't find csnd.py and its dylib or CsoundAC after the build -
>>> where
>>> are the put before being copied by install?
>>> (using scons SConstruct dynamicCsoundLibrary=1 buildCsoundAC=1)
>>>
>>> D.
>
> -------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
> _______________________________________________
> Csound-devel mailing list
> Csound-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/csound-devel 


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net