now i can't build csound on my gentoo linux machine, because it can't find
Fl.H. 

fltk is recognized by cmake:
-- USE_FLTK is enabled.

but then compilation fails thus:

[ 66%] Linking CXX shared module ../libvirtual.so
[ 66%] Built target virtual
Scanning dependencies of target widgets
[ 66%] Building CXX object InOut/CMakeFiles/widgets.dir/FL_graph.cpp.o
/home/lj/data/csound/csound.git/InOut/FL_graph.cpp:25:19: fatal error:
FL/Fl.H: No such file or directory #include 
                   ^
compilation terminated.
make[2]: *** [InOut/CMakeFiles/widgets.dir/build.make:63:
InOut/CMakeFiles/widgets.dir/FL_graph.cpp.o] Error 1 make[1]: ***
[CMakeFiles/Makefile2:2146: InOut/CMakeFiles/widgets.dir/all] Error 2
make: *** [Makefile:163: all] Error 2


the offending commit is c9be62d3a5fe26036ab1080884aa94aa7c533c70

Do you have /usr/include/FL directory?

⁣Sent from TypeApp ​

On Nov 22, 2017, 01:34, at 01:34, luis jure  wrote:
>now i can't build csound on my gentoo linux machine, because it can't
>find
>Fl.H. 
>
>fltk is recognized by cmake:
>-- USE_FLTK is enabled.
>
>but then compilation fails thus:
>
>[ 66%] Linking CXX shared module ../libvirtual.so
>[ 66%] Built target virtual
>Scanning dependencies of target widgets
>[ 66%] Building CXX object InOut/CMakeFiles/widgets.dir/FL_graph.cpp.o
>/home/lj/data/csound/csound.git/InOut/FL_graph.cpp:25:19: fatal error:
>FL/Fl.H: No such file or directory #include 
>                   ^
>compilation terminated.
>make[2]: *** [InOut/CMakeFiles/widgets.dir/build.make:63:
>InOut/CMakeFiles/widgets.dir/FL_graph.cpp.o] Error 1 make[1]: ***
>[CMakeFiles/Makefile2:2146: InOut/CMakeFiles/widgets.dir/all] Error 2
>make: *** [Makefile:163: all] Error 2
>
>
>the offending commit is c9be62d3a5fe26036ab1080884aa94aa7c533c70
>reverting to 38846c3985290000f4aa019ffc3579d196ec1ee6 solves the
>problem

el 2017-11-22 a las 15:08 John ff escribió:

> Do you have /usr/include/FL directory?

no, Fl.H is under /usr/include/fltk/FL

until commit 38846c3985290000f4aa019ffc3579d196ec1ee6 (yesterday) it was
found and csound compiled all right with the FLTK opcodes.

the problems began after this:

commit c9be62d3a5fe26036ab1080884aa94aa7c533c70
Merge: 38846c398 77e8599e4
Author: Steven Yi 
Date:   Tue Nov 21 11:37:37 2017 -0500

On Ubunutu Studio I have it inside /usr/include/FL. Maybe something to
do with this change in InOut/CMakeLists.txt:

260  -    include_directories(".")
261  -    include_directories(${FLTK_INCLUDE_DIR})
260  +    target_include_directories(virtual PRIVATE ".")
261  +    target_include_directories(virtual PRIVATE ${FLTK_INCLUDE_DIR})

The same error should happen for the other CMakeLists.txt files that
were changed.


On 22/11/17 13:49, luis jure wrote:
> el 2017-11-22 a las 15:08 John ff escribió:
>
>> Do you have /usr/include/FL directory?
> no, Fl.H is under /usr/include/fltk/FL
>
> until commit 38846c3985290000f4aa019ffc3579d196ec1ee6 (yesterday) it was
> found and csound compiled all right with the FLTK opcodes.
>
> the problems began after this:
>
> commit c9be62d3a5fe26036ab1080884aa94aa7c533c70
> Merge: 38846c398 77e8599e4
> Author: Steven Yi 
> Date:   Tue Nov 21 11:37:37 2017 -0500
>
>
>

Oly cage I have found relaed to fltk is in InOut/SMakeLists.txt

      #add_dependency_to_framework(virtual ${FLTK_FORMS_LIBRARY})
      #add_dependency_to_framework(virtual ${FLTK_IMAGES_LIBRARY})
-    include_directories(".")
-    include_directories(${FLTK_INCLUDE_DIR})
+    target_include_directories(virtual PRIVATE ".")
+    target_include_directories(virtual PRIVATE ${FLTK_INCLUDE_DIR})
  endif()

Not sure how tis relates

On Tue, 21 Nov 2017, luis jure wrote:

> now i can't build csound on my gentoo linux machine, because it can't find
> Fl.H.
>
> fltk is recognized by cmake:
> -- USE_FLTK is enabled.
>
> but then compilation fails thus:
>
> [ 66%] Linking CXX shared module ../libvirtual.so
> [ 66%] Built target virtual
> Scanning dependencies of target widgets
> [ 66%] Building CXX object InOut/CMakeFiles/widgets.dir/FL_graph.cpp.o
> /home/lj/data/csound/csound.git/InOut/FL_graph.cpp:25:19: fatal error:
> FL/Fl.H: No such file or directory #include 
>                   ^
> compilation terminated.
> make[2]: *** [InOut/CMakeFiles/widgets.dir/build.make:63:
> InOut/CMakeFiles/widgets.dir/FL_graph.cpp.o] Error 1 make[1]: ***
> [CMakeFiles/Makefile2:2146: InOut/CMakeFiles/widgets.dir/all] Error 2
> make: *** [Makefile:163: all] Error 2
>
>
> the offending commit is c9be62d3a5fe26036ab1080884aa94aa7c533c70
> reverting to 38846c3985290000f4aa019ffc3579d196ec1ee6 solves the problem.

Mabe revert this locally to see if it "fixes" it?

On Wed, 22 Nov 2017, jpff wrote:

> Only cage I have found relaed to fltk is in InOut/CMakeLists.txt
>
>     #add_dependency_to_framework(virtual ${FLTK_FORMS_LIBRARY})
>     #add_dependency_to_framework(virtual ${FLTK_IMAGES_LIBRARY})
> -    include_directories(".")
> -    include_directories(${FLTK_INCLUDE_DIR})
> +    target_include_directories(virtual PRIVATE ".")
> +    target_include_directories(virtual PRIVATE ${FLTK_INCLUDE_DIR})
> endif()
>

Similar changes are also found for CsoundAC, CsoundVST, VST4CS and Winsound.


On 22/11/17 14:38, jpff wrote:
> Oly cage I have found relaed to fltk is in InOut/SMakeLists.txt
>
>      #add_dependency_to_framework(virtual ${FLTK_FORMS_LIBRARY})
>      #add_dependency_to_framework(virtual ${FLTK_IMAGES_LIBRARY})
> -    include_directories(".")
> -    include_directories(${FLTK_INCLUDE_DIR})
> +    target_include_directories(virtual PRIVATE ".")
> +    target_include_directories(virtual PRIVATE ${FLTK_INCLUDE_DIR})
>  endif()
>
> Not sure how tis relates
>
> On Tue, 21 Nov 2017, luis jure wrote:
>
>> now i can't build csound on my gentoo linux machine, because it can't
>> find
>> Fl.H.
>>
>> fltk is recognized by cmake:
>> -- USE_FLTK is enabled.
>>
>> but then compilation fails thus:
>>
>> [ 66%] Linking CXX shared module ../libvirtual.so
>> [ 66%] Built target virtual
>> Scanning dependencies of target widgets
>> [ 66%] Building CXX object InOut/CMakeFiles/widgets.dir/FL_graph.cpp.o
>> /home/lj/data/csound/csound.git/InOut/FL_graph.cpp:25:19: fatal error:
>> FL/Fl.H: No such file or directory #include 
>>                   ^
>> compilation terminated.
>> make[2]: *** [InOut/CMakeFiles/widgets.dir/build.make:63:
>> InOut/CMakeFiles/widgets.dir/FL_graph.cpp.o] Error 1 make[1]: ***
>> [CMakeFiles/Makefile2:2146: InOut/CMakeFiles/widgets.dir/all] Error 2
>> make: *** [Makefile:163: all] Error 2
>>
>>
>> the offending commit is c9be62d3a5fe26036ab1080884aa94aa7c533c70
>> reverting to 38846c3985290000f4aa019ffc3579d196ec1ee6 solves the
>> problem.

isn't /usr/bin/fltk-config --includedir suppose to report this?

CMakeCache.txt:FLTK_CONFIG_SCRIPT:FILEPATH=/usr/bin/fltk-config

k.

On 11/21/2017 08:24 PM, luis jure wrote:
> now i can't build csound on my gentoo linux machine, because it can't find
> Fl.H. 
> 
> fltk is recognized by cmake:
> -- USE_FLTK is enabled.
> 
> but then compilation fails thus:
> 
> [ 66%] Linking CXX shared module ../libvirtual.so
> [ 66%] Built target virtual
> Scanning dependencies of target widgets
> [ 66%] Building CXX object InOut/CMakeFiles/widgets.dir/FL_graph.cpp.o
> /home/lj/data/csound/csound.git/InOut/FL_graph.cpp:25:19: fatal error:
> FL/Fl.H: No such file or directory #include 
>                    ^
> compilation terminated.
> make[2]: *** [InOut/CMakeFiles/widgets.dir/build.make:63:
> InOut/CMakeFiles/widgets.dir/FL_graph.cpp.o] Error 1 make[1]: ***
> [CMakeFiles/Makefile2:2146: InOut/CMakeFiles/widgets.dir/all] Error 2
> make: *** [Makefile:163: all] Error 2
> 
> 
> the offending commit is c9be62d3a5fe26036ab1080884aa94aa7c533c70
> reverting to 38846c3985290000f4aa019ffc3579d196ec1ee6 solves the problem.

Might be worth looking at your CMakeCache.txt file to see what it says 
about FLTK.  Mine says

CMakeCache.txt:FLTK_INCLUDE_DIR:PATH=/usr/include

It sondsas if you sould have FLTK_INCLUDE_DIR:PATH=/usr/include/fltk


On Wed, 22 Nov 2017, Guillermo Senna wrote:

> Similar changes are also found for CsoundAC, CsoundVST, VST4CS and Winsound.
>
>
> On 22/11/17 14:38, jpff wrote:
>> Oly cage I have found relaed to fltk is in InOut/SMakeLists.txt
>>
>>      #add_dependency_to_framework(virtual ${FLTK_FORMS_LIBRARY})
>>      #add_dependency_to_framework(virtual ${FLTK_IMAGES_LIBRARY})
>> -    include_directories(".")
>> -    include_directories(${FLTK_INCLUDE_DIR})
>> +    target_include_directories(virtual PRIVATE ".")
>> +    target_include_directories(virtual PRIVATE ${FLTK_INCLUDE_DIR})
>>  endif()
>>

i am also on gentoo and hitting the same error.

FLTK_INCLUDE_PATH is right. FLTK_DIR:PATH=FLTK_DIR-NOTFOUND seems
erronous but maybe not fatal? a colon in the variable name?

k.

$ grep FLTK CMakeCache.txt

//Build CsoundVST plugin (needs C++ interface, FLTK, VST SDK)
//Build CsoundVST plugin (needs C++ interface, FLTK, VST SDK)
//Build the Winsound frontend. Requires FLTK headers and libs.
FLTK_BASE_LIBRARY:FILEPATH=/usr/lib64/fltk/libfltk.so
FLTK_CONFIG_SCRIPT:FILEPATH=/usr/bin/fltk-config
//The directory containing FLTKConfig.cmake.  This is either the
FLTK_DIR:PATH=FLTK_DIR-NOTFOUND
FLTK_FLUID_EXECUTABLE:FILEPATH=/usr/bin/fluid
FLTK_FORMS_LIBRARY:FILEPATH=/usr/lib64/fltk/libfltk_forms.so
FLTK_GL_LIBRARY:FILEPATH=/usr/lib64/fltk/libfltk_gl.so
FLTK_IMAGES_LIBRARY:FILEPATH=/usr/lib64/fltk/libfltk_images.so
FLTK_INCLUDE_DIR:PATH=/usr/include/fltk
FLTK_MATH_LIBRARY:FILEPATH=/usr/lib64/libm.so
//Use FLTK for graphs and widget opcodes
USE_FLTK:BOOL=ON
//Details about finding FLTK
FIND_PACKAGE_MESSAGE_DETAILS_FLTK:INTERNAL=[/usr/lib64/fltk/libfltk_images.so;/usr/lib64/fltk/libfltk_forms.so;/usr/lib64/fltk/libfltk.so][/usr/include/fltk][/usr/bin/fluid][v()]
FLTK_IMAGES_LIBS:INTERNAL=-lpng;-lz;-ljpeg


On 11/22/2017 12:59 PM, Kelly Hirai wrote:
> isn't /usr/bin/fltk-config --includedir suppose to report this?
> 
> CMakeCache.txt:FLTK_CONFIG_SCRIPT:FILEPATH=/usr/bin/fltk-config
> 
> k.
> 
> On 11/21/2017 08:24 PM, luis jure wrote:
>> now i can't build csound on my gentoo linux machine, because it can't find
>> Fl.H. 
>>
>> fltk is recognized by cmake:
>> -- USE_FLTK is enabled.
>>
>> but then compilation fails thus:
>>
>> [ 66%] Linking CXX shared module ../libvirtual.so
>> [ 66%] Built target virtual
>> Scanning dependencies of target widgets
>> [ 66%] Building CXX object InOut/CMakeFiles/widgets.dir/FL_graph.cpp.o
>> /home/lj/data/csound/csound.git/InOut/FL_graph.cpp:25:19: fatal error:
>> FL/Fl.H: No such file or directory #include 
>>                    ^
>> compilation terminated.
>> make[2]: *** [InOut/CMakeFiles/widgets.dir/build.make:63:
>> InOut/CMakeFiles/widgets.dir/FL_graph.cpp.o] Error 1 make[1]: ***
>> [CMakeFiles/Makefile2:2146: InOut/CMakeFiles/widgets.dir/all] Error 2
>> make: *** [Makefile:163: all] Error 2
>>
>>
>> the offending commit is c9be62d3a5fe26036ab1080884aa94aa7c533c70
>> reverting to 38846c3985290000f4aa019ffc3579d196ec1ee6 solves the problem.

That's interesting. Current develop? This is me on Ubuntu Studio:

//Build CsoundVST plugin (needs C++ interface, FLTK, VST SDK)
//Build the Winsound frontend. Requires FLTK headers and libs.
//The directory containing FLTKConfig.cmake.  This is either the
FLTK_DIR:PATH=/usr/lib/fltk
FLTK_MATH_LIBRARY:FILEPATH=/usr/lib/x86_64-linux-gnu/libm.so
//Use FLTK for graphs and widget opcodes
USE_FLTK:BOOL=ON
//Details about finding FLTK
FIND_PACKAGE_MESSAGE_DETAILS_FLTK:INTERNAL=[fltk_images;fltk_forms;fltk][/usr/lib/fltk][fluid][v()]
FLTK_IMAGES_LIBS:INTERNAL=


On 22/11/17 15:17, Kelly Hirai wrote:
> i am also on gentoo and hitting the same error.
>
> FLTK_INCLUDE_PATH is right. FLTK_DIR:PATH=FLTK_DIR-NOTFOUND seems
> erronous but maybe not fatal? a colon in the variable name?
>
> k.
>
> $ grep FLTK CMakeCache.txt
>
> //Build CsoundVST plugin (needs C++ interface, FLTK, VST SDK)
> //Build CsoundVST plugin (needs C++ interface, FLTK, VST SDK)
> //Build the Winsound frontend. Requires FLTK headers and libs.
> FLTK_BASE_LIBRARY:FILEPATH=/usr/lib64/fltk/libfltk.so
> FLTK_CONFIG_SCRIPT:FILEPATH=/usr/bin/fltk-config
> //The directory containing FLTKConfig.cmake.  This is either the
> FLTK_DIR:PATH=FLTK_DIR-NOTFOUND
> FLTK_FLUID_EXECUTABLE:FILEPATH=/usr/bin/fluid
> FLTK_FORMS_LIBRARY:FILEPATH=/usr/lib64/fltk/libfltk_forms.so
> FLTK_GL_LIBRARY:FILEPATH=/usr/lib64/fltk/libfltk_gl.so
> FLTK_IMAGES_LIBRARY:FILEPATH=/usr/lib64/fltk/libfltk_images.so
> FLTK_INCLUDE_DIR:PATH=/usr/include/fltk
> FLTK_MATH_LIBRARY:FILEPATH=/usr/lib64/libm.so
> //Use FLTK for graphs and widget opcodes
> USE_FLTK:BOOL=ON
> //Details about finding FLTK
> FIND_PACKAGE_MESSAGE_DETAILS_FLTK:INTERNAL=[/usr/lib64/fltk/libfltk_images.so;/usr/lib64/fltk/libfltk_forms.so;/usr/lib64/fltk/libfltk.so][/usr/include/fltk][/usr/bin/fluid][v()]
> FLTK_IMAGES_LIBS:INTERNAL=-lpng;-lz;-ljpeg
>
>
> On 11/22/2017 12:59 PM, Kelly Hirai wrote:
>> isn't /usr/bin/fltk-config --includedir suppose to report this?
>>
>> CMakeCache.txt:FLTK_CONFIG_SCRIPT:FILEPATH=/usr/bin/fltk-config
>>
>> k.
>>
>> On 11/21/2017 08:24 PM, luis jure wrote:
>>> now i can't build csound on my gentoo linux machine, because it can't find
>>> Fl.H. 
>>>
>>> fltk is recognized by cmake:
>>> -- USE_FLTK is enabled.
>>>
>>> but then compilation fails thus:
>>>
>>> [ 66%] Linking CXX shared module ../libvirtual.so
>>> [ 66%] Built target virtual
>>> Scanning dependencies of target widgets
>>> [ 66%] Building CXX object InOut/CMakeFiles/widgets.dir/FL_graph.cpp.o
>>> /home/lj/data/csound/csound.git/InOut/FL_graph.cpp:25:19: fatal error:
>>> FL/Fl.H: No such file or directory #include 
>>>                    ^
>>> compilation terminated.
>>> make[2]: *** [InOut/CMakeFiles/widgets.dir/build.make:63:
>>> InOut/CMakeFiles/widgets.dir/FL_graph.cpp.o] Error 1 make[1]: ***
>>> [CMakeFiles/Makefile2:2146: InOut/CMakeFiles/widgets.dir/all] Error 2
>>> make: *** [Makefile:163: all] Error 2
>>>
>>>
>>> the offending commit is c9be62d3a5fe26036ab1080884aa94aa7c533c70
>>> reverting to 38846c3985290000f4aa019ffc3579d196ec1ee6 solves the problem.

more differences between gentoo and ubuntu:

ubuntu $ ls /usr/lib/fltk
CMakeCache.txt    FLTK-Targets.cmake           FLTKUse.cmake
FLTKConfig.cmake  FLTK-Targets-noconfig.cmake  UseFLTK.cmake

gentoo $ ls /usr/lib/fltk
libfltk_cairo.so      libfltk_gl.so          libfltk.so
libfltk_cairo.so.1.3  libfltk_gl.so.1.3      libfltk.so.1.3
libfltk_forms.so      libfltk_images.so
libfltk_forms.so.1.3  libfltk_images.so.1.3

k.


On 11/22/2017 12:59 PM, Kelly Hirai wrote:
> isn't /usr/bin/fltk-config --includedir suppose to report this?
> 
> CMakeCache.txt:FLTK_CONFIG_SCRIPT:FILEPATH=/usr/bin/fltk-config
> 
> k.
> 
> On 11/21/2017 08:24 PM, luis jure wrote:
>> now i can't build csound on my gentoo linux machine, because it can't find
>> Fl.H. 
>>
>> fltk is recognized by cmake:
>> -- USE_FLTK is enabled.
>>
>> but then compilation fails thus:
>>
>> [ 66%] Linking CXX shared module ../libvirtual.so
>> [ 66%] Built target virtual
>> Scanning dependencies of target widgets
>> [ 66%] Building CXX object InOut/CMakeFiles/widgets.dir/FL_graph.cpp.o
>> /home/lj/data/csound/csound.git/InOut/FL_graph.cpp:25:19: fatal error:
>> FL/Fl.H: No such file or directory #include 
>>                    ^
>> compilation terminated.
>> make[2]: *** [InOut/CMakeFiles/widgets.dir/build.make:63:
>> InOut/CMakeFiles/widgets.dir/FL_graph.cpp.o] Error 1 make[1]: ***
>> [CMakeFiles/Makefile2:2146: InOut/CMakeFiles/widgets.dir/all] Error 2
>> make: *** [Makefile:163: all] Error 2
>>
>>
>> the offending commit is c9be62d3a5fe26036ab1080884aa94aa7c533c70
>> reverting to 38846c3985290000f4aa019ffc3579d196ec1ee6 solves the problem.

in gentoo, upgrading to x11-libs/fltk-1.3.4 puts a FLTKConfig.cmake file
here:

/usr/share/cmake/Modules/FLTKConfig.cmake

but cmake isn't assigning FLTK_DIR:PATH. it still breaks with the same
build error. csound/InOut/FL_graph.cpp:25:19: fatal error: FL/Fl.H: No
such file or directory

k.

On 11/22/2017 12:59 PM, Kelly Hirai wrote:
> isn't /usr/bin/fltk-config --includedir suppose to report this?
> 
> CMakeCache.txt:FLTK_CONFIG_SCRIPT:FILEPATH=/usr/bin/fltk-config
> 
> k.
> 
> On 11/21/2017 08:24 PM, luis jure wrote:
>> now i can't build csound on my gentoo linux machine, because it can't find
>> Fl.H. 
>>
>> fltk is recognized by cmake:
>> -- USE_FLTK is enabled.
>>
>> but then compilation fails thus:
>>
>> [ 66%] Linking CXX shared module ../libvirtual.so
>> [ 66%] Built target virtual
>> Scanning dependencies of target widgets
>> [ 66%] Building CXX object InOut/CMakeFiles/widgets.dir/FL_graph.cpp.o
>> /home/lj/data/csound/csound.git/InOut/FL_graph.cpp:25:19: fatal error:
>> FL/Fl.H: No such file or directory #include 
>>                    ^
>> compilation terminated.
>> make[2]: *** [InOut/CMakeFiles/widgets.dir/build.make:63:
>> InOut/CMakeFiles/widgets.dir/FL_graph.cpp.o] Error 1 make[1]: ***
>> [CMakeFiles/Makefile2:2146: InOut/CMakeFiles/widgets.dir/all] Error 2
>> make: *** [Makefile:163: all] Error 2
>>
>>
>> the offending commit is c9be62d3a5fe26036ab1080884aa94aa7c533c70
>> reverting to 38846c3985290000f4aa019ffc3579d196ec1ee6 solves the problem.

this does allow the build to complete in gentoo for fltk-1.3.3 and
1.3.4. the first 2 examples from the manual on this page work.

http://www.csounds.com/manual/html/ControlFltkIntro.html



k.

On 11/22/2017 12:42 PM, jpff wrote:
> Mabe revert this locally to see if it "fixes" it?
> 
> On Wed, 22 Nov 2017, jpff wrote:
> 
>> Only cage I have found relaed to fltk is in InOut/CMakeLists.txt
>>
>>     #add_dependency_to_framework(virtual ${FLTK_FORMS_LIBRARY})
>>     #add_dependency_to_framework(virtual ${FLTK_IMAGES_LIBRARY})
>> -    include_directories(".")
>> -    include_directories(${FLTK_INCLUDE_DIR})
>> +    target_include_directories(virtual PRIVATE ".")
>> +    target_include_directories(virtual PRIVATE ${FLTK_INCLUDE_DIR})
>> endif()
>>

el 2017-11-22 a las 18:05 jpff escribió:

> CMakeCache.txt:FLTK_INCLUDE_DIR:PATH=/usr/include
> 
> It sondsas if you sould have FLTK_INCLUDE_DIR:PATH=/usr/include/fltk

i do have FLTK_INCLUDE_DIR:PATH=/usr/include/fltk in CMakeCache.txt, but
compilation fails.

reverting InOut/CMakeLists.txt "solves" the problem:

    include_directories(".")
    include_directories(${FLTK_INCLUDE_DIR})
    #target_include_directories(virtual PRIVATE ".")
    #target_include_directories(virtual PRIVATE ${FLTK_INCLUDE_DIR})

el 2017-11-22 a las 17:59 Felipe Sateler escribió:

> The real fix would be to add
> 
> target_include_directories(widgets PRIVATE ${FLTK_INCLUDE_DIR})
> 
> to the widgets block (a few lines before the change you are reverting).
> Could you try if that fixes it?

yes! that indeed solved the problem for me, thank you. could this be
considered a fix and applied to develop?

thanks!

el 2017-11-22 a las 19:27 Felipe Sateler escribió:

> Thanks for confirming. I have pushed the fix to develop.