About your remark "no need for offenses like this."  My message was not
intended as an offense, and I don't think most people would see them as
one. If I offended you, I'm sorry.

I have been and am very supportive of your quality as a developer and of
the value of your work on Csound. I have welcomed your presence as a Csound
developer. I am sure that everyone on this list -- including yourself -- is
aware of that.

Also I know you have indeed fixed many bugs created by others, and that you 
would fix any bugs I told you about -- I have seen you do it.

In the case of the MIDI code, I'm not accusing you of introducing bugs. We 
all introduce them. And I'm not accusing you of making me fix them, instead 
of you. As I said, I know that you would fix them. I'm not "accusing" you
of 
anything.

All I'm saying is that it would have been easy for you to at least make
sure 
that the PortMidi code builds. 

When you work on code that you know affects variant builds or features of
Csound that you don't use -- please make sure that it does build, and do
test if if you can. 

----- Original Message ----- 
From: "Istvan Varga" 
To: 
Sent: Saturday, February 19, 2005 3:04 PM
Subject: Re: [Cs-dev] Fixes for PortMidi


> gogins@pipeline.com wrote:
>
>> After some recent changes by Istvan Varga, I found that PortMidi-enabled
>> code would no longer build. I have fixed that and booked in my changes. I
>> have only been able to test it on Windows. I also made sure that the code
>> compiles without PortMidi enabled, but I did not test that version. I 
>> will
>> test the PortMidi code on Linux early next week.
>
> I have never used PortMIDI, apologies for breaking it. I would find it
> interesting how it was actually broken, though.
>
>> Another bug that has crept in is that Trapped in Convert won't render all
>> sections any more, it stops after the first section.
>
> This is actually a bug in other peoples code that just happened
> to be revealed by my changes. Have a look at this and you can see
> that some function passes a NULL pointer as Csound instance:
>
> Program received signal SIGSEGV, Segmentation fault.
> [Switching to Thread 1078056480 (LWP 9583)]
> mfree (csound=0x0, p=0x81d8578) at Engine/memalloc.c:135
> 135           MEMALLOC_DB = (void*) pp->nxt;
> (gdb) backtrace
> #0  mfree (csound=0x0, p=0x81d8578) at Engine/memalloc.c:135
> #1  0x0807500f in orcompact (csound=0x0) at Engine/insert.c:564
> #2  0x08078705 in sensevents (csound=0x81067e0) at Engine/musmon.c:872
> #3  0x0806552c in csoundPerformKsmps (csound=0x81067e0) at 
> Top/csound.c:199
> #4  0x080503f1 in main (argc=8, argv=0xbffff0e4)
>     at frontends/csound/csound_main.c:156
> (gdb)
>
>> Istvan, I really like the things you have done so far, but how thoroughly
>> are you testing your changes before you commit them? If you CAN test your
>> changes, you should. And if there are areas of Csound that you can't 
>> test,
>> I would appreciate it if you would make sure other people won't mind 
>> doing
>> the testing for you before you commit things.
>>
>> Otherwise, your changes will have the effect of forcing people to work on
>> your code instead of their own.
>
> I can fix any bugs reported, no need for offenses like this. I fixed
> many bugs in code written by others, without complaining that I am
> 'forced to work on their code'.
>
>
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> _______________________________________________
> Csound-devel mailing list
> Csound-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/csound-devel
> 


--------------------------------------------------------------------
mail2web - Check your email from the web at
http://mail2web.com/ .




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id396&op=click
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net

gogins@pipeline.com wrote:

> About your remark "no need for offenses like this."  My message was not
> intended as an offense, and I don't think most people would see them as
> one. If I offended you, I'm sorry.

My response may have been somewhat too defensive. Again, I apologize
for the PortMIDI errors. I noticed that many changes were needed in
MIDI related files to fix the compile problems; fortunately, though,
many of those functions would eventually need an ENVIRON pointer
anyway in order to support multiple instances.
I did fix the Trapped crash (3 lines of change in musmon.c),
now it renders again.


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net

Thanks for fixing *trapped* Istvan and Michael!

-Dr. B.

on 2/19/05 4:12 PM, Istvan Varga at istvan@csounds.com wrote:

> gogins@pipeline.com wrote:
> 
>> About your remark "no need for offenses like this."  My message was not
>> intended as an offense, and I don't think most people would see them as
>> one. If I offended you, I'm sorry.
> 
> My response may have been somewhat too defensive. Again, I apologize
> for the PortMIDI errors. I noticed that many changes were needed in
> MIDI related files to fix the compile problems; fortunately, though,
> many of those functions would eventually need an ENVIRON pointer
> anyway in order to support multiple instances.
> I did fix the Trapped crash (3 lines of change in musmon.c),
> now it renders again.
> 
> 
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> _______________________________________________
> Csound-devel mailing list
> Csound-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/csound-devel

_______________________________________________________________________
 +  Dr. Richard Boulanger, Professor
 +  Music Synthesis Department, Berklee College of Music
 +  1140 Boylston Street  - Boston, MA  02215-3693
 +  Office Phone: (617) 747-2485   Office Fax: (617) 747-2564
 +  eMail: rboulanger@csounds.com  or  rboulanger@berklee.edu
 +  WebPage: http://csounds.com/boulanger/
________________________________________________________________________
 +  Almost Everything Csound @ http://csounds.com/
 +  The Csound Catalog with Audio @ http://csounds.com/catalog/
 +  The Csound Book @ http://csounds.com/book/
 +  The Csound Magazine @ http://csounds.com/ezine/
 +  CsoundForums @ http://csounds.com/phpBB2/
________________________________________________________________________



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net