Csound Csound-dev Csound-tekno Search About

[Cs-dev] Moogladder checkin

Date2005-09-23 00:59
FromSteven Yi
Subject[Cs-dev] Moogladder checkin
AttachmentsNone  

Date2005-09-23 17:06
FromIstvan Varga
SubjectRe: [Cs-dev] Moogladder checkin
Steven Yi wrote:

> It seemed a bit suspect but maybe I'm wrong.  Shouldn't this be:
> 
> static int moogladder_init(CSOUND *csound,moogladder *p)
> {
>     int i;
>     if (*p->istor==FL(0.0)) {
>       for (i=0;i<6; i++) {
>         if(i<3) p->tanhstg[i] = 0;
> 		p->delay[i] = 0;
>       }
>     }
>     return OK;
> }

Fixed, will be committed soon.


-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net

Date2005-09-26 12:12
FromVictor Lazzarini
SubjectRe: [Cs-dev] Moogladder checkin
Yes that was a mistake. Thanks for spotting it.

Victor

At 00:59 23/09/2005, you wrote:
>Hi Victor,
>
>I saw this code in moogladder today while looking at diffs from CVS:
>
>static int moogladder_init(CSOUND *csound,moogladder *p)
>{
>     int i;
>     if (*p->istor==FL(0.0)) {
>       for (i=0;i<6; i++)
>         if(i<3) p->tanhstg[i] = 0;
>                 p->delay[i] = 0;
>     }
>     return OK;
>}
>
>It seemed a bit suspect but maybe I'm wrong.  Shouldn't this be:
>
>static int moogladder_init(CSOUND *csound,moogladder *p)
>{
>     int i;
>     if (*p->istor==FL(0.0)) {
>       for (i=0;i<6; i++) {
>         if(i<3) p->tanhstg[i] = 0;
>                 p->delay[i] = 0;
>       }
>     }
>     return OK;
>}
>
>to get the for loop to wrap around the p->delay[i] ?  Haven't tried
>the new code yet but it seemed to stick out to me and just wanted to
>check to see if was as intended.
>
>Thanks!
>steven
>
>
>-------------------------------------------------------
>SF.Net email is sponsored by:
>Tame your development challenges with Apache's Geronimo App Server. Download
>it for free - -and be entered to win a 42" plasma tv or your very own
>Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
>_______________________________________________
>Csound-devel mailing list
>Csound-devel@lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/csound-devel

Victor Lazzarini
Music Technology Laboratory
Music Department
National University of Ireland, Maynooth 



-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net