I noticed that there seems to be a bug in FLjoy. The y-axis seems
to be inverted, the minimum at the top and the maximum at the bottom.
I don't suppose this is what it should be; normally we would expect
the max at the top.

Now this seems to be a FLTK lib widget code issue. The ybounds()
method seems to set the max to be at the bottom. So if we chnage
line 2975 of widgets.cpp to:

o->ybounds(*p->imaxy,*p->iminy);

and  line 2980 to:

o->ybounds(range,0);

it seems to correct it. Perhaps this is a bug fix that needs to be
incorporated in cs4.23 as well as cs5 for the next bug fix release.

Can anyone with access to CVS do it?


Victor Lazzarini
Music Technology Laboratory
Music Department
National University of Ireland, Maynooth 

On 1/17/05 11:26 AM, Victor Lazzarini  etched in
stone:

> 
> I noticed that there seems to be a bug in FLjoy. The y-axis seems
> to be inverted, the minimum at the top and the maximum at the bottom.
> I don't suppose this is what it should be; normally we would expect
> the max at the top.

Well, this just sort of depends on your perspective :)  The FLTK lib
probably puts the max at the bottom because that is the way that pixels are
measured on the screen (at least on a Mac -- I am assuming it is the same on
other platforms here as well).

I agree though that it probably should be switched.

> Now this seems to be a FLTK lib widget code issue. The ybounds()
> method seems to set the max to be at the bottom. So if we chnage
> line 2975 of widgets.cpp to:
> 
> o->ybounds(*p->imaxy,*p->iminy);
> 
> and  line 2980 to:
> 
> o->ybounds(range,0);
> 
> it seems to correct it. Perhaps this is a bug fix that needs to be
> incorporated in cs4.23 as well as cs5 for the next bug fix release.
> 
> Can anyone with access to CVS do it?

I will put it into my local tree for Cs4.  That way if someone else does not
get to it first, then it will get changed the next time that I commit.

Anthony

Those lines numbers do not make sense on either of my trees
Can you give context?
==John ffitch