After some recent changes by Istvan Varga, I found that PortMidi-enabled
code would no longer build. I have fixed that and booked in my changes. I
have only been able to test it on Windows. I also made sure that the code
compiles without PortMidi enabled, but I did not test that version. I will
test the PortMidi code on Linux early next week.

Another bug that has crept in is that Trapped in Convert won't render all
sections any more, it stops after the first section.

Istvan, I really like the things you have done so far, but how thoroughly
are you testing your changes before you commit them? If you CAN test your
changes, you should. And if there are areas of Csound that you can't test,
I would appreciate it if you would make sure other people won't mind doing
the testing for you before you commit things.

Otherwise, your changes will have the effect of forcing people to work on
your code instead of their own.

Obviously a certain amount of this is unavoidable, and I have probably
caused similar problems myself, but let's please try to keep it to a
minimum.


--------------------------------------------------------------------
mail2web - Check your email from the web at
http://mail2web.com/ .




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id396&op=click
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net

gogins@pipeline.com wrote:

> After some recent changes by Istvan Varga, I found that PortMidi-enabled
> code would no longer build. I have fixed that and booked in my changes. I
> have only been able to test it on Windows. I also made sure that the code
> compiles without PortMidi enabled, but I did not test that version. I will
> test the PortMidi code on Linux early next week.

I have never used PortMIDI, apologies for breaking it. I would find it
interesting how it was actually broken, though.

> Another bug that has crept in is that Trapped in Convert won't render all
> sections any more, it stops after the first section.

This is actually a bug in other peoples code that just happened
to be revealed by my changes. Have a look at this and you can see
that some function passes a NULL pointer as Csound instance:

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 1078056480 (LWP 9583)]
mfree (csound=0x0, p=0x81d8578) at Engine/memalloc.c:135
135           MEMALLOC_DB = (void*) pp->nxt;
(gdb) backtrace
#0  mfree (csound=0x0, p=0x81d8578) at Engine/memalloc.c:135
#1  0x0807500f in orcompact (csound=0x0) at Engine/insert.c:564
#2  0x08078705 in sensevents (csound=0x81067e0) at Engine/musmon.c:872
#3  0x0806552c in csoundPerformKsmps (csound=0x81067e0) at Top/csound.c:199
#4  0x080503f1 in main (argc=8, argv=0xbffff0e4)
     at frontends/csound/csound_main.c:156
(gdb)

> Istvan, I really like the things you have done so far, but how thoroughly
> are you testing your changes before you commit them? If you CAN test your
> changes, you should. And if there are areas of Csound that you can't test,
> I would appreciate it if you would make sure other people won't mind doing
> the testing for you before you commit things.
> 
> Otherwise, your changes will have the effect of forcing people to work on
> your code instead of their own.

I can fix any bugs reported, no need for offenses like this. I fixed
many bugs in code written by others, without complaining that I am
'forced to work on their code'.


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net

gogins@pipeline.com wrote:

> Another bug that has crept in is that Trapped in Convert won't render all
> sections any more, it stops after the first section.

Fixed and committed: musmon.c had an incorrect prototype for orcompact(),
which takes a void* csound argument, but musmon assumed it was simply
void orcompact(void). It was not my error, but the changes I made have
triggered it.


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net