Hi All,

I think I got the string channels fixed.  I modified
csoundStringChannelGet and csoundStringChannelSet to use STRINGDAT.
chnexport had this code:

    if(type == CSOUND_STRING_CHANNEL)
      chn->data = (MYFLT *) ((STRINGDAT *)p->arg)->data;
    else
      chn->data = p->arg;

This was actually always going to the else branch, as type was
bit-or'd earlier with input or output type, so would never be == to
CSOUND_STRING_CHANNEL.  This is fine as we want the channel's data
pointer to be pointing to the STRINGDAT that is given as an arg, so I
just removed the if-branch. chnget and chnset already assumed
STRINGDAT, so I left those alone.

I am no longer getting crashes here with the example project Menno
sent me, nor with the python test script.

I've pushed that changed to GIT develop branch.  Victor: Could you
double check the code change?

Thanks!
steven

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net

oh, that was simpler than I thought, just a bug in the comparison, well done. That looks OK to me.
Thanks. I guess we can proceed to the release. I need to do two manual pages before that, which I’ll do today.

Victor
On 31 Dec 2013, at 04:25, Steven Yi  wrote:

> Hi All,
> 
> I think I got the string channels fixed.  I modified
> csoundStringChannelGet and csoundStringChannelSet to use STRINGDAT.
> chnexport had this code:
> 
>    if(type == CSOUND_STRING_CHANNEL)
>      chn->data = (MYFLT *) ((STRINGDAT *)p->arg)->data;
>    else
>      chn->data = p->arg;
> 
> This was actually always going to the else branch, as type was
> bit-or'd earlier with input or output type, so would never be == to
> CSOUND_STRING_CHANNEL.  This is fine as we want the channel's data
> pointer to be pointing to the STRINGDAT that is given as an arg, so I
> just removed the if-branch. chnget and chnset already assumed
> STRINGDAT, so I left those alone.
> 
> I am no longer getting crashes here with the example project Menno
> sent me, nor with the python test script.
> 
> I've pushed that changed to GIT develop branch.  Victor: Could you
> double check the code change?
> 
> Thanks!
> steven
> 
> ------------------------------------------------------------------------------
> Rapidly troubleshoot problems before they affect your business. Most IT 
> organizations don't have a clear picture of how application performance 
> affects their revenue. With AppDynamics, you get 100% visibility into your 
> Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
> http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
> _______________________________________________
> Csound-devel mailing list
> Csound-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/csound-devel


------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net

Oh there was a bit more than the comparison, but it wasn't too bad in the end. Seems like all is good now. :)

What else was needed?
On 1 Jan 2014, at 18:01, Steven Yi  wrote:

> Oh there was a bit more than the comparison, but it wasn't too bad in the end. Seems like all is good now. :)
> 
> On Dec 31, 2013 5:11 AM, "Victor Lazzarini"  wrote:
> oh, that was simpler than I thought, just a bug in the comparison, well done. That looks OK to me.
> Thanks. I guess we can proceed to the release. I need to do two manual pages before that, which I’ll do today.
> 
> Victor
> On 31 Dec 2013, at 04:25, Steven Yi  wrote:
> 
> > Hi All,
> >
> > I think I got the string channels fixed.  I modified
> > csoundStringChannelGet and csoundStringChannelSet to use STRINGDAT.
> > chnexport had this code:
> >
> >    if(type == CSOUND_STRING_CHANNEL)
> >      chn->data = (MYFLT *) ((STRINGDAT *)p->arg)->data;
> >    else
> >      chn->data = p->arg;
> >
> > This was actually always going to the else branch, as type was
> > bit-or'd earlier with input or output type, so would never be == to
> > CSOUND_STRING_CHANNEL.  This is fine as we want the channel's data
> > pointer to be pointing to the STRINGDAT that is given as an arg, so I
> > just removed the if-branch. chnget and chnset already assumed
> > STRINGDAT, so I left those alone.
> >
> > I am no longer getting crashes here with the example project Menno
> > sent me, nor with the python test script.
> >
> > I've pushed that changed to GIT develop branch.  Victor: Could you
> > double check the code change?
> >
> > Thanks!
> > steven
> >
> > ------------------------------------------------------------------------------
> > Rapidly troubleshoot problems before they affect your business. Most IT
> > organizations don't have a clear picture of how application performance
> > affects their revenue. With AppDynamics, you get 100% visibility into your
> > Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
> > http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
> > _______________________________________________
> > Csound-devel mailing list
> > Csound-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/csound-devel
> 
> 
> ------------------------------------------------------------------------------
> Rapidly troubleshoot problems before they affect your business. Most IT
> organizations don't have a clear picture of how application performance
> affects their revenue. With AppDynamics, you get 100% visibility into your
> Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
> http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
> _______________________________________________
> Csound-devel mailing list
> Csound-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/csound-devel
> ------------------------------------------------------------------------------
> Rapidly troubleshoot problems before they affect your business. Most IT 
> organizations don't have a clear picture of how application performance 
> affects their revenue. With AppDynamics, you get 100% visibility into your 
> Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
> http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk_______________________________________________
> Csound-devel mailing list
> Csound-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/csound-devel


------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net

ah, yes, that was the fix I had in mind. I’m glad it worked out.
On 1 Jan 2014, at 21:55, stevenyi@gmail.com wrote:

> I had to change csoundGetStringChannel and csoundSetStringChannel to use STRINGDAT. I also changed the function that allocated the data pointer for channels to use sizeof(STRINGDAT) instead of the  constant that was there.
> 
> From: Victor Lazzarini
> Sent: ‎Wednesday‎, ‎January‎ ‎1‎, ‎2014 ‎1‎:‎14‎ ‎PM
> To: Developer discussions
> 
> What else was needed?
> On 1 Jan 2014, at 18:01, Steven Yi  wrote:
> 
> > Oh there was a bit more than the comparison, but it wasn't too bad in the end. Seems like all is good now. :)
> > 
> > On Dec 31, 2013 5:11 AM, "Victor Lazzarini"  wrote:
> > oh, that was simpler than I thought, just a bug in the comparison, well done. That looks OK to me.
> > Thanks. I guess we can proceed to the release. I need to do two manual pages before that, which I’ll do today.
> > 
> > Victor
> > On 31 Dec 2013, at 04:25, Steven Yi  wrote:
> > 
> > > Hi All,
> > >
> > > I think I got the string channels fixed.  I modified
> > > csoundStringChannelGet and csoundStringChannelSet to use STRINGDAT.
> > > chnexport had this code:
> > >
> > >    if(type == CSOUND_STRING_CHANNEL)
> > >      chn->data = (MYFLT *) ((STRINGDAT *)p->arg)->data;
> > >    else
> > >      chn->data = p->arg;
> > >
> > > This was actually always going to the else branch, as type was
> > > bit-or'd earlier with input or output type, so would never be == to
> > > CSOUND_STRING_CHANNEL.  This is fine as we want the channel's data
> > > pointer to be pointing to the STRINGDAT that is given as an arg, so I
> > > just removed the if-branch. chnget and chnset already assumed
> > > STRINGDAT, so I left those alone.
> > >
> > > I am no longer getting crashes here with the example project Menno
> > > sent me, nor with the python test script.
> > >
> > > I've pushed that changed to GIT develop branch.  Victor: Could you
> > > double check the code change?
> > >
> > > Thanks!
> > > steven
> > >
> > > ------------------------------------------------------------------------------
> > > Rapidly troubleshoot problems before they affect your business. Most IT
> > > organizations don't have a clear picture of how application performance
> > > affects their revenue. With AppDynamics, you get 100% visibility into your
> > > Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
> > > http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
> > > _______________________________________________
> > > Csound-devel mailing list
> > > Csound-devel@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/csound-devel
> > 
> > 
> > ------------------------------------------------------------------------------
> > Rapidly troubleshoot problems before they affect your business. Most IT
> > organizations don't have a clear picture of how application performance
> > affects their revenue. With AppDynamics, you get 100% visibility into your
> > Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
> > http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
> > _______________________________________________
> > Csound-devel mailing list
> > Csound-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/csound-devel
> > ------------------------------------------------------------------------------
> > Rapidly troubleshoot problems before they affect your business. Most IT 
> > organizations don't have a clear picture of how application performance 
> > affects their revenue. With AppDynamics, you get 100% visibility into your 
> > Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
> > http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk_______________________________________________
> > Csound-devel mailing list
> > Csound-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/csound-devel
> 
> 
> ------------------------------------------------------------------------------
> Rapidly troubleshoot problems before they affect your business. Most IT 
> organizations don't have a clear picture of how application performance 
> affects their revenue. With AppDynamics, you get 100% visibility into your 
> Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
> http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
> _______________________________________________
> Csound-devel mailing list
> Csound-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/csound-devel
> ------------------------------------------------------------------------------
> Rapidly troubleshoot problems before they affect your business. Most IT 
> organizations don't have a clear picture of how application performance 
> affects their revenue. With AppDynamics, you get 100% visibility into your 
> Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
> http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk_______________________________________________
> Csound-devel mailing list
> Csound-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/csound-devel


------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net
https://li