[Cs-dev] Coverity defects

[Cs-dev] Coverity defects

Date	2014-05-21 07:56
From	john ffitch
Subject	[Cs-dev] Coverity defects
	I have fixed about 70 of the defects but I only have a few left that I understand. (mainly score sorting) 1: early half the outstanding defects are in swig generated code for python. I do not know what we can do about these. 2: There are more defects in the csdebug code (eg ids 56131-56136) 3: A few in the mp3 decode which I suppose is my responsibility 4: CSoundAC has a collection in addition to the SWIG generated ones (ids 27639, 27370 etc) 5: There are a few in insert.c and friends relating to locks 6: A few are in C++ code I do not understand (eg filebuilding.cpp id 27365) 7: There are others I have not classified ==John ffitch ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ Csound-devel mailing list Csound-devel@lists.sourceforge.net

Date	2014-05-21 09:28
From	Victor Lazzarini
Subject	Re: [Cs-dev] Coverity defects
	I’ll work on the insert.c issues. ======================== Dr Victor Lazzarini Senior Lecturer NUI Maynooth, Ireland victor dot lazzarini at nuim dot ie On 21 May 2014, at 07:56, john ffitch wrote: > I have fixed about 70 of the defects but I only have a few left that I > understand. (mainly score sorting) > > 1: early half the outstanding defects are in swig generated code for > python. I do not know what we can do about these. > > 2: There are more defects in the csdebug code (eg ids 56131-56136) > > 3: A few in the mp3 decode which I suppose is my responsibility > > 4: CSoundAC has a collection in addition to the SWIG generated ones > (ids 27639, 27370 etc) > > 5: There are a few in insert.c and friends relating to locks > > 6: A few are in C++ code I do not understand (eg filebuilding.cpp id > 27365) > > 7: There are others I have not classified > > ==John ffitch > > ------------------------------------------------------------------------------ > "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE > Instantly run your Selenium tests across 300+ browser/OS combos. > Get unparalleled scalability from the best Selenium testing platform available > Simple to use. Nothing to install. Get started now for free." > http://p.sf.net/sfu/SauceLabs > _______________________________________________ > Csound-devel mailing list > Csound-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/csound-devel ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ Csound-devel mailing list Csound-devel@lists.sourceforge.net

Date	2014-05-21 16:34
From	Steven Yi
Subject	Re: [Cs-dev] Coverity defects
	There are more issues under the "Outstanding defects" section. I've gone ahead and blanket selected the SWIG-related ones and have marked them as "ignore". On Wed, May 21, 2014 at 4:28 AM, Victor Lazzarini wrote: > I’ll work on the insert.c issues. > ======================== > Dr Victor Lazzarini > Senior Lecturer > NUI Maynooth, Ireland > victor dot lazzarini at nuim dot ie > > > > > On 21 May 2014, at 07:56, john ffitch wrote: > >> I have fixed about 70 of the defects but I only have a few left that I >> understand. (mainly score sorting) >> >> 1: early half the outstanding defects are in swig generated code for >> python. I do not know what we can do about these. >> >> 2: There are more defects in the csdebug code (eg ids 56131-56136) >> >> 3: A few in the mp3 decode which I suppose is my responsibility >> >> 4: CSoundAC has a collection in addition to the SWIG generated ones >> (ids 27639, 27370 etc) >> >> 5: There are a few in insert.c and friends relating to locks >> >> 6: A few are in C++ code I do not understand (eg filebuilding.cpp id >> 27365) >> >> 7: There are others I have not classified >> >> ==John ffitch >> >> ------------------------------------------------------------------------------ >> "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE >> Instantly run your Selenium tests across 300+ browser/OS combos. >> Get unparalleled scalability from the best Selenium testing platform available >> Simple to use. Nothing to install. Get started now for free." >> http://p.sf.net/sfu/SauceLabs >> _______________________________________________ >> Csound-devel mailing list >> Csound-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/csound-devel > > > ------------------------------------------------------------------------------ > "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE > Instantly run your Selenium tests across 300+ browser/OS combos. > Get unparalleled scalability from the best Selenium testing platform available > Simple to use. Nothing to install. Get started now for free." > http://p.sf.net/sfu/SauceLabs > _______________________________________________ > Csound-devel mailing list > Csound-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/csound-devel ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ Csound-devel mailing list Csound-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/csou

Date	2014-05-21 21:53
From	Andres Cabrera
Subject	Re: [Cs-dev] Coverity defects
Attachments	None None
	Hi, On Tue, May 20, 2014 at 11:56 PM, john ffitch <jpff@codemist.co.uk> wrote: 2: There are more defects in the csdebug code (eg ids 56131-56136) I'll fix these. Although I suspect the solution might not be picked up by coverity. The issue is that I am doing allocation in a non-rt context and then passing a pointer to the audio thread in a circular buffer. The debug engine should keep tab of the ones that need freeing for later, but since that will be done somewhere else, I suspect coverity might still think this memory is leaking. Cheers, Andrés

Date	2014-05-21 22:27
From	Andres Cabrera
Subject	Re: [Cs-dev] Coverity defects
Attachments	None None
	Hi, After double checking, this memory is actually freed inside kperf_debug. So the coverity reports for csdebug are not correct. Closed the coverity defects. Cheers, Andrés On Wed, May 21, 2014 at 1:53 PM, Andres Cabrera <mantaraya36@gmail.com> wrote: Hi, On Tue, May 20, 2014 at 11:56 PM, john ffitch <jpff@codemist.co.uk> wrote: 2: There are more defects in the csdebug code (eg ids 56131-56136) I'll fix these. Although I suspect the solution might not be picked up by coverity. The issue is that I am doing allocation in a non-rt context and then passing a pointer to the audio thread in a circular buffer. The debug engine should keep tab of the ones that need freeing for later, but since that will be done somewhere else, I suspect coverity might still think this memory is leaking. Cheers, Andrés