Csound Csound-dev Csound-tekno Search About

[Csnd-dev] Since CI build fails

Date2022-01-15 16:56
FromJohn ff
Subject[Csnd-dev] Since CI build fails
  lots of errors like this


C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\um\oleidl.h(1348,52): error C2146: syntax error: missing ')' before identifier 'lpmsg' [D:\a\csound\csound\build\csound64.vcxproj]


22C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\um\oleidl.h(1348,52): error C2081: 'LPMSG': name in formal parameter list illegal [D:\a\csound\csound\build\csound64.vcxproj]


23C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\um\oleidl.h(1348,52): error C2146: syntax error: missing ';' before identifier 'lpmsg' [D:\a\csound\csound\build\csound64.vcxproj]


24C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\um\oleidl.h(1348,52): error C2061: syntax error: identifier 'lpmsg' [D:\a\csound\csound\build\csound64.vcxproj]


25C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\um\oleidl.h(1352,65): error C2059: syntax error: ')' [D:\a\csound\csound\build\csound64.vcxproj]


etc etc





Date2022-01-16 00:55
FromStephen Kyne
SubjectRe: [Csnd-dev] Since CI build fails

It seems like moving NOMSG into a header like that has caused the build errors. I did a bit of searching and it seems there is a Windows one named the same. I imagine this is causing some build problems within the Windows includes. Can we rename this something else? I would say it's best practice to prefix all our symbols with something to avoid clashes maybe.

Stephen

From: Csound-developers <CSOUND-DEV@LISTSERV.HEANET.IE> on behalf of John ff <jpff@CODEMIST.CO.UK>
Sent: Saturday 15 January 2022 16:56
To: CSOUND-DEV@LISTSERV.HEANET.IE <CSOUND-DEV@LISTSERV.HEANET.IE>
Subject: [Csnd-dev] Since CI build fails
 
  lots of errors like this


C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\um\oleidl.h(1348,52): error C2146: syntax error: missing ')' before identifier 'lpmsg' [D:\a\csound\csound\build\csound64.vcxproj]


22C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\um\oleidl.h(1348,52): error C2081: 'LPMSG': name in formal parameter list illegal [D:\a\csound\csound\build\csound64.vcxproj]


23C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\um\oleidl.h(1348,52): error C2146: syntax error: missing ';' before identifier 'lpmsg' [D:\a\csound\csound\build\csound64.vcxproj]


24C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\um\oleidl.h(1348,52): error C2061: syntax error: identifier 'lpmsg' [D:\a\csound\csound\build\csound64.vcxproj]


25C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\um\oleidl.h(1352,65): error C2059: syntax error: ')' [D:\a\csound\csound\build\csound64.vcxproj]


etc etc





Date2022-01-16 15:45
FromJohn ff
SubjectRe: [Csnd-dev] Since CI build fails
OK I will rename these constants. May take a while.


On 16 Jan 2022, at 00:55, Stephen Kyne <stevek@outlook.ie> wrote:

It seems like moving NOMSG into a header like that has caused the build errors. I did a bit of searching and it seems there is a Windows one named the same. I imagine this is causing some build problems within the Windows includes. Can we rename this something else? I would say it's best practice to prefix all our symbols with something to avoid clashes maybe.

Stephen

From: Csound-developers <CSOUND-DEV@LISTSERV.HEANET.IE> on behalf of John ff <jpff@CODEMIST.CO.UK>
Sent: Saturday 15 January 2022 16:56
To: CSOUND-DEV@LISTSERV.HEANET.IE <CSOUND-DEV@LISTSERV.HEANET.IE>
Subject: [Csnd-dev] Since CI build fails
 
  lots of errors like this


C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\um\oleidl.h(1348,52): error C2146: syntax error: missing ')' before identifier 'lpmsg' [D:\a\csound\csound\build\csound64.vcxproj]


22C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\um\oleidl.h(1348,52): error C2081: 'LPMSG': name in formal parameter list illegal [D:\a\csound\csound\build\csound64.vcxproj]


23C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\um\oleidl.h(1348,52): error C2146: syntax error: missing ';' before identifier 'lpmsg' [D:\a\csound\csound\build\csound64.vcxproj]


24C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\um\oleidl.h(1348,52): error C2061: syntax error: identifier 'lpmsg' [D:\a\csound\csound\build\csound64.vcxproj]


25C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\um\oleidl.h(1352,65): error C2059: syntax error: ')' [D:\a\csound\csound\build\csound64.vcxproj]


etc etc





Date2022-01-16 21:35
FromStephen Kyne
SubjectRe: [Csnd-dev] Since CI build fails
I did a temporary fix of just renaming NOFIX->NO_FIX. It has fixed the issue. 

Stephen

From: Csound-developers <CSOUND-DEV@LISTSERV.HEANET.IE> on behalf of John ff <jpff@CODEMIST.CO.UK>
Sent: Sunday 16 January 2022 15:45
To: CSOUND-DEV@LISTSERV.HEANET.IE <CSOUND-DEV@LISTSERV.HEANET.IE>
Subject: Re: [Csnd-dev] Since CI build fails
 
OK I will rename these constants. May take a while.


On 16 Jan 2022, at 00:55, Stephen Kyne <stevek@outlook.ie> wrote:

It seems like moving NOMSG into a header like that has caused the build errors. I did a bit of searching and it seems there is a Windows one named the same. I imagine this is causing some build problems within the Windows includes. Can we rename this something else? I would say it's best practice to prefix all our symbols with something to avoid clashes maybe.

Stephen

From: Csound-developers <CSOUND-DEV@LISTSERV.HEANET.IE> on behalf of John ff <jpff@CODEMIST.CO.UK>
Sent: Saturday 15 January 2022 16:56
To: CSOUND-DEV@LISTSERV.HEANET.IE <CSOUND-DEV@LISTSERV.HEANET.IE>
Subject: [Csnd-dev] Since CI build fails
 
  lots of errors like this


C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\um\oleidl.h(1348,52): error C2146: syntax error: missing ')' before identifier 'lpmsg' [D:\a\csound\csound\build\csound64.vcxproj]


22C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\um\oleidl.h(1348,52): error C2081: 'LPMSG': name in formal parameter list illegal [D:\a\csound\csound\build\csound64.vcxproj]


23C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\um\oleidl.h(1348,52): error C2146: syntax error: missing ';' before identifier 'lpmsg' [D:\a\csound\csound\build\csound64.vcxproj]


24C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\um\oleidl.h(1348,52): error C2061: syntax error: identifier 'lpmsg' [D:\a\csound\csound\build\csound64.vcxproj]


25C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\um\oleidl.h(1352,65): error C2059: syntax error: ')' [D:\a\csound\csound\build\csound64.vcxproj]


etc etc