[Cs-dev] Patch: Initialize channel hints in results from csoundListChannels()
Date | 2013-05-10 19:56 |
From | Henrik Andersson |
Subject | [Cs-dev] Patch: Initialize channel hints in results from csoundListChannels() |
Attachments | 0001-Copy-over-hints-from-CHNENTRY-into-list.patch None None |
Date | 2013-05-11 09:36 |
From | Steven Yi |
Subject | Re: [Cs-dev] Patch: Initialize channel hints in results from csoundListChannels() |
Hi Henrik, I've applied the patch attached here and pushed the change to the repo. I'll close out the two merge requests as they don't have any commits associated with them. Thanks! steven On Fri, May 10, 2013 at 8:56 PM, Henrik Andersson |
Date | 2013-05-11 09:38 |
From | Henrik Andersson |
Subject | Re: [Cs-dev] Patch: Initialize channel hints in results from csoundListChannels() |
Attachments | None None |
Thanks, Next time i will spend some time into why it wouldn't work.. /Henrik 2013/5/11 Steven Yi <stevenyi@gmail.com> Hi Henrik, |
Date | 2013-05-11 09:44 |
From | Steven Yi |
Subject | Re: [Cs-dev] Patch: Initialize channel hints in results from csoundListChannels() |
Actually, I think it did work, but it wasn't how I expected it. I had originally looked at it without having logged in, and it didn't show any commit or patch in particular. After I logged in, it gave commands to type in to fetch from your fork and merge in the commit. It's a bit clunky compared to GitHub I think. I know some projects use GitHub now for their source code, but keep all their other stuff on SourceForge (i.e. file releases, mailing lists, wiki, etc.). There may be some benefit to do this for Csound, but getting git patches is easy enough to read through. Thanks! steven On Sat, May 11, 2013 at 10:38 AM, Henrik Andersson |
Date | 2013-05-11 10:21 |
From | Henrik Andersson |
Subject | Re: [Cs-dev] Patch: Initialize channel hints in results from csoundListChannels() |
Attachments | None None |
Oh ok... to apply gitformatted patches just like the one i sent, do: git am < 0001_xx_yy_zz.patch This will get commit hash / commiter from the patch and would
prevent my problems when i merge my branch which had that commit with upstream. /H /Henrik 2013/5/11 Steven Yi <stevenyi@gmail.com> Actually, I think it did work, but it wasn't how I expected it. I had |
Date | 2013-05-11 10:25 |
From | Steven Yi |
Subject | Re: [Cs-dev] Patch: Initialize channel hints in results from csoundListChannels() |
I had used the patch you sent vs. the merge request and used "git apply [patch file]" and that worked fine. Getting the patch wasn't such a problem, but the merge request system in SourceForge was just awkward. On Sat, May 11, 2013 at 11:21 AM, Henrik Andersson |
Date | 2013-05-11 10:28 |
From | Henrik Andersson |
Subject | Re: [Cs-dev] Patch: Initialize channel hints in results from csoundListChannels() |
Attachments | None None |
Ah ok, i got confused.. nevermind :) 2013/5/11 Steven Yi <stevenyi@gmail.com> I had used the patch you sent vs. the merge request and used "git |