| yes, you're correct, that's a bug.
Victor
At 07:48 01/02/2007, you wrote:
>I have been trawling through the code looking for optimisations and I
>noticed a potential generic problem.
>
>I am not trying to pick on anyone, but for example consider pvsdemix.c
>where the initialisation code says
>...
> if (p->fout->frame.auxp==NULL)
> csound->AuxAlloc(csound, (N+2)*sizeof(float),&p->fout->frame);
>
> if (p->left.auxp==NULL)
> csound->AuxAlloc(csound, (N+2)*sizeof(float)*p->beta, &p->left);
>...
>
>This assumes that the previous use of this structure had the same or
>larger value of N (which is the frame size).
>
>I suspect that the code needs to be
>
> if (p->fout->frame.auxp==NULL || p->fout->frame.size<(N+2)*sizeof(float))
> csound->AuxAlloc(csound, (N+2)*sizeof(float),&p->fout->frame);
>
>or probably as good
>
> csound->AuxAlloc(csound, (N+2)*sizeof(float),&p->fout->frame);
>
>
>A very long time ago I fixed a bug in grain with the same error.
>I am happy to do the changes but the question is am I correct? Or
>have I misunderstood?
>
>==John ffitch
>
>-------------------------------------------------------------------------
>Using Tomcat but need to do more? Need to support web services, security?
>Get stuff done quickly with pre-integrated technology to make your job easier.
>Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
>http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
>_______________________________________________
>Csound-devel mailing list
>Csound-devel@lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/csound-devel
Victor Lazzarini
Music Technology Laboratory
Music Department
National University of Ireland, Maynooth
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net |