Csound Csound-dev Csound-tekno Search About

Re: [Csnd-dev] manual totally broken

Date2017-01-19 17:35
FromNate Whetsell
SubjectRe: [Csnd-dev] manual totally broken
I just replied to Dave off-list, but

make clean && make XSL_BASE_PATH=/usr/share/xml/docbook/stylesheet/nwalsh pdf

Date2017-01-19 17:40
FromFelipe Sateler
SubjectRe: [Csnd-dev] manual totally broken
I think its best to do this: Relying on directories as make targets is
wrong, as the target is created even if csd2docbook.py fails.

diff --git a/Makefile b/Makefile
index 338590e..61764ee 100644
--- a/Makefile
+++ b/Makefile
@@ -683,7 +683,7 @@ OTHER =         STKopcodes/top.xml \
         manual.xml

 SRCS =  $(COMMAND) $(CONTROL) $(XMLS) $(MIDI) $(OPCODES) $(ORCH) $(SCORE) \
-       $(SIGS) $(UTILS) $(MISC) $(OTHER) examples-xml
+       $(SIGS) $(UTILS) $(MISC) $(OTHER) examples-xml/stamp

 # Build rules.
 all: html
@@ -694,9 +694,10 @@ $(XSL_HTML) $(XSL_HTMLHELP) $(XSL_PRINT)
$(XSL_HTML_ONECHUNK): %: %.in
         false )
        sed -e 's|@xsl_base_path@|$(XSL_BASE_PATH)|' $@.in > $@

-examples-xml: examples $(wildcard examples/*)
+examples-xml/stamp: examples $(wildcard examples/*)
        mkdir -p examples-xml
        python csd2docbook.py
+       touch examples-xml/stamp

 html: $(XSL_HTML) manual.xml $(SRCS) Makefile
        rm -rf html

On 19 January 2017 at 14:35, Nate Whetsell  wrote:
> I just replied to Dave off-list, but
>
> make clean && make XSL_BASE_PATH=/usr/share/xml/docbook/stylesheet/nwalsh pdf
>
> should work.



-- 

Saludos,

Date2017-01-19 17:51
FromSteven Yi
SubjectRe: [Csnd-dev] manual totally broken
I couldn't apply the patch (probably difference in newlines or
something here on Windows), but it looks good to me at a glance. Could
you push a commit with the change?

On Thu, Jan 19, 2017 at 12:40 PM, Felipe Sateler  wrote:
> I think its best to do this: Relying on directories as make targets is
> wrong, as the target is created even if csd2docbook.py fails.
>
> diff --git a/Makefile b/Makefile
> index 338590e..61764ee 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -683,7 +683,7 @@ OTHER =         STKopcodes/top.xml \
>          manual.xml
>
>  SRCS =  $(COMMAND) $(CONTROL) $(XMLS) $(MIDI) $(OPCODES) $(ORCH) $(SCORE) \
> -       $(SIGS) $(UTILS) $(MISC) $(OTHER) examples-xml
> +       $(SIGS) $(UTILS) $(MISC) $(OTHER) examples-xml/stamp
>
>  # Build rules.
>  all: html
> @@ -694,9 +694,10 @@ $(XSL_HTML) $(XSL_HTMLHELP) $(XSL_PRINT)
> $(XSL_HTML_ONECHUNK): %: %.in
>          false )
>         sed -e 's|@xsl_base_path@|$(XSL_BASE_PATH)|' $@.in > $@
>
> -examples-xml: examples $(wildcard examples/*)
> +examples-xml/stamp: examples $(wildcard examples/*)
>         mkdir -p examples-xml
>         python csd2docbook.py
> +       touch examples-xml/stamp
>
>  html: $(XSL_HTML) manual.xml $(SRCS) Makefile
>         rm -rf html
>
> On 19 January 2017 at 14:35, Nate Whetsell  wrote:
>> I just replied to Dave off-list, but
>>
>> make clean && make XSL_BASE_PATH=/usr/share/xml/docbook/stylesheet/nwalsh pdf
>>
>> should work.
>
>
>
> --
>
> Saludos,

Date2017-01-19 18:03
FromVictor Lazzarini
SubjectRe: [Csnd-dev] manual totally broken
Shouldn't we use cmake for this?

Victor Lazzarini
Dean of Arts, Celtic Studies, and Philosophy
Maynooth University
Ireland

> On 19 Jan 2017, at 17:41, Felipe Sateler  wrote:
> 
> I think its best to do this: Relying on directories as make targets is
> wrong, as the target is created even if csd2docbook.py fails.
> 
> diff --git a/Makefile b/Makefile
> index 338590e..61764ee 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -683,7 +683,7 @@ OTHER =         STKopcodes/top.xml \
>         manual.xml
> 
> SRCS =  $(COMMAND) $(CONTROL) $(XMLS) $(MIDI) $(OPCODES) $(ORCH) $(SCORE) \
> -       $(SIGS) $(UTILS) $(MISC) $(OTHER) examples-xml
> +       $(SIGS) $(UTILS) $(MISC) $(OTHER) examples-xml/stamp
> 
> # Build rules.
> all: html
> @@ -694,9 +694,10 @@ $(XSL_HTML) $(XSL_HTMLHELP) $(XSL_PRINT)
> $(XSL_HTML_ONECHUNK): %: %.in
>         false )
>        sed -e 's|@xsl_base_path@|$(XSL_BASE_PATH)|' $@.in > $@
> 
> -examples-xml: examples $(wildcard examples/*)
> +examples-xml/stamp: examples $(wildcard examples/*)
>        mkdir -p examples-xml
>        python csd2docbook.py
> +       touch examples-xml/stamp
> 
> html: $(XSL_HTML) manual.xml $(SRCS) Makefile
>        rm -rf html
> 
>> On 19 January 2017 at 14:35, Nate Whetsell  wrote:
>> I just replied to Dave off-list, but
>> 
>> make clean && make XSL_BASE_PATH=/usr/share/xml/docbook/stylesheet/nwalsh pdf
>> 
>> should work.
> 
> 
> 
> -- 
> 
> Saludos,

Date2017-01-19 18:13
FromFelipe Sateler
SubjectRe: [Csnd-dev] manual totally broken
Probably space/tab messiness from the copy/paste. I submitted a PR via
the web interface (so that travis has a chance to run), because I'm
not carrying my ssh key here.

On 19 January 2017 at 14:51, Steven Yi  wrote:
> I couldn't apply the patch (probably difference in newlines or
> something here on Windows), but it looks good to me at a glance. Could
> you push a commit with the change?
>
> On Thu, Jan 19, 2017 at 12:40 PM, Felipe Sateler  wrote:
>> I think its best to do this: Relying on directories as make targets is
>> wrong, as the target is created even if csd2docbook.py fails.
>>
>> diff --git a/Makefile b/Makefile
>> index 338590e..61764ee 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -683,7 +683,7 @@ OTHER =         STKopcodes/top.xml \
>>          manual.xml
>>
>>  SRCS =  $(COMMAND) $(CONTROL) $(XMLS) $(MIDI) $(OPCODES) $(ORCH) $(SCORE) \
>> -       $(SIGS) $(UTILS) $(MISC) $(OTHER) examples-xml
>> +       $(SIGS) $(UTILS) $(MISC) $(OTHER) examples-xml/stamp
>>
>>  # Build rules.
>>  all: html
>> @@ -694,9 +694,10 @@ $(XSL_HTML) $(XSL_HTMLHELP) $(XSL_PRINT)
>> $(XSL_HTML_ONECHUNK): %: %.in
>>          false )
>>         sed -e 's|@xsl_base_path@|$(XSL_BASE_PATH)|' $@.in > $@
>>
>> -examples-xml: examples $(wildcard examples/*)
>> +examples-xml/stamp: examples $(wildcard examples/*)
>>         mkdir -p examples-xml
>>         python csd2docbook.py
>> +       touch examples-xml/stamp
>>
>>  html: $(XSL_HTML) manual.xml $(SRCS) Makefile
>>         rm -rf html
>>
>> On 19 January 2017 at 14:35, Nate Whetsell  wrote:
>>> I just replied to Dave off-list, but
>>>
>>> make clean && make XSL_BASE_PATH=/usr/share/xml/docbook/stylesheet/nwalsh pdf
>>>
>>> should work.
>>
>>
>>
>> --
>>
>> Saludos,
>> Felipe Sateler



-- 

Saludos,

Date2017-01-19 18:45
FromSteven Yi
SubjectRe: [Csnd-dev] manual totally broken
Thanks Felipe, that worked well here on Windows so I merged the PR.  Cheers!

On Thu, Jan 19, 2017 at 1:13 PM, Felipe Sateler  wrote:
> Probably space/tab messiness from the copy/paste. I submitted a PR via
> the web interface (so that travis has a chance to run), because I'm
> not carrying my ssh key here.
>
> On 19 January 2017 at 14:51, Steven Yi  wrote:
>> I couldn't apply the patch (probably difference in newlines or
>> something here on Windows), but it looks good to me at a glance. Could
>> you push a commit with the change?
>>
>> On Thu, Jan 19, 2017 at 12:40 PM, Felipe Sateler  wrote:
>>> I think its best to do this: Relying on directories as make targets is
>>> wrong, as the target is created even if csd2docbook.py fails.
>>>
>>> diff --git a/Makefile b/Makefile
>>> index 338590e..61764ee 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -683,7 +683,7 @@ OTHER =         STKopcodes/top.xml \
>>>          manual.xml
>>>
>>>  SRCS =  $(COMMAND) $(CONTROL) $(XMLS) $(MIDI) $(OPCODES) $(ORCH) $(SCORE) \
>>> -       $(SIGS) $(UTILS) $(MISC) $(OTHER) examples-xml
>>> +       $(SIGS) $(UTILS) $(MISC) $(OTHER) examples-xml/stamp
>>>
>>>  # Build rules.
>>>  all: html
>>> @@ -694,9 +694,10 @@ $(XSL_HTML) $(XSL_HTMLHELP) $(XSL_PRINT)
>>> $(XSL_HTML_ONECHUNK): %: %.in
>>>          false )
>>>         sed -e 's|@xsl_base_path@|$(XSL_BASE_PATH)|' $@.in > $@
>>>
>>> -examples-xml: examples $(wildcard examples/*)
>>> +examples-xml/stamp: examples $(wildcard examples/*)
>>>         mkdir -p examples-xml
>>>         python csd2docbook.py
>>> +       touch examples-xml/stamp
>>>
>>>  html: $(XSL_HTML) manual.xml $(SRCS) Makefile
>>>         rm -rf html
>>>
>>> On 19 January 2017 at 14:35, Nate Whetsell  wrote:
>>>> I just replied to Dave off-list, but
>>>>
>>>> make clean && make XSL_BASE_PATH=/usr/share/xml/docbook/stylesheet/nwalsh pdf
>>>>
>>>> should work.
>>>
>>>
>>>
>>> --
>>>
>>> Saludos,
>>> Felipe Sateler
>
>
>
> --
>
> Saludos,