[Csnd-dev] formatting

Date	2024-09-29 15:08
From	Victor Lazzarini <000010b17ddd988e-dmarc-request@LISTSERV.HEANET.IE>
Subject	[Csnd-dev] formatting
	I was wondering what we should do about formatting code. We have this branch feature/format with additions to cmake for "make format" target using clang-format. Not sure if a PR from it is a good idea or not as the formatting has been applied to all files. It will probably mean a commit where all files are modified. Or we can do a different PR with just the cmake modifications. Prof. Victor Lazzarini Maynooth University Ireland

Date	2024-09-30 17:08
From	Hlöðver Sigurðsson
Subject	Re: [Csnd-dev] formatting
	yes I think it's one I opened? it's a little mentality shift needed to start formatting and linting c code. I made an email thread about this and there were lots of positive responses about doing this, if what I suggested there is good, I'm not sure, if clang-format is the most popular and well maintained formatter in the c ecosystem today. Open to any solution but overall happy if the code formatting and consistency was a topic and concern in code reviews. We can start with few rules and make it more specific with tme. On Sun, 29 Sept 2024 at 17:09, Victor Lazzarini <000010b17ddd988e-dmarc-request@listserv.heanet.ie> wrote: I was wondering what we should do about formatting code. We have this branch feature/format with additions to cmake for "make format" target using clang-format. Not sure if a PR from it is a good idea or not as the formatting has been applied to all files. It will probably mean a commit where all files are modified. Or we can do a different PR with just the cmake modifications. Prof. Victor Lazzarini Maynooth University Ireland

Date	2024-09-30 18:39
From	Steven Yi
Subject	Re: [Csnd-dev] formatting
	I'm all for it but would like to do it after getting the pass-by-ref branch merged. On Mon, Sep 30, 2024 at 12:09 PM Hlöðver Sigurðsson <hlolli@gmail.com> wrote: yes I think it's one I opened? it's a little mentality shift needed to start formatting and linting c code. I made an email thread about this and there were lots of positive responses about doing this, if what I suggested there is good, I'm not sure, if clang-format is the most popular and well maintained formatter in the c ecosystem today. Open to any solution but overall happy if the code formatting and consistency was a topic and concern in code reviews. We can start with few rules and make it more specific with tme. On Sun, 29 Sept 2024 at 17:09, Victor Lazzarini <000010b17ddd988e-dmarc-request@listserv.heanet.ie> wrote: I was wondering what we should do about formatting code. We have this branch feature/format with additions to cmake for "make format" target using clang-format. Not sure if a PR from it is a good idea or not as the formatting has been applied to all files. It will probably mean a commit where all files are modified. Or we can do a different PR with just the cmake modifications. Prof. Victor Lazzarini Maynooth University Ireland