Csound Csound-dev Csound-tekno Search About

[Csnd-dev] OENTRY thread field

Date2024-04-02 18:39
FromVictor Lazzarini
Subject[Csnd-dev] OENTRY thread field
Completing the work on a deinit pass and OENTRY field brought up another question.
Since we removed the k- and a- function difference, the relevance of the thread field in OENTRY has disappeared. 

It was only used in setting up the processing lists (instance() in insert.c), and is now so simple that we may just
as well check for the presence of the functions. In fact that’s what I have done in the PR.

The question is: should we just remove it? In the PR it’s basically non-op.
If we are not removing it, I can restore the (limited) use we had before.

========================
Prof. Victor Lazzarini
Maynooth University
Ireland


Date2024-04-02 20:10
FromHlöðver Sigurðsson
SubjectRe: [Csnd-dev] OENTRY thread field
I vote for removing it if it's harmless and makes the code more readable

On Tue, 2 Apr 2024 at 19:39, Victor Lazzarini <Victor.Lazzarini@mu.ie> wrote:
Completing the work on a deinit pass and OENTRY field brought up another question.
Since we removed the k- and a- function difference, the relevance of the thread field in OENTRY has disappeared.

It was only used in setting up the processing lists (instance() in insert.c), and is now so simple that we may just
as well check for the presence of the functions. In fact that’s what I have done in the PR.

The question is: should we just remove it? In the PR it’s basically non-op.
If we are not removing it, I can restore the (limited) use we had before.

========================
Prof. Victor Lazzarini
Maynooth University
Ireland