[Cs-dev] indefinite p3 problem - found the offending code

[Cs-dev] indefinite p3 problem - found the offending code

Date	2010-08-16 16:31
From	Victor Lazzarini
Subject	[Cs-dev] indefinite p3 problem - found the offending code
Attachments	None None
	Dear all, it seems this commit has caused the problem with indefinite p3 and extratime on instruments: Revision 1.111 - (view) (download) (as text) (annotate) - [select for diffs] Sun Jan 10 14:13:17 2010 UTC (7 months ago) by mantaraya36 Branch: MAIN CVS Tags: csound5_12 Changes since 1.110: +2 -2 lines Diff to previous 1.110 Allow turning off non-indefinite instruments from score events. By John ffitch. I traced it to line 654 of insert.c /* && ip->offtim < 0.0 */ which was commented off. Restoring it fixes the problem. Is there any particular reason for this? Can we restore it? Commit was done by Andres, but attribution is to John. Could you advise me? Victor

Date	2010-08-16 16:40
From	jpff@cs.bath.ac.uk
Subject	Re: [Cs-dev] indefinite p3 problem - found the offending code
	I almost remember this. We were chasing a bug and that seemed to fix. Andres and I had a short discussion about it at the time. I will look in the archives and/or my mail file to see if I can get more information. ==John ff > Dear all, > > it seems this commit has caused the problem with indefinite p3 and > extratime on instruments: > > Revision 1.111 - (view) (download) (as text) (annotate) - [select for > diffs] > Sun Jan 10 14:13:17 2010 UTC (7 months ago) by mantaraya36 > Branch: MAIN > CVS Tags: csound5_12 > Changes since 1.110: +2 -2 lines > Diff to previous 1.110 > Allow turning off non-indefinite instruments from score events. By > John ffitch. > I traced it to line 654 of insert.c > /* && ip->offtim < 0.0 */ > which was commented off. Restoring it fixes the problem. Is there any > particular reason for this? Can we restore it? > Commit was done by Andres, but attribution is to John. Could you > advise me? > Victor------------------------------------------------------------------------------ ------------------------------------------------------------------------------ This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev _______________________________________________ Csound-devel mailing list Csound-devel@lists.sourceforge.net

Date	2010-08-16 16:49
From	Andres Cabrera
Subject	Re: [Cs-dev] indefinite p3 problem - found the offending code
	Hi Victor, Yes, I committed it to enable turning off note instances for instruments with finite duration, after a small communication with John. He was uncertain whether it would have any other consequences, but apparently it does, and I think he couldn't commit at the time, so I did. It would be great if there was a way to allow turning off instruments which don't have an indefinite duration. Do you have any ideas for this? Cheers, Andrés On Mon, Aug 16, 2010 at 4:31 PM, Victor Lazzarini wrote: > Dear all, > it seems this commit has caused the problem with indefinite p3 and extratime > on instruments: > Revision 1.111 - (view) (download) (as text) (annotate) - [select for diffs] > Sun Jan 10 14:13:17 2010 UTC (7 months ago) by mantaraya36 > Branch: MAIN > CVS Tags: csound5_12 > Changes since 1.110: +2 -2 lines > Diff to previous 1.110 > > Allow turning off non-indefinite instruments from score events. By John > ffitch. > > I traced it to line 654 of insert.c > > /* && ip->offtim < 0.0 */ > > which was commented off. Restoring it fixes the problem. Is there any > particular reason for this? Can we restore it? > > Commit was done by Andres, but attribution is to John. Could you advise me? > > Victor > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by > > Make an app they can't live without > Enter the BlackBerry Developer Challenge > http://p.sf.net/sfu/RIM-dev2dev > _______________________________________________ > Csound-devel mailing list > Csound-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/csound-devel > > -- Andrés ------------------------------------------------------------------------------ This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev _______________________________________________ Csound-devel mailing list Csound-devel@lists.sourceforge.net https://lists.sourceforge.net/

Date	2010-08-16 17:25
From	Victor Lazzarini
Subject	Re: [Cs-dev] indefinite p3 problem - found the offending code
	I thought that was what turnoff2 did, was it not? On 16 Aug 2010, at 16:49, Andres Cabrera wrote: > Hi Victor, > > Yes, I committed it to enable turning off note instances for > instruments with finite duration, after a small communication with > John. He was uncertain whether it would have any other consequences, > but apparently it does, and I think he couldn't commit at the time, so > I did. > > It would be great if there was a way to allow turning off instruments > which don't have an indefinite duration. Do you have any ideas for > this? > > > Cheers, > Andrés > > On Mon, Aug 16, 2010 at 4:31 PM, Victor Lazzarini > wrote: >> Dear all, >> it seems this commit has caused the problem with indefinite p3 and >> extratime >> on instruments: >> Revision 1.111 - (view) (download) (as text) (annotate) - [select >> for diffs] >> Sun Jan 10 14:13:17 2010 UTC (7 months ago) by mantaraya36 >> Branch: MAIN >> CVS Tags: csound5_12 >> Changes since 1.110: +2 -2 lines >> Diff to previous 1.110 >> >> Allow turning off non-indefinite instruments from score events. By >> John >> ffitch. >> >> I traced it to line 654 of insert.c >> >> /* && ip->offtim < 0.0 */ >> >> which was commented off. Restoring it fixes the problem. Is there any >> particular reason for this? Can we restore it? >> >> Commit was done by Andres, but attribution is to John. Could you >> advise me? >> >> Victor >> >> ------------------------------------------------------------------------------ >> This SF.net email is sponsored by >> >> Make an app they can't live without >> Enter the BlackBerry Developer Challenge >> http://p.sf.net/sfu/RIM-dev2dev >> _______________________________________________ >> Csound-devel mailing list >> Csound-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/csound-devel >> >> > > > > -- > > > Andrés > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by > > Make an app they can't live without > Enter the BlackBerry Developer Challenge > http://p.sf.net/sfu/RIM-dev2dev > _______________________________________________ > Csound-devel mailing list > Csound-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/csound-devel ------------------------------------------------------------------------------ This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev _______________________________________________ Csound-devel mailing list Csound-devel@lists.sourceforge.net

Date	2010-08-16 17:28
From	Andres Cabrera
Subject	Re: [Cs-dev] indefinite p3 problem - found the offending code
	Hi Victor, Yes that's what turnoff2 does, but the idea was to enable that for score events, to allow turning off any instrument using a negative instrument number, not only indefinite instruments. Cheers, Andrés On Mon, Aug 16, 2010 at 5:25 PM, Victor Lazzarini wrote: > I thought that was what turnoff2 did, was it not? > > On 16 Aug 2010, at 16:49, Andres Cabrera wrote: > >> Hi Victor, >> >> Yes, I committed it to enable turning off note instances for >> instruments with finite duration, after a small communication with >> John. He was uncertain whether it would have any other consequences, >> but apparently it does, and I think he couldn't commit at the time, so >> I did. >> >> It would be great if there was a way to allow turning off instruments >> which don't have an indefinite duration. Do you have any ideas for >> this? >> >> >> Cheers, >> Andrés >> >> On Mon, Aug 16, 2010 at 4:31 PM, Victor Lazzarini >> wrote: >>> Dear all, >>> it seems this commit has caused the problem with indefinite p3 and >>> extratime >>> on instruments: >>> Revision 1.111 - (view) (download) (as text) (annotate) - [select >>> for diffs] >>> Sun Jan 10 14:13:17 2010 UTC (7 months ago) by mantaraya36 >>> Branch: MAIN >>> CVS Tags: csound5_12 >>> Changes since 1.110: +2 -2 lines >>> Diff to previous 1.110 >>> >>> Allow turning off non-indefinite instruments from score events. By >>> John >>> ffitch. >>> >>> I traced it to line 654 of insert.c >>> >>> /* && ip->offtim < 0.0 */ >>> >>> which was commented off. Restoring it fixes the problem. Is there any >>> particular reason for this? Can we restore it? >>> >>> Commit was done by Andres, but attribution is to John. Could you >>> advise me? >>> >>> Victor >>> >>> ------------------------------------------------------------------------------ >>> This SF.net email is sponsored by >>> >>> Make an app they can't live without >>> Enter the BlackBerry Developer Challenge >>> http://p.sf.net/sfu/RIM-dev2dev >>> _______________________________________________ >>> Csound-devel mailing list >>> Csound-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/csound-devel >>> >>> >> >> >> >> -- >> >> >> Andrés >> >> ------------------------------------------------------------------------------ >> This SF.net email is sponsored by >> >> Make an app they can't live without >> Enter the BlackBerry Developer Challenge >> http://p.sf.net/sfu/RIM-dev2dev >> _______________________________________________ >> Csound-devel mailing list >> Csound-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/csound-devel > > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by > > Make an app they can't live without > Enter the BlackBerry Developer Challenge > http://p.sf.net/sfu/RIM-dev2dev > _______________________________________________ > Csound-devel mailing list > Csound-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/csound-devel > -- Andrés ------------------------------------------------------------------------------ This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev _______________________________________________ Csound-devel mailing list Csound-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo

Date	2010-08-16 17:42
From	Victor Lazzarini
Subject	Re: [Cs-dev] indefinite p3 problem - found the offending code
	I'm all for it, but we need now to see why commenting out the check on negative offtim is having the effect that instruments with extratime cannot be turned off properly anymore. Once we know that, then we can comment that out again. But for now, I would suggest we restore the code because it breaks pre- existing CSDs. Victor On 16 Aug 2010, at 17:28, Andres Cabrera wrote: > Hi Victor, > > Yes that's what turnoff2 does, but the idea was to enable that for > score events, to allow turning off any instrument using a negative > instrument number, not only indefinite instruments. > > Cheers, > Andrés > > On Mon, Aug 16, 2010 at 5:25 PM, Victor Lazzarini > wrote: >> I thought that was what turnoff2 did, was it not? >> >> On 16 Aug 2010, at 16:49, Andres Cabrera wrote: >> >>> Hi Victor, >>> >>> Yes, I committed it to enable turning off note instances for >>> instruments with finite duration, after a small communication with >>> John. He was uncertain whether it would have any other consequences, >>> but apparently it does, and I think he couldn't commit at the >>> time, so >>> I did. >>> >>> It would be great if there was a way to allow turning off >>> instruments >>> which don't have an indefinite duration. Do you have any ideas for >>> this? >>> >>> >>> Cheers, >>> Andrés >>> >>> On Mon, Aug 16, 2010 at 4:31 PM, Victor Lazzarini >>> wrote: >>>> Dear all, >>>> it seems this commit has caused the problem with indefinite p3 and >>>> extratime >>>> on instruments: >>>> Revision 1.111 - (view) (download) (as text) (annotate) - [select >>>> for diffs] >>>> Sun Jan 10 14:13:17 2010 UTC (7 months ago) by mantaraya36 >>>> Branch: MAIN >>>> CVS Tags: csound5_12 >>>> Changes since 1.110: +2 -2 lines >>>> Diff to previous 1.110 >>>> >>>> Allow turning off non-indefinite instruments from score events. By >>>> John >>>> ffitch. >>>> >>>> I traced it to line 654 of insert.c >>>> >>>> /* && ip->offtim < 0.0 */ >>>> >>>> which was commented off. Restoring it fixes the problem. Is there >>>> any >>>> particular reason for this? Can we restore it? >>>> >>>> Commit was done by Andres, but attribution is to John. Could you >>>> advise me? >>>> >>>> Victor >>>> >>>> ------------------------------------------------------------------------------ >>>> This SF.net email is sponsored by >>>> >>>> Make an app they can't live without >>>> Enter the BlackBerry Developer Challenge >>>> http://p.sf.net/sfu/RIM-dev2dev >>>> _______________________________________________ >>>> Csound-devel mailing list >>>> Csound-devel@lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/csound-devel >>>> >>>> >>> >>> >>> >>> -- >>> >>> >>> Andrés >>> >>> ------------------------------------------------------------------------------ >>> This SF.net email is sponsored by >>> >>> Make an app they can't live without >>> Enter the BlackBerry Developer Challenge >>> http://p.sf.net/sfu/RIM-dev2dev >>> _______________________________________________ >>> Csound-devel mailing list >>> Csound-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/csound-devel >> >> >> ------------------------------------------------------------------------------ >> This SF.net email is sponsored by >> >> Make an app they can't live without >> Enter the BlackBerry Developer Challenge >> http://p.sf.net/sfu/RIM-dev2dev >> _______________________________________________ >> Csound-devel mailing list >> Csound-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/csound-devel >> > > > > -- > > > Andrés > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by > > Make an app they can't live without > Enter the BlackBerry Developer Challenge > http://p.sf.net/sfu/RIM-dev2dev > _______________________________________________ > Csound-devel mailing list > Csound-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/csound-devel ------------------------------------------------------------------------------ This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev _______________________________________________ Csound-devel mailing list Csound-devel@lists.sourceforge.net

Date	2010-08-16 18:09
From	Andres Cabrera
Subject	Re: [Cs-dev] indefinite p3 problem - found the offending code
	Yes, I agree if it broke something, roll it back. Cheers, Andrés On Mon, Aug 16, 2010 at 5:42 PM, Victor Lazzarini wrote: > I'm all for it, but we need now to see why commenting out the check on > negative offtim is having the effect that instruments with extratime > cannot be turned off properly anymore. Once we know that, then we can > comment that out again. > > But for now, I would suggest we restore the code because it breaks pre- > existing CSDs. > > Victor > On 16 Aug 2010, at 17:28, Andres Cabrera wrote: > >> Hi Victor, >> >> Yes that's what turnoff2 does, but the idea was to enable that for >> score events, to allow turning off any instrument using a negative >> instrument number, not only indefinite instruments. >> >> Cheers, >> Andrés >> >> On Mon, Aug 16, 2010 at 5:25 PM, Victor Lazzarini >> wrote: >>> I thought that was what turnoff2 did, was it not? >>> >>> On 16 Aug 2010, at 16:49, Andres Cabrera wrote: >>> >>>> Hi Victor, >>>> >>>> Yes, I committed it to enable turning off note instances for >>>> instruments with finite duration, after a small communication with >>>> John. He was uncertain whether it would have any other consequences, >>>> but apparently it does, and I think he couldn't commit at the >>>> time, so >>>> I did. >>>> >>>> It would be great if there was a way to allow turning off >>>> instruments >>>> which don't have an indefinite duration. Do you have any ideas for >>>> this? >>>> >>>> >>>> Cheers, >>>> Andrés >>>> >>>> On Mon, Aug 16, 2010 at 4:31 PM, Victor Lazzarini >>>> wrote: >>>>> Dear all, >>>>> it seems this commit has caused the problem with indefinite p3 and >>>>> extratime >>>>> on instruments: >>>>> Revision 1.111 - (view) (download) (as text) (annotate) - [select >>>>> for diffs] >>>>> Sun Jan 10 14:13:17 2010 UTC (7 months ago) by mantaraya36 >>>>> Branch: MAIN >>>>> CVS Tags: csound5_12 >>>>> Changes since 1.110: +2 -2 lines >>>>> Diff to previous 1.110 >>>>> >>>>> Allow turning off non-indefinite instruments from score events. By >>>>> John >>>>> ffitch. >>>>> >>>>> I traced it to line 654 of insert.c >>>>> >>>>> /* && ip->offtim < 0.0 */ >>>>> >>>>> which was commented off. Restoring it fixes the problem. Is there >>>>> any >>>>> particular reason for this? Can we restore it? >>>>> >>>>> Commit was done by Andres, but attribution is to John. Could you >>>>> advise me? >>>>> >>>>> Victor >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> This SF.net email is sponsored by >>>>> >>>>> Make an app they can't live without >>>>> Enter the BlackBerry Developer Challenge >>>>> http://p.sf.net/sfu/RIM-dev2dev >>>>> _______________________________________________ >>>>> Csound-devel mailing list >>>>> Csound-devel@lists.sourceforge.net >>>>> https://lists.sourceforge.net/lists/listinfo/csound-devel >>>>> >>>>> >>>> >>>> >>>> >>>> -- >>>> >>>> >>>> Andrés >>>> >>>> ------------------------------------------------------------------------------ >>>> This SF.net email is sponsored by >>>> >>>> Make an app they can't live without >>>> Enter the BlackBerry Developer Challenge >>>> http://p.sf.net/sfu/RIM-dev2dev >>>> _______________________________________________ >>>> Csound-devel mailing list >>>> Csound-devel@lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/csound-devel >>> >>> >>> ------------------------------------------------------------------------------ >>> This SF.net email is sponsored by >>> >>> Make an app they can't live without >>> Enter the BlackBerry Developer Challenge >>> http://p.sf.net/sfu/RIM-dev2dev >>> _______________________________________________ >>> Csound-devel mailing list >>> Csound-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/csound-devel >>> >> >> >> >> -- >> >> >> Andrés >> >> ------------------------------------------------------------------------------ >> This SF.net email is sponsored by >> >> Make an app they can't live without >> Enter the BlackBerry Developer Challenge >> http://p.sf.net/sfu/RIM-dev2dev >> _______________________________________________ >> Csound-devel mailing list >> Csound-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/csound-devel > > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by > > Make an app they can't live without > Enter the BlackBerry Developer Challenge > http://p.sf.net/sfu/RIM-dev2dev > _______________________________________________ > Csound-devel mailing list > Csound-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/csound-devel > -- Andrés ------------------------------------------------------------------------------ This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev _______________________________________________ Csound-devel mailing list Csound-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/c

Date	2010-08-16 18:27
From	Victor Lazzarini
Subject	Re: [Cs-dev] indefinite p3 problem - found the offending code
	Done. Dr.B. will be happy his CSD works again. Victor On 16 Aug 2010, at 18:09, Andres Cabrera wrote: > Yes, I agree if it broke something, roll it back. > > Cheers, > Andrés > > On Mon, Aug 16, 2010 at 5:42 PM, Victor Lazzarini > wrote: >> I'm all for it, but we need now to see why commenting out the check >> on >> negative offtim is having the effect that instruments with extratime >> cannot be turned off properly anymore. Once we know that, then we can >> comment that out again. >> >> But for now, I would suggest we restore the code because it breaks >> pre- >> existing CSDs. >> >> Victor >> On 16 Aug 2010, at 17:28, Andres Cabrera wrote: >> >>> Hi Victor, >>> >>> Yes that's what turnoff2 does, but the idea was to enable that for >>> score events, to allow turning off any instrument using a negative >>> instrument number, not only indefinite instruments. >>> >>> Cheers, >>> Andrés >>> >>> On Mon, Aug 16, 2010 at 5:25 PM, Victor Lazzarini >>> wrote: >>>> I thought that was what turnoff2 did, was it not? >>>> >>>> On 16 Aug 2010, at 16:49, Andres Cabrera wrote: >>>> >>>>> Hi Victor, >>>>> >>>>> Yes, I committed it to enable turning off note instances for >>>>> instruments with finite duration, after a small communication with >>>>> John. He was uncertain whether it would have any other >>>>> consequences, >>>>> but apparently it does, and I think he couldn't commit at the >>>>> time, so >>>>> I did. >>>>> >>>>> It would be great if there was a way to allow turning off >>>>> instruments >>>>> which don't have an indefinite duration. Do you have any ideas for >>>>> this? >>>>> >>>>> >>>>> Cheers, >>>>> Andrés >>>>> >>>>> On Mon, Aug 16, 2010 at 4:31 PM, Victor Lazzarini >>>>> wrote: >>>>>> Dear all, >>>>>> it seems this commit has caused the problem with indefinite p3 >>>>>> and >>>>>> extratime >>>>>> on instruments: >>>>>> Revision 1.111 - (view) (download) (as text) (annotate) - [select >>>>>> for diffs] >>>>>> Sun Jan 10 14:13:17 2010 UTC (7 months ago) by mantaraya36 >>>>>> Branch: MAIN >>>>>> CVS Tags: csound5_12 >>>>>> Changes since 1.110: +2 -2 lines >>>>>> Diff to previous 1.110 >>>>>> >>>>>> Allow turning off non-indefinite instruments from score events. >>>>>> By >>>>>> John >>>>>> ffitch. >>>>>> >>>>>> I traced it to line 654 of insert.c >>>>>> >>>>>> /* && ip->offtim < 0.0 */ >>>>>> >>>>>> which was commented off. Restoring it fixes the problem. Is there >>>>>> any >>>>>> particular reason for this? Can we restore it? >>>>>> >>>>>> Commit was done by Andres, but attribution is to John. Could you >>>>>> advise me? >>>>>> >>>>>> Victor >>>>>> >>>>>> ------------------------------------------------------------------------------ >>>>>> This SF.net email is sponsored by >>>>>> >>>>>> Make an app they can't live without >>>>>> Enter the BlackBerry Developer Challenge >>>>>> http://p.sf.net/sfu/RIM-dev2dev >>>>>> _______________________________________________ >>>>>> Csound-devel mailing list >>>>>> Csound-devel@lists.sourceforge.net >>>>>> https://lists.sourceforge.net/lists/listinfo/csound-devel >>>>>> >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> >>>>> >>>>> Andrés >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> This SF.net email is sponsored by >>>>> >>>>> Make an app they can't live without >>>>> Enter the BlackBerry Developer Challenge >>>>> http://p.sf.net/sfu/RIM-dev2dev >>>>> _______________________________________________ >>>>> Csound-devel mailing list >>>>> Csound-devel@lists.sourceforge.net >>>>> https://lists.sourceforge.net/lists/listinfo/csound-devel >>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> This SF.net email is sponsored by >>>> >>>> Make an app they can't live without >>>> Enter the BlackBerry Developer Challenge >>>> http://p.sf.net/sfu/RIM-dev2dev >>>> _______________________________________________ >>>> Csound-devel mailing list >>>> Csound-devel@lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/csound-devel >>>> >>> >>> >>> >>> -- >>> >>> >>> Andrés >>> >>> ------------------------------------------------------------------------------ >>> This SF.net email is sponsored by >>> >>> Make an app they can't live without >>> Enter the BlackBerry Developer Challenge >>> http://p.sf.net/sfu/RIM-dev2dev >>> _______________________________________________ >>> Csound-devel mailing list >>> Csound-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/csound-devel >> >> >> ------------------------------------------------------------------------------ >> This SF.net email is sponsored by >> >> Make an app they can't live without >> Enter the BlackBerry Developer Challenge >> http://p.sf.net/sfu/RIM-dev2dev >> _______________________________________________ >> Csound-devel mailing list >> Csound-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/csound-devel >> > > > > -- > > > Andrés > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by > > Make an app they can't live without > Enter the BlackBerry Developer Challenge > http://p.sf.net/sfu/RIM-dev2dev > _______________________________________________ > Csound-devel mailing list > Csound-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/csound-devel ------------------------------------------------------------------------------ This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev _______________________________________________ Csound-devel mailing list Csound-devel@lists.sourceforge.net

Date	2010-08-18 13:11
From	Dr. Richard Boulanger
Subject	Re: [Cs-dev] indefinite p3 problem - found the offending code
	This is fantastic news! Thanks so much to all of you for working on this. Thanks also to Victor for sharing a really wonderful fluid "alternative" that is a wonderful model as well. Wishing you all the best. -dB On Aug 16, 2010, at 1:27 PM, Victor Lazzarini wrote: > Done. Dr.B. will be happy his CSD works again. > > Victor > On 16 Aug 2010, at 18:09, Andres Cabrera wrote: > >> Yes, I agree if it broke something, roll it back. >> >> Cheers, >> Andrés >> >> On Mon, Aug 16, 2010 at 5:42 PM, Victor Lazzarini >> wrote: >>> I'm all for it, but we need now to see why commenting out the check >>> on >>> negative offtim is having the effect that instruments with extratime >>> cannot be turned off properly anymore. Once we know that, then we can >>> comment that out again. >>> >>> But for now, I would suggest we restore the code because it breaks >>> pre- >>> existing CSDs. >>> >>> Victor >>> On 16 Aug 2010, at 17:28, Andres Cabrera wrote: >>> >>>> Hi Victor, >>>> >>>> Yes that's what turnoff2 does, but the idea was to enable that for >>>> score events, to allow turning off any instrument using a negative >>>> instrument number, not only indefinite instruments. >>>> >>>> Cheers, >>>> Andrés >>>> >>>> On Mon, Aug 16, 2010 at 5:25 PM, Victor Lazzarini >>>> wrote: >>>>> I thought that was what turnoff2 did, was it not? >>>>> >>>>> On 16 Aug 2010, at 16:49, Andres Cabrera wrote: >>>>> >>>>>> Hi Victor, >>>>>> >>>>>> Yes, I committed it to enable turning off note instances for >>>>>> instruments with finite duration, after a small communication with >>>>>> John. He was uncertain whether it would have any other >>>>>> consequences, >>>>>> but apparently it does, and I think he couldn't commit at the >>>>>> time, so >>>>>> I did. >>>>>> >>>>>> It would be great if there was a way to allow turning off >>>>>> instruments >>>>>> which don't have an indefinite duration. Do you have any ideas for >>>>>> this? >>>>>> >>>>>> >>>>>> Cheers, >>>>>> Andrés >>>>>> >>>>>> On Mon, Aug 16, 2010 at 4:31 PM, Victor Lazzarini >>>>>> wrote: >>>>>>> Dear all, >>>>>>> it seems this commit has caused the problem with indefinite p3 >>>>>>> and >>>>>>> extratime >>>>>>> on instruments: >>>>>>> Revision 1.111 - (view) (download) (as text) (annotate) - [select >>>>>>> for diffs] >>>>>>> Sun Jan 10 14:13:17 2010 UTC (7 months ago) by mantaraya36 >>>>>>> Branch: MAIN >>>>>>> CVS Tags: csound5_12 >>>>>>> Changes since 1.110: +2 -2 lines >>>>>>> Diff to previous 1.110 >>>>>>> >>>>>>> Allow turning off non-indefinite instruments from score events. >>>>>>> By >>>>>>> John >>>>>>> ffitch. >>>>>>> >>>>>>> I traced it to line 654 of insert.c >>>>>>> >>>>>>> /* && ip->offtim < 0.0 */ >>>>>>> >>>>>>> which was commented off. Restoring it fixes the problem. Is there >>>>>>> any >>>>>>> particular reason for this? Can we restore it? >>>>>>> >>>>>>> Commit was done by Andres, but attribution is to John. Could you >>>>>>> advise me? >>>>>>> >>>>>>> Victor >>>>>>> >>>>>>> ------------------------------------------------------------------------------ >>>>>>> This SF.net email is sponsored by >>>>>>> >>>>>>> Make an app they can't live without >>>>>>> Enter the BlackBerry Developer Challenge >>>>>>> http://p.sf.net/sfu/RIM-dev2dev >>>>>>> _______________________________________________ >>>>>>> Csound-devel mailing list >>>>>>> Csound-devel@lists.sourceforge.net >>>>>>> https://lists.sourceforge.net/lists/listinfo/csound-devel >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> >>>>>> >>>>>> Andrés >>>>>> >>>>>> ------------------------------------------------------------------------------ >>>>>> This SF.net email is sponsored by >>>>>> >>>>>> Make an app they can't live without >>>>>> Enter the BlackBerry Developer Challenge >>>>>> http://p.sf.net/sfu/RIM-dev2dev >>>>>> _______________________________________________ >>>>>> Csound-devel mailing list >>>>>> Csound-devel@lists.sourceforge.net >>>>>> https://lists.sourceforge.net/lists/listinfo/csound-devel >>>>> >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> This SF.net email is sponsored by >>>>> >>>>> Make an app they can't live without >>>>> Enter the BlackBerry Developer Challenge >>>>> http://p.sf.net/sfu/RIM-dev2dev >>>>> _______________________________________________ >>>>> Csound-devel mailing list >>>>> Csound-devel@lists.sourceforge.net >>>>> https://lists.sourceforge.net/lists/listinfo/csound-devel >>>>> >>>> >>>> >>>> >>>> -- >>>> >>>> >>>> Andrés >>>> >>>> ------------------------------------------------------------------------------ >>>> This SF.net email is sponsored by >>>> >>>> Make an app they can't live without >>>> Enter the BlackBerry Developer Challenge >>>> http://p.sf.net/sfu/RIM-dev2dev >>>> _______________________________________________ >>>> Csound-devel mailing list >>>> Csound-devel@lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/csound-devel >>> >>> >>> ------------------------------------------------------------------------------ >>> This SF.net email is sponsored by >>> >>> Make an app they can't live without >>> Enter the BlackBerry Developer Challenge >>> http://p.sf.net/sfu/RIM-dev2dev >>> _______________________________________________ >>> Csound-devel mailing list >>> Csound-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/csound-devel >>> >> >> >> >> -- >> >> >> Andrés >> >> ------------------------------------------------------------------------------ >> This SF.net email is sponsored by >> >> Make an app they can't live without >> Enter the BlackBerry Developer Challenge >> http://p.sf.net/sfu/RIM-dev2dev >> _______________________________________________ >> Csound-devel mailing list >> Csound-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/csound-devel > > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by > > Make an app they can't live without > Enter the BlackBerry Developer Challenge > http://p.sf.net/sfu/RIM-dev2dev > _______________________________________________ > Csound-devel mailing list > Csound-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/csound-devel ------------------------------------------------------------------------------ This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev _______________________________________________ Csound-devel mailing list Csound-devel@lists.sourceforge.net

Date	2010-08-18 14:25
From	Victor Lazzarini
Subject	Re: [Cs-dev] indefinite p3 problem - found the offending code
	That fluidsynth alternative is Istvan's GM fluidsynth example, which is very good one. Victor On 18 Aug 2010, at 13:11, Dr. Richard Boulanger wrote: > This is fantastic news! Thanks so much to all of you for working on > this. > Thanks also to Victor for sharing a really wonderful fluid > "alternative" that is a wonderful model as well. > > Wishing you all the best. > > -dB > > On Aug 16, 2010, at 1:27 PM, Victor Lazzarini wrote: > >> Done. Dr.B. will be happy his CSD works again. >> >> Victor >> On 16 Aug 2010, at 18:09, Andres Cabrera wrote: >> >>> Yes, I agree if it broke something, roll it back. >>> >>> Cheers, >>> Andrés >>> >>> On Mon, Aug 16, 2010 at 5:42 PM, Victor Lazzarini >>> wrote: >>>> I'm all for it, but we need now to see why commenting out the check >>>> on >>>> negative offtim is having the effect that instruments with >>>> extratime >>>> cannot be turned off properly anymore. Once we know that, then we >>>> can >>>> comment that out again. >>>> >>>> But for now, I would suggest we restore the code because it breaks >>>> pre- >>>> existing CSDs. >>>> >>>> Victor >>>> On 16 Aug 2010, at 17:28, Andres Cabrera wrote: >>>> >>>>> Hi Victor, >>>>> >>>>> Yes that's what turnoff2 does, but the idea was to enable that for >>>>> score events, to allow turning off any instrument using a negative >>>>> instrument number, not only indefinite instruments. >>>>> >>>>> Cheers, >>>>> Andrés >>>>> >>>>> On Mon, Aug 16, 2010 at 5:25 PM, Victor Lazzarini >>>>> wrote: >>>>>> I thought that was what turnoff2 did, was it not? >>>>>> >>>>>> On 16 Aug 2010, at 16:49, Andres Cabrera wrote: >>>>>> >>>>>>> Hi Victor, >>>>>>> >>>>>>> Yes, I committed it to enable turning off note instances for >>>>>>> instruments with finite duration, after a small communication >>>>>>> with >>>>>>> John. He was uncertain whether it would have any other >>>>>>> consequences, >>>>>>> but apparently it does, and I think he couldn't commit at the >>>>>>> time, so >>>>>>> I did. >>>>>>> >>>>>>> It would be great if there was a way to allow turning off >>>>>>> instruments >>>>>>> which don't have an indefinite duration. Do you have any ideas >>>>>>> for >>>>>>> this? >>>>>>> >>>>>>> >>>>>>> Cheers, >>>>>>> Andrés >>>>>>> >>>>>>> On Mon, Aug 16, 2010 at 4:31 PM, Victor Lazzarini >>>>>>> wrote: >>>>>>>> Dear all, >>>>>>>> it seems this commit has caused the problem with indefinite p3 >>>>>>>> and >>>>>>>> extratime >>>>>>>> on instruments: >>>>>>>> Revision 1.111 - (view) (download) (as text) (annotate) - >>>>>>>> [select >>>>>>>> for diffs] >>>>>>>> Sun Jan 10 14:13:17 2010 UTC (7 months ago) by mantaraya36 >>>>>>>> Branch: MAIN >>>>>>>> CVS Tags: csound5_12 >>>>>>>> Changes since 1.110: +2 -2 lines >>>>>>>> Diff to previous 1.110 >>>>>>>> >>>>>>>> Allow turning off non-indefinite instruments from score events. >>>>>>>> By >>>>>>>> John >>>>>>>> ffitch. >>>>>>>> >>>>>>>> I traced it to line 654 of insert.c >>>>>>>> >>>>>>>> /* && ip->offtim < 0.0 */ >>>>>>>> >>>>>>>> which was commented off. Restoring it fixes the problem. Is >>>>>>>> there >>>>>>>> any >>>>>>>> particular reason for this? Can we restore it? >>>>>>>> >>>>>>>> Commit was done by Andres, but attribution is to John. Could >>>>>>>> you >>>>>>>> advise me? >>>>>>>> >>>>>>>> Victor >>>>>>>> >>>>>>>> ------------------------------------------------------------------------------ >>>>>>>> This SF.net email is sponsored by >>>>>>>> >>>>>>>> Make an app they can't live without >>>>>>>> Enter the BlackBerry Developer Challenge >>>>>>>> http://p.sf.net/sfu/RIM-dev2dev >>>>>>>> _______________________________________________ >>>>>>>> Csound-devel mailing list >>>>>>>> Csound-devel@lists.sourceforge.net >>>>>>>> https://lists.sourceforge.net/lists/listinfo/csound-devel >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> >>>>>>> >>>>>>> Andrés >>>>>>> >>>>>>> ------------------------------------------------------------------------------ >>>>>>> This SF.net email is sponsored by >>>>>>> >>>>>>> Make an app they can't live without >>>>>>> Enter the BlackBerry Developer Challenge >>>>>>> http://p.sf.net/sfu/RIM-dev2dev >>>>>>> _______________________________________________ >>>>>>> Csound-devel mailing list >>>>>>> Csound-devel@lists.sourceforge.net >>>>>>> https://lists.sourceforge.net/lists/listinfo/csound-devel >>>>>> >>>>>> >>>>>> ------------------------------------------------------------------------------ >>>>>> This SF.net email is sponsored by >>>>>> >>>>>> Make an app they can't live without >>>>>> Enter the BlackBerry Developer Challenge >>>>>> http://p.sf.net/sfu/RIM-dev2dev >>>>>> _______________________________________________ >>>>>> Csound-devel mailing list >>>>>> Csound-devel@lists.sourceforge.net >>>>>> https://lists.sourceforge.net/lists/listinfo/csound-devel >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> >>>>> >>>>> Andrés >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> This SF.net email is sponsored by >>>>> >>>>> Make an app they can't live without >>>>> Enter the BlackBerry Developer Challenge >>>>> http://p.sf.net/sfu/RIM-dev2dev >>>>> _______________________________________________ >>>>> Csound-devel mailing list >>>>> Csound-devel@lists.sourceforge.net >>>>> https://lists.sourceforge.net/lists/listinfo/csound-devel >>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> This SF.net email is sponsored by >>>> >>>> Make an app they can't live without >>>> Enter the BlackBerry Developer Challenge >>>> http://p.sf.net/sfu/RIM-dev2dev >>>> _______________________________________________ >>>> Csound-devel mailing list >>>> Csound-devel@lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/csound-devel >>>> >>> >>> >>> >>> -- >>> >>> >>> Andrés >>> >>> ------------------------------------------------------------------------------ >>> This SF.net email is sponsored by >>> >>> Make an app they can't live without >>> Enter the BlackBerry Developer Challenge >>> http://p.sf.net/sfu/RIM-dev2dev >>> _______________________________________________ >>> Csound-devel mailing list >>> Csound-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/csound-devel >> >> >> ------------------------------------------------------------------------------ >> This SF.net email is sponsored by >> >> Make an app they can't live without >> Enter the BlackBerry Developer Challenge >> http://p.sf.net/sfu/RIM-dev2dev >> _______________________________________________ >> Csound-devel mailing list >> Csound-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/csound-devel > > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by > > Make an app they can't live without > Enter the BlackBerry Developer Challenge > http://p.sf.net/sfu/RIM-dev2dev > _______________________________________________ > Csound-devel mailing list > Csound-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/csound-devel ------------------------------------------------------------------------------ This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev _______________________________________________ Csound-devel mailing list Csound-devel@lists.sourceforge.net