I did a CVS update this afternoon for Csound 5 and recompiled.  I did have
to incorporate a few of my previous changes but some other issues had been
fixed already.

Csound 5 is now working somewhat better on MacOS 9.  I was able to get
trapped.csd to render but I had to separate it into .orc and .sco myself.
It seems that the unified csd function is writing out Unix line endings but
the orchestra parser is confused by them (?? didn't used to matter, did
it?).  The listing file option (-O) seems to be broken as well.

I also noticed that there are two copies each of sdif.c, sdif.h, sdif-mem.c,
and sdif-mem.h (in H/, OOps/, and SDIF/).  Which copy of these files should
be kept? (They are identical).  And when they are included, it is done as

#include 
#include 

Shouldn't they be non-system includes?:

#include "H/sdif-mem.h"   // or just "sdif-mem.h"
#include "H/sdif.h"       // and "sdif.h"

I also got the following error

Error   : type mismatch
'struct SNDFILE_tag *' and 'int'
diskin.c line 352   if (sinfd > 0) {

which I solved by changing > 0 to != NULL

And in csound.c, I changed the signature for csoundExternalMidiRead from

    int csoundExternalMidiRead(void *csound, char *mbuf, int size)
    to
    int csoundExternalMidiRead(void *csound, unsigned char *mbuf, int size)

to match the other calls.


There were a few other Mac-only changes that I made.  Would it be alright to
commit all of these changes to Csound5 CVS ??

Thanks.

Anthony Kozar
anthony.kozar@utoledo.edu
http://akozar.spymac.net/

Those fixes look OK to me.  I really dislike the incorrect use of <>
in #include.   Glad you caught one I missed.

re diskin, that is my fault in the change to libsndfile; they keep
turning up.

re csoundExternalMidiRead I am less sure.  This is Michael's area.

But commit them I say.

==John ffitch

I committed the changes.  I would not expect any problems except possibly
the <> vs. "" issue that Michael mentioned.

if this is an issue, we can change to something like:

#if defined(mac_classic) && defined(__MWERKS__)
# include "sdif.h"
#else
# include 
#endif

Let me know if you encounter problems!

Anthony Kozar
anthony.kozar@utoledo.edu
http://akozar.spymac.net/


On 6/25/04 12:56 AM, jpff@codemist.co.uk etched in
stone:

> Those fixes look OK to me.  I really dislike the incorrect use of <>
> in #include.   Glad you caught one I missed.

> But commit them I say.