| All seems OK, so I'll release it as 5.12.1 (for OSX). Maybe the other
release packages can use the fix too.
Victor
On 15 Feb 2010, at 20:19, Steven Yi wrote:
> I did not check if it broke anything else; if projects are running
> correctly then we can fix for new parser later. Otherwise, I'd
> recommend we get it out for all platforms, maybe even tag/build as
> 5.12.1.
>
> On Mon, Feb 15, 2010 at 3:09 PM, Victor Lazzarini
> wrote:
>> I am going with this fix, locally, so I can release 5.12. Then we can
>> go and fix it properly for 5.13
>>
>> Victor
>> On 15 Feb 2010, at 16:29, Steven Yi wrote:
>>
>>> Hi All,
>>>
>>> I think I've found what's causing the bug: it seems some code in
>>> otran.c was not updated for the nchnls_i contstant that was added:
>>>
>>> gblspace[0] = p->esr; /* & enter */
>>> gblspace[1] = p->ekr; /* rsvd word */
>>> gblspace[2] = (MYFLT) p->ksmps; /* curr vals */
>>> gblspace[3] = (MYFLT) p->nchnls;
>>> gblspace[4] = p->e0dbfs;
>>>
>>> I tried changing it to:
>>>
>>> gblspace[0] = p->esr; /* & enter */
>>> gblspace[1] = p->ekr; /* rsvd word */
>>> gblspace[2] = (MYFLT) p->ksmps; /* curr vals */
>>> gblspace[3] = (MYFLT) p->nchnls;
>>> gblspace[4] = (MYFLT) p->inchnls;
>>> gblspace[5] = p->e0dbfs;
>>>
>>> and 0dbfs printed correctly as 1.0 (i set it to 1.0 in my test file)
>>> with the old parser, but showed up as 2.0 (the value of inchnls)
>>> with
>>> the new parser.
>>>
>>> I'm don't know what occurred with the inchnls change, so will
>>> defer to
>>> John on this.
>>>
>>> Thanks!
>>> steven
>>>
>>>
>>> On Mon, Feb 15, 2010 at 11:04 AM, Steven Yi
>>> wrote:
>>>> Hi Victor,
>>>>
>>>> I tested with this and reproduced your results. I tried backing
>>>> out a
>>>> change I had done for 0dbfs and new parser but it just made it
>>>> broke
>>>> on both parsers. Strangely, if I take the change out, neither had
>>>> the
>>>> correct value but for different reasons. With the new parser, it
>>>> would show the default 32768, but with the old parser it still
>>>> showed
>>>> as 0.
>>>>
>>>> I do not know the cause of this issue.
>>>>
>>>> Thanks,
>>>> steven
>>>>
>>>>
>>>> On Mon, Feb 15, 2010 at 10:02 AM, Victor Lazzarini
>>>> wrote:
>>>>> In addition to that, the most serious is 0dbfs problem, which
>>>>> can be
>>>>> traced with the simple example
>>>>>
>>>>> instr 1
>>>>>
>>>>> print 0dbfs
>>>>>
>>>>> endin
>>>>>
>>>>>
>>>>> will print 0 with the old parser and 32768 with the new parser
>>>>> (correct).
>>>>>
>>>>> I removed my 5.12 osx package because this bug breaks lots of
>>>>> examples
>>>>> in Qutecsound and we can't have that.
>>>>>
>>>>> Victor
>>>>>
>>>>>
>>>>> On 15 Feb 2010, at 14:39, jpff@cs.bath.ac.uk wrote:
>>>>>
>>>>>> I am a bit behind in mail, but the only parser error of which I
>>>>>> am
>>>>>> aware
>>>>>> in 5.12 is continuation lines in the orchestra. There were
>>>>>> errors
>>>>>> introduced into the CVS after the tag relating to assignment to p
>>>>>> variables; both now fixed.
>>>>>>
>>>>>> We should plan a 5.13 release date anyway. I was hoping for the
>>>>>> new
>>>>>> parser by then -- we were only missing (a?b:c) type expressions I
>>>>>> think.
>>>>>>
>>>>>> ==John
>>>>>>
>>>>>>>
>>>>>>> We will probably need to halt this release, because there seem
>>>>>>> to be
>>>>>>> some serious bugs in the orchestra parser. For now I will remove
>>>>>>> the
>>>>>>> 5.12 installer for OSX, before there is further damage. But I am
>>>>>>> not
>>>>>>> sure how to progress, release a 5.12 bugfix, or a 5.13.
>>>>>>>
>>>>>>> We will need to sort out our release strategy as well, perhaps
>>>>>>> making
>>>>>>> sure everything is correct on all platforms and then releasing
>>>>>>> it at
>>>>>>> the same time.
>>>>>>>
>>>>>>> Victor
>>>>>>>
>>>>>>> ------------------------------------------------------------------------------
>>>>>>> SOLARIS 10 is the OS for Data Centers - provides features such
>>>>>>> as
>>>>>>> DTrace,
>>>>>>> Predictive Self Healing and Award Winning ZFS. Get Solaris 10
>>>>>>> NOW
>>>>>>> http://p.sf.net/sfu/solaris-dev2dev
>>>>>>> _______________________________________________
>>>>>>> Csound-devel mailing list
>>>>>>> Csound-devel@lists.sourceforge.net
>>>>>>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> ------------------------------------------------------------------------------
>>>>>> SOLARIS 10 is the OS for Data Centers - provides features such as
>>>>>> DTrace,
>>>>>> Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
>>>>>> http://p.sf.net/sfu/solaris-dev2dev
>>>>>> _______________________________________________
>>>>>> Csound-devel mailing list
>>>>>> Csound-devel@lists.sourceforge.net
>>>>>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>>>>>
>>>>>
>>>>> ------------------------------------------------------------------------------
>>>>> SOLARIS 10 is the OS for Data Centers - provides features such as
>>>>> DTrace,
>>>>> Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
>>>>> http://p.sf.net/sfu/solaris-dev2dev
>>>>> _______________________________________________
>>>>> Csound-devel mailing list
>>>>> Csound-devel@lists.sourceforge.net
>>>>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>>>>>
>>>>
>>>
>>> ------------------------------------------------------------------------------
>>> SOLARIS 10 is the OS for Data Centers - provides features such as
>>> DTrace,
>>> Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
>>> http://p.sf.net/sfu/solaris-dev2dev
>>> _______________________________________________
>>> Csound-devel mailing list
>>> Csound-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>>
>>
>> ------------------------------------------------------------------------------
>> SOLARIS 10 is the OS for Data Centers - provides features such as
>> DTrace,
>> Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
>> http://p.sf.net/sfu/solaris-dev2dev
>> _______________________________________________
>> Csound-devel mailing list
>> Csound-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>>
>
> ------------------------------------------------------------------------------
> SOLARIS 10 is the OS for Data Centers - provides features such as
> DTrace,
> Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
> http://p.sf.net/sfu/solaris-dev2dev
> _______________________________________________
> Csound-devel mailing list
> Csound-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/csound-devel
------------------------------------------------------------------------------
SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
http://p.sf.net/sfu/solaris-dev2dev
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net |