Csound Csound-dev Csound-tekno Search About

[Cs-dev] FLTK bug with --asciidisplay

Date2012-05-28 11:43
FromTito Latini
Subject[Cs-dev] FLTK bug with --asciidisplay
AttachmentsNone  

Date2012-05-28 12:07
FromVictor Lazzarini
SubjectRe: [Cs-dev] FLTK bug with --asciidisplay
Why does the size of that struct comes into play here?
On 28 May 2012, at 11:43, Tito Latini wrote:

> sizeof(WIDGET_GLOBALS) is ~ 25 kByte. If it is not a problem,
> the check before `widget_init' in winFLTK.c is removable
> and the bug is fixed.
> 
> tito
> 
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and 
> threat landscape has changed and how IT managers can respond. Discussions 
> will include endpoint security, mobile security and the latest in malware 
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Csound-devel mailing list
> Csound-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/csound-devel

Dr Victor Lazzarini
Senior Lecturer
Dept. of Music
NUI Maynooth Ireland
tel.: +353 1 708 3545
Victor dot Lazzarini AT nuim dot ie




------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net

Date2012-05-28 13:20
FromTito Latini
SubjectRe: [Cs-dev] FLTK bug with --asciidisplay
AttachmentsNone  

Date2012-05-28 13:54
FromTito Latini
SubjectRe: [Cs-dev] FLTK bug with --asciidisplay
AttachmentsNone  

Date2012-05-28 14:03
FromVictor Lazzarini
SubjectRe: [Cs-dev] FLTK bug with --asciidisplay
None from me.
On 28 May 2012, at 13:54, Tito Latini wrote:

> I have a fix for bug and memory leak with a little patch.
> I apply it if there are not objections
> 
> diff -ur csound5~/InOut/widgets.cpp csound5/InOut/widgets.cpp
> --- csound5~/InOut/widgets.cpp	2012-05-28 14:47:00.000000000 +0200
> +++ csound5/InOut/widgets.cpp	2012-05-28 14:47:47.000000000 +0200
> @@ -1997,6 +1997,9 @@
>         ST(FLtext_align)      = 0;
>         ST(FL_ix)             = 10;
>         ST(FL_iy)             = 10;
> +
> +        delete (WIDGET_GLOBALS*)csound->widgetGlobals;
> +        csound->widgetGlobals = NULL;
>       }
>       return 0;
>   }
> diff -ur csound5~/InOut/winFLTK.c csound5/InOut/winFLTK.c
> --- csound5~/InOut/winFLTK.c	2012-05-28 14:47:00.000000000 +0200
> +++ csound5/InOut/winFLTK.c	2012-05-28 14:47:18.000000000 +0200
> @@ -141,8 +141,7 @@
>       }
>     }
> 
> -    if (!(csound->oparms->graphsoff || csound->oparms->postscript))
> -      widget_init(csound);
> +    widget_init(csound);
>     return 0;
> }
> 
> tito
> 
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and 
> threat landscape has changed and how IT managers can respond. Discussions 
> will include endpoint security, mobile security and the latest in malware 
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Csound-devel mailing list
> Csound-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/csound-devel

Dr Victor Lazzarini
Senior Lecturer
Dept. of Music
NUI Maynooth Ireland
tel.: +353 1 708 3545
Victor dot Lazzarini AT nuim dot ie




------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net

Date2012-05-28 14:14
Fromjpff@cs.bath.ac.uk
SubjectRe: [Cs-dev] FLTK bug with --asciidisplay
do it

> I have a fix for bug and memory leak with a little patch.
> I apply it if there are not objections
>
> diff -ur csound5~/InOut/widgets.cpp csound5/InOut/widgets.cpp
> --- csound5~/InOut/widgets.cpp	2012-05-28 14:47:00.000000000 +0200
> +++ csound5/InOut/widgets.cpp	2012-05-28 14:47:47.000000000 +0200
> @@ -1997,6 +1997,9 @@
>          ST(FLtext_align)      = 0;
>          ST(FL_ix)             = 10;
>          ST(FL_iy)             = 10;
> +
> +        delete (WIDGET_GLOBALS*)csound->widgetGlobals;
> +        csound->widgetGlobals = NULL;
>        }
>        return 0;
>    }
> diff -ur csound5~/InOut/winFLTK.c csound5/InOut/winFLTK.c
> --- csound5~/InOut/winFLTK.c	2012-05-28 14:47:00.000000000 +0200
> +++ csound5/InOut/winFLTK.c	2012-05-28 14:47:18.000000000 +0200
> @@ -141,8 +141,7 @@
>        }
>      }
>
> -    if (!(csound->oparms->graphsoff || csound->oparms->postscript))
> -      widget_init(csound);
> +    widget_init(csound);
>      return 0;
>  }
>
> tito
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Csound-devel mailing list
> Csound-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/csound-devel
>
>
>



------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net

Date2012-05-28 14:23
FromTito Latini
SubjectRe: [Cs-dev] FLTK bug with --asciidisplay
AttachmentsNone