[Cs-dev] MinGW build broken... again...
| Date | 2013-05-02 23:36 |
| From | Michael Gogins |
| Subject | [Cs-dev] MinGW build broken... again... |
| Attachments | None None |
These errors could be avoided by putting csdl.h back into csound.h.
I do not think the separation of concerns is worth repeatedly having to wait for people to fix these things. Can you provide 3 examples of how something might not work because csdl.h was not separated from csound.h and them from csoundCore.h? I can provide way more than 3 examples of things not working because these files have been separated.
Alternatively, people who introduce these changes could take the time to test with a Windows build. Regards, Mike Michael Gogins Irreducible Productions http://www.michael-gogins.com Michael dot Gogins at gmail dot com |
| Date | 2013-05-03 00:10 |
| From | Andres Cabrera |
| Subject | Re: [Cs-dev] MinGW build broken... again... |
| Attachments | None None |
I think the separation makes sense from an API users perspective as it separated different uses. No one should use csoundCore, hosts should use csound.h and plugins (opcodes and modules) should used csdl.h. The errors mentioned today don't stem from this separation, but from a missing definition within an ifdef in my case, and a change in the signature of PerfError in the other case (this was Victor's work to allow better information display for perf errors, I think).Cheers, Andrés On Thu, May 2, 2013 at 3:36 PM, Michael Gogins <michael.gogins@gmail.com> wrote:
|
| Date | 2013-05-03 00:25 |
| From | Michael Gogins |
| Subject | Re: [Cs-dev] MinGW build broken... again... |
| Attachments | None None |
>I think the separation makes sense from an API users perspective as it separated different uses. No one should use csoundCore, >hosts should use csound.h and plugins (opcodes and modules) should used csdl.h.
I understand your argument, but I do not agree with it.You think that from an API users perspective it is better to separate different uses, but I am an API user, and in my mind they are not different uses. Perhaps we should conduct a poll, but in any event, you cannot possibly know what all API users are thinking or whether their actual uses benefit from this separation -- my actual uses do not benefit from it and I have to undo it in many cases to get my code to build. I don't think this means there is something wrong with my code, it means that I am using Csound perhaps differently than you would use it.
What actual harm, such as broken builds (which have been caused by this in the past), would come from not separating the uses? On the other hand, actual harm does come from separating the uses but then not cleanly maintaining the separation. >The errors mentioned today don't stem from this separation, but from a missing definition within an ifdef in my case, and a change in >the signature of PerfError in the other case (this was Victor's work to allow better information display for perf errors, I think).You are correct, I also fixed the missing #ifdef just now. Mike On Thu, May 2, 2013 at 7:10 PM, Andres Cabrera <mantaraya36@gmail.com> wrote:
Michael Gogins Irreducible Productions http://www.michael-gogins.com Michael dot Gogins at gmail dot com |