| I have converted most defines to a config.h file in the branch
config-h, which I just have pushed. I had to make one change of which
I'm not certain it is correct[1], involving feature test macros. It
seems to me the code was wrong and just happened to build by chance,
but I'm not sure.
If nodody complains, I'll merge this tonight or tomorrow.
[1] http://csound.git.sourceforge.net/git/gitweb.cgi?p=csound/csound6.git;a=commitdiff;h=2d715b54e334055c203e089c249f463399b9da71
On Wed, Apr 11, 2012 at 14:31, Felipe Sateler wrote:
> Not really. I can't do it right now because I am behind a firewall
> that won't let anything but port 80 go by, and my git clone is
> hopelessly out of date.
>
> If someone wants to beat me to doing this, a howto-style guide is
> here: http://www.cmake.org/Wiki/CMake:How_To_Write_Platform_Checks
>
> On Wed, Apr 11, 2012 at 14:08, Victor Lazzarini
> wrote:
>> I think we should go for whatever is perceived as best practice. Is the config.in.h a lot of trouble to add?
>>
>> Victor
>> On 11 Apr 2012, at 18:01, Felipe Sateler wrote:
>>
>>> Actually, this is something I'd like to change. Adding defines to each
>>> target is error-prone, and needlessly pollutes the compiler command
>>> line. I think it is better to create a config.h.in that would get
>>> processed into a config.h that could be included by csoundCore.h or
>>> some other header.
>>>
>>> What do you think?
>>>
>>> As a workaround, you can do:
>>>
>>> if(HAVE_UNISTD_H)
>>> add_definitions("-DHAVE_UNISTD_H")
>>> endif()
>>>
>>> In util1/CMakeLists.txt
>>>
>>> On Wed, Apr 11, 2012 at 12:52, Victor Lazzarini
>>> wrote:
>>>> Maybe the function
>>>>
>>>> function(make_utility name srcs)
>>>> make_executable(${name} "${srcs}" "${CSOUNDLIB}")
>>>> add_dependencies(${name} ${CSOUNDLIB})
>>>> endfunction()
>>>>
>>>> in CMakeLists.txt top level needs to be fixed to append the required libraries and tokens?
>>>>
>>>> Victor
>>>> On 11 Apr 2012, at 16:32, jpff wrote:
>>>>
>>>>> The flags for which headers exist are not getting propagated to all
>>>>> parts
>>>>>
>>>>> Building C object util1/CMakeFiles/cs.dir/csd_util/cs.c.o
>>>>> cd /jpff/Sourceforge/csound/csound6/util1 && /usr/bin/gcc -DUSE_DOUBLE -DLINUX -Wall -O3 -mtune=corei7 -ftree-vectorize -ffast-math -g -I/usr/local/include -I/jpff/Sourceforge/csound/csound6/./H -I/jpff/Sourceforge/csound/csound6/./Engine -I/jpff/Sourceforge/csound/csound6/. -I/jpff/Sourceforge/csound/csound6 -fvisibility=hidden -Wno-format -o CMakeFiles/cs.dir/csd_util/cs.c.o -c /jpff/Sourceforge/csound/csound6/util1/csd_util/cs.c
>>>>> /jpff/Sourceforge/csound/csound6/util1/csd_util/cs.c: In function ‘main’:
>>>>> /jpff/Sourceforge/csound/csound6/util1/csd_util/cs.c:551:5: warning: implicit declaration of function ‘execvp’ [-Wimplicit-function-declaration]
>>>>>
>>>>> execvp is defined in and indeed HAVE_UNISTD_H is used in
>>>>> the sources and it is set in the CMakeLists.txt, but just not used.
>>>>>
>>>>> Cannot see how to fix this -- where does cmake get its CFLAGS from?
>>>>>
>>>>> ==John ffitch
>>>>>
>>>>> ------------------------------------------------------------------------------
>>>>> Better than sec? Nothing is better than sec when it comes to
>>>>> monitoring Big Data applications. Try Boundary one-second
>>>>> resolution app monitoring today. Free.
>>>>> http://p.sf.net/sfu/Boundary-dev2dev
>>>>> _______________________________________________
>>>>> Csound-devel mailing list
>>>>> Csound-devel@lists.sourceforge.net
>>>>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>>>>
>>>> Dr Victor Lazzarini
>>>> Senior Lecturer
>>>> Dept. of Music
>>>> NUI Maynooth Ireland
>>>> tel.: +353 1 708 3545
>>>> Victor dot Lazzarini AT nuim dot ie
>>>>
>>>>
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> Better than sec? Nothing is better than sec when it comes to
>>>> monitoring Big Data applications. Try Boundary one-second
>>>> resolution app monitoring today. Free.
>>>> http://p.sf.net/sfu/Boundary-dev2dev
>>>> _______________________________________________
>>>> Csound-devel mailing list
>>>> Csound-devel@lists.sourceforge.net
>>>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>>>
>>>
>>>
>>> --
>>>
>>> Saludos,
>>> Felipe Sateler
>>>
>>> ------------------------------------------------------------------------------
>>> Better than sec? Nothing is better than sec when it comes to
>>> monitoring Big Data applications. Try Boundary one-second
>>> resolution app monitoring today. Free.
>>> http://p.sf.net/sfu/Boundary-dev2dev
>>> _______________________________________________
>>> Csound-devel mailing list
>>> Csound-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>>
>> Dr Victor Lazzarini
>> Senior Lecturer
>> Dept. of Music
>> NUI Maynooth Ireland
>> tel.: +353 1 708 3545
>> Victor dot Lazzarini AT nuim dot ie
>>
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Better than sec? Nothing is better than sec when it comes to
>> monitoring Big Data applications. Try Boundary one-second
>> resolution app monitoring today. Free.
>> http://p.sf.net/sfu/Boundary-dev2dev
>> _______________________________________________
>> Csound-devel mailing list
>> Csound-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>
>
>
> --
>
> Saludos,
> Felipe Sateler
--
Saludos,
Felipe Sateler
------------------------------------------------------------------------------
For Developers, A Lot Can Happen In A Second.
Boundary is the first to Know...and Tell You.
Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
http://p.sf.net/sfu/Boundary-d2dvs2
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net
https://lists.source |