[Cs-dev] Compilation oddities
Date | 2014-05-06 08:47 |
From | jpff@cs.bath.ac.uk |
Subject | [Cs-dev] Compilation oddities |
Attachments | None |
Date | 2014-05-06 15:06 |
From | Felipe Sateler |
Subject | Re: [Cs-dev] Compilation oddities |
On Tue, May 6, 2014 at 3:47 AM, |
Date | 2014-05-06 16:09 |
From | Richard Dobson |
Subject | Re: [Cs-dev] Compilation oddities |
On 06/05/2014 15:06, Felipe Sateler wrote: > > iOS/Csound iOS Examples/csound-iOS/headers/CppSound.hpp:#define MYFLT double > iOS/Csound iOS Examples/csound-iOS/headers/CppSound.hpp:#define MYFLT float > iOS/Csound iOS Examples/csound-iOS/headers/CsoundFile.hpp:#define MYFLT double > iOS/Csound iOS Examples/csound-iOS/headers/CsoundFile.hpp:#define MYFLT float > iOS/Csound iOS Examples/csound-iOS/headers/csound.h:#define MYFLT float > iOS/Csound iOS Examples/csound-iOS/headers/csound.h:#define MYFLT double > iOS/Csound iOS Examples/csound-iOS/headers/filebuilding.h:#define MYFLT float > iOS/Csound iOS Examples/csound-iOS/headers/filebuilding.h:#define MYFLT double > iOS/Csound iOS Examples/csound-iOS/headers/sysdep.h:# define MYFLT float > iOS/Csound iOS Examples/csound-iOS/headers/sysdep.h:# define MYFLT double > include/csound.h:#define MYFLT float > include/csound.h:#define MYFLT double > include/sysdep.h:# define MYFLT float > include/sysdep.h:# define MYFLT double > interfaces/CppSound.hpp:#define MYFLT double > interfaces/CppSound.hpp:#define MYFLT float > interfaces/CsoundFile.hpp:#define MYFLT double > interfaces/CsoundFile.hpp:#define MYFLT float > interfaces/filebuilding.h:#define MYFLT float > interfaces/filebuilding.h:#define MYFLT double > mkdb.c:#define MYFLT float > I would normally have expected this to be defined at compiler level, not tautologously in multiple source files. Just sayin'... Richard Dobson ------------------------------------------------------------------------------ Is your legacy SCM system holding you back? Join Perforce May 7 to find out: 3 signs your SCM is hindering your productivity Requirements for releasing software faster Expert tips and advice for migrating your SCM now http://p.sf.net/sfu/perforce _______________________________________________ Csound-devel mailing list Csound-devel@lists.sourceforge.net |
Date | 2014-05-06 18:05 |
From | Steven Yi |
Subject | Re: [Cs-dev] Compilation oddities |
I've done a small analysis. First, the headers in the iOS folder can be ignored. We include those the Csound for iOS SDK and need them there for that. I think we could technically find a way that they could be .gitignore'd. For now though they aren't such a problem as they are just copied from the include folder, so any fixes in the include folder will be reused. That leaves: > include/csound.h:#define MYFLT float > include/csound.h:#define MYFLT double I think we can remove these, as MYFLT is set in sysdep.h which csound.h includes. > include/sysdep.h:# define MYFLT float > include/sysdep.h:# define MYFLT double Keep this as the main place where MYFLT gets defined > interfaces/CppSound.hpp:#define MYFLT double > interfaces/CppSound.hpp:#define MYFLT float I think these can go (need Michael to confirm). This header includes csound.hpp, which includes csound.h, which includes sysdep.h. > interfaces/CsoundFile.hpp:#define MYFLT double > interfaces/CsoundFile.hpp:#define MYFLT float I think it can be removed. CsoundFile.hpp and CsoundFile.cpp do not have any occurences of using MYFLT. Even if they did, CsoundFile.cpp includes csound.h (and thuse sysdep.h) > interfaces/filebuilding.h:#define MYFLT float > interfaces/filebuilding.h:#define MYFLT double I think this can be removed. This file includes sysdep.h, which in turn would have everything set correctly. > mkdb.c:#define MYFLT float I'm wondering about this. mkdb.c looks like it was used in CMake to build a mkdb command, but it is commented out. If this needs to be used, it might not compile as float-version.h may not be in the include folder (this depends if you do an in-source build or out-of-source build). John: Do you use this for anything currently? Should we maybe re-enable it within CMake? And if so, I think we can get rid of the define as sysdep.h gets included. On Tue, May 6, 2014 at 4:09 PM, Richard Dobson |
Date | 2014-05-06 20:00 |
From | Michael Gogins |
Subject | Re: [Cs-dev] Compilation oddities |
Attachments | None None |
There was something about the include paths not being picked up for CsoundFile and CppSound. It may have been in the C++ compilation or in the SWIG runs and subsequent C++ compilation. Regards,
Mike ----------------------------------------------------- Michael GoginsIrreducible Productions http://michaelgogins.tumblr.com Michael dot Gogins at gmail dot com On Tue, May 6, 2014 at 1:05 PM, Steven Yi <stevenyi@gmail.com> wrote: I've done a small analysis. First, the headers in the iOS folder can |
Date | 2014-05-06 20:32 |
From | Steven Yi |
Subject | Re: [Cs-dev] Compilation oddities |
Attachments | remove_extraneous_myflt.patch None None |
I tried removing the define's for MYFLT outside of sysdep.h and was able to compile csound and csoundAC. I don't know if something's changed since those were first introduced. Also, I have not tested as I'm not sure how to do so. Michael: could you assist in testing this? I have attached a git diff that I think you can apply with "git apply remove_extraneous_myflt.patch". (I've only tested here on OSX) On Tue, May 6, 2014 at 8:00 PM, Michael Gogins |