[Cs-dev] remote
| Date | 2006-10-13 10:52 |
| From | jpff |
| Subject | [Cs-dev] remote |
First apologies for the problems on Windows; it took a long time to
get it to a compilable state on linux and when I got that I committed.
There are a number of problems I have with the code, some of which I
mark down undergraduates for! For example
insrfd = (int*) calloc((size_t)129, sizeof(int));
chnrfd = (int*) calloc((size_t)17, sizeof(int));
ipadrs = (char*)calloc((size_t)15, sizeof(char));
129? Well it is 3*43 or 128+1 ....
17 if at least prime, but could be 16+1
15..... 16-1 ?
These should be named constants at least but I do not know what name
to use!
getIpAddress(ST(ipadrs), "eth0"); /* get IP adrs of this machine */
Ethernet is not always eth0 so should at the very least be
parameterised.
I removed the statics in remote.c but did not look at those in
remote.h, as placing statics in a header file included from more than
one place leads to nasties in ANSI C89. I guess I need to check them
(at least one is not used; two are really local)
==John ffitch
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net |
| Date | 2006-10-13 12:05 |
| From | "Steven Yi" |
| Subject | Re: [Cs-dev] remote |
| Attachments | None |
| Date | 2006-10-13 15:00 |
| From | Victor Lazzarini |
| Subject | Re: [Cs-dev] remote |
If they are really needed they can be turned into CSOUND dynamic globals, using the mechanism good ol' Istvan introduced. Victor At 10:52 13/10/2006, you wrote: >I removed the statics in remote.c but did not look at those in >remote.h, as placing statics in a header file included from more than >one place leads to nasties in ANSI C89. I guess I need to check them > >(at least one is not used; two are really local) Victor Lazzarini Music Technology Laboratory Music Department National University of Ireland, Maynooth ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Csound-devel mailing list Csound-devel@lists.sourceforge.net |
| Date | 2006-10-13 15:01 |
| From | Victor Lazzarini |
| Subject | Re: [Cs-dev] remote |
No real problem there, it was easy to fix it to get it compiling... I am not sure about working, though. Victor At 10:52 13/10/2006, you wrote: >First apologies for the problems on Windows; it took a long time to >get it to a compilable state on linux and when I got that I committed. Victor Lazzarini Music Technology Laboratory Music Department National University of Ireland, Maynooth ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Csound-devel mailing list Csound-devel@lists.sourceforge.net |