Hi All,

I was going through the code base for things that use hashes to
replace with the new CS_HASH_TABLE code and came upon cfgvar.c/.h.
These files are listed in the ChangeLog as:

        * H/cfgvar.h:
        * Engine/cfgvar.c:
          New files that implement an interface that allows dynamic creation
          of options.

This was by Istvan in 2005, and I don't see cfgvar.h being #included
anywhere except by cfgvar.c, csound.h, and the interface files.

I assume this is some kind of unfinished work meant to be used by
hosts. Considering it is in itself not used anywhere in the codebase
besides what I mentioned, it seems to me altogether unused.

I think these should be removed but want to check: is anyone using
these from hosts?

Thanks!
steven

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net

Isn't this the source code for CreateConfigurationVariable()? That is used in various modules (ie. rtjack). It is the
way to create the +-****** options.
On 23 Apr 2013, at 23:13, Steven Yi wrote:

> Hi All,
> 
> I was going through the code base for things that use hashes to
> replace with the new CS_HASH_TABLE code and came upon cfgvar.c/.h.
> These files are listed in the ChangeLog as:
> 
>        * H/cfgvar.h:
>        * Engine/cfgvar.c:
>          New files that implement an interface that allows dynamic creation
>          of options.
> 
> This was by Istvan in 2005, and I don't see cfgvar.h being #included
> anywhere except by cfgvar.c, csound.h, and the interface files.
> 
> I assume this is some kind of unfinished work meant to be used by
> hosts. Considering it is in itself not used anywhere in the codebase
> besides what I mentioned, it seems to me altogether unused.
> 
> I think these should be removed but want to check: is anyone using
> these from hosts?
> 
> Thanks!
> steven
> 
> ------------------------------------------------------------------------------
> Try New Relic Now & We'll Send You this Cool Shirt
> New Relic is the only SaaS-based application performance monitoring service 
> that delivers powerful full stack analytics. Optimize and monitor your
> browser, app, & servers with just a few lines of code. Try New Relic
> and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
> _______________________________________________
> Csound-devel mailing list
> Csound-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/csound-devel

Dr Victor Lazzarini
Senior Lecturer
Dept. of Music
NUI Maynooth Ireland
tel.: +353 1 708 3545
Victor dot Lazzarini AT nuim dot ie




------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net

Ah, I missed it earlier as I had didn't have the ALL_BUILD build
target selected in XCode.  Yeah, I see it being used now in a number
of places.  I missed that the functions would be used just by
#including csound.h.

There are a lot of #if 0 in the .h and .c files.  I'm going to delete
the code that's not used now to tidy up, then look at using
CS_HASH_TABLE if possible here.

Thanks for pointing that out!
steven

On Tue, Apr 23, 2013 at 11:23 PM, Victor Lazzarini
 wrote:
> Isn't this the source code for CreateConfigurationVariable()? That is used in various modules (ie. rtjack). It is the
> way to create the +-****** options.
> On 23 Apr 2013, at 23:13, Steven Yi wrote:
>
>> Hi All,
>>
>> I was going through the code base for things that use hashes to
>> replace with the new CS_HASH_TABLE code and came upon cfgvar.c/.h.
>> These files are listed in the ChangeLog as:
>>
>>        * H/cfgvar.h:
>>        * Engine/cfgvar.c:
>>          New files that implement an interface that allows dynamic creation
>>          of options.
>>
>> This was by Istvan in 2005, and I don't see cfgvar.h being #included
>> anywhere except by cfgvar.c, csound.h, and the interface files.
>>
>> I assume this is some kind of unfinished work meant to be used by
>> hosts. Considering it is in itself not used anywhere in the codebase
>> besides what I mentioned, it seems to me altogether unused.
>>
>> I think these should be removed but want to check: is anyone using
>> these from hosts?
>>
>> Thanks!
>> steven
>>
>> ------------------------------------------------------------------------------
>> Try New Relic Now & We'll Send You this Cool Shirt
>> New Relic is the only SaaS-based application performance monitoring service
>> that delivers powerful full stack analytics. Optimize and monitor your
>> browser, app, & servers with just a few lines of code. Try New Relic
>> and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
>> _______________________________________________
>> Csound-devel mailing list
>> Csound-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>
> Dr Victor Lazzarini
> Senior Lecturer
> Dept. of Music
> NUI Maynooth Ireland
> tel.: +353 1 708 3545
> Victor dot Lazzarini AT nuim dot ie
>
>
>
>
> ------------------------------------------------------------------------------
> Try New Relic Now & We'll Send You this Cool Shirt
> New Relic is the only SaaS-based application performance monitoring service
> that delivers powerful full stack analytics. Optimize and monitor your
> browser, app, & servers with just a few lines of code. Try New Relic
> and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
> _______________________________________________
> Csound-devel mailing list
> Csound-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/csound-devel

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net

Just FYI: I've updated cfgvar.c/.h and CSOUND* to use a CS_HASH_TABLE
for the cfgVariableDb.  I've also modified cfgvar.c to use
mmalloc/mfree instead of malloc/free.

Thanks!
steven

On Tue, Apr 23, 2013 at 11:29 PM, Steven Yi  wrote:
> Ah, I missed it earlier as I had didn't have the ALL_BUILD build
> target selected in XCode.  Yeah, I see it being used now in a number
> of places.  I missed that the functions would be used just by
> #including csound.h.
>
> There are a lot of #if 0 in the .h and .c files.  I'm going to delete
> the code that's not used now to tidy up, then look at using
> CS_HASH_TABLE if possible here.
>
> Thanks for pointing that out!
> steven
>
> On Tue, Apr 23, 2013 at 11:23 PM, Victor Lazzarini
>  wrote:
>> Isn't this the source code for CreateConfigurationVariable()? That is used in various modules (ie. rtjack). It is the
>> way to create the +-****** options.
>> On 23 Apr 2013, at 23:13, Steven Yi wrote:
>>
>>> Hi All,
>>>
>>> I was going through the code base for things that use hashes to
>>> replace with the new CS_HASH_TABLE code and came upon cfgvar.c/.h.
>>> These files are listed in the ChangeLog as:
>>>
>>>        * H/cfgvar.h:
>>>        * Engine/cfgvar.c:
>>>          New files that implement an interface that allows dynamic creation
>>>          of options.
>>>
>>> This was by Istvan in 2005, and I don't see cfgvar.h being #included
>>> anywhere except by cfgvar.c, csound.h, and the interface files.
>>>
>>> I assume this is some kind of unfinished work meant to be used by
>>> hosts. Considering it is in itself not used anywhere in the codebase
>>> besides what I mentioned, it seems to me altogether unused.
>>>
>>> I think these should be removed but want to check: is anyone using
>>> these from hosts?
>>>
>>> Thanks!
>>> steven
>>>
>>> ------------------------------------------------------------------------------
>>> Try New Relic Now & We'll Send You this Cool Shirt
>>> New Relic is the only SaaS-based application performance monitoring service
>>> that delivers powerful full stack analytics. Optimize and monitor your
>>> browser, app, & servers with just a few lines of code. Try New Relic
>>> and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
>>> _______________________________________________
>>> Csound-devel mailing list
>>> Csound-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>>
>> Dr Victor Lazzarini
>> Senior Lecturer
>> Dept. of Music
>> NUI Maynooth Ireland
>> tel.: +353 1 708 3545
>> Victor dot Lazzarini AT nuim dot ie
>>
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Try New Relic Now & We'll Send You this Cool Shirt
>> New Relic is the only SaaS-based application performance monitoring service
>> that delivers powerful full stack analytics. Optimize and monitor your
>> browser, app, & servers with just a few lines of code. Try New Relic
>> and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
>> _______________________________________________
>> Csound-devel mailing list
>> Csound-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/csound-devel

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net