For now, empty definitions are correct, thank you.

The SPINLOCK macros should remain. If they are not now used, they probably will be used.

notImplementedWarning_ is not defined because some opcodes scan csound.h but do not link with the Csound library. Either notImplementedWarning should be csound->notImplementedWarning_, which may require another change in the API, or it should also be a macro. 

Regards,
Mike

-----Original Message-----
>From: Anthony Kozar 
>Sent: Sep 9, 2008 2:53 AM
>To: Csound Developer list 
>Subject: Re: [Cs-dev] Spin locks again - broke build
>
>The most recent changes for the spinlocks failed to link here for me:
>
>Link Error   : undefined: 'notImplementedWarning_' (code)
>Referenced from 'outch' in aops.c
>
>The problem was in the csoundSpinLock and csoundSpinUnLock macros.
>
>  /* PUBLIC void csoundSpinLock(int32_t *spinlock) */
>#define csoundSpinLock(spinlock)                \
>  {                                             \
>    notImplementedWarning_("csoundSpinLock");   \
>  }
>
>  /* PUBLIC void csoundSpinUnlock(int32_t *spinlock) */
>#define csoundSpinUnLock(spinlock)              \
>  {                                             \
>    notImplementedWarning_("csoundSpinUnLock"); \
>  }
>
>
>I have changed these to empty definitions because it is not a good idea to
>print a couple of warnings everytime that one of the in or out opcodes is
>called.
>
>Also, these macros in csound.h no longer seem to be used:
>
>#define CSOUND_SPIN_LOCK
>#define CSOUND_SPIN_UNLOCK
>
>Anthony
>
>Michael Gogins wrote on 9/8/08 1:22 PM:
>
>> You are right. I will fix this.
>> 
>> Regards,
>> Mike
>> 
>> -----Original Message-----
>>> From: jpff 
>>> Sent: Sep 8, 2008 12:28 PM
>>> To: csound-devel@lists.sourceforge.net
>>> Subject: [Cs-dev] Spin locks again
>>> 
>>> There is an error; outs and outs1 use different spin locks so could
>>> run simultaneously.   Same for outq/outq1 etc
>>> ==John ffitch
>
>
>-------------------------------------------------------------------------
>This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>Build the coolest Linux based applications with Moblin SDK & win great prizes
>Grand prize is a trip for two to an Open Source event anywhere in the world
>http://moblin-contest.org/redirect.php?banner_id=100&url=/
>_______________________________________________
>Csound-devel mailing list
>Csound-devel@lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/csound-devel




-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net