[Csnd-dev] 6.10 Release - Remaining issues
Date | 2017-12-08 16:48 |
From | Steven Yi |
Subject | [Csnd-dev] 6.10 Release - Remaining issues |
Hi All, We had discussed getting the release branch started today but I think there's a few open loops to close: 1. Windows: Static-linking for libsndfile: this is done but there's one issue left with CsoundQt missing from the installer. A fix is in and it's being built on AppVeyor now. Testing of the previous Csound installer though passed my own light testing, but it would be good to get last minute checks by other users and developers using the API. (I'm looking into this.) 2. vst4cs: this is reported to cause a crash with Blue just by its presence in OPCODEDIR. (Reported by Menno on Linux). I suspect this may also cause crashes for other Csound API-based programs. (Awaiting Michael to fix.) 3. Realtime branch: This is work for the --realtime, particularly being driven by support for Bela at the moment, happening in the feature/realtime branch. I think it's gone back and forth whether this is will go into 6.10 or not. (Needs Victor to comment.) 4. Android: Realtime input seems to have problems. I saw the problem here on my Moto G4 and Jacques reported it on Pixel. I think both are 64-bit CPUs, which may be a factor. (I'm looking into this.) 1 and 4 should hopefully get done today. I think we should look at Sunday or Monday now to get these resolved and to start the branch. Please reply here if there are any other issues found. Thanks, |
Date | 2017-12-08 16:57 |
From | Rory Walsh |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
I too was having issues with Cabbage crashing on exit due to the present of vst4cs in the opcodes dir. I will check again tonight and report back. On 8 December 2017 at 16:48, Steven Yi <stevenyi@gmail.com> wrote: Hi All, |
Date | 2017-12-08 17:31 |
From | Michael Gogins |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
I will look at the vst4cs issue this evening or tomorrow. Best, Mike On Dec 8, 2017 11:58 AM, "Rory Walsh" <rorywalsh@ear.ie> wrote:
|
Date | 2017-12-08 18:16 |
From | Victor Lazzarini |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
For 3. I have it working, but needs more testing and some confirmation that spinlocks are ok for Bela. Victor Lazzarini
Dean of Arts, Celtic Studies, and Philosophy
Maynooth University
Ireland
|
Date | 2017-12-08 18:24 |
From | Steven Yi |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
Regarding #1 (Windows Installer, CsoundQt): CsoundQt is building and is included in the installer. I can run it and it shows Csound output when running an example. DrunkWalk.csd from Iain's collection runs fine in realtime. The installer tested was: https://ci.appveyor.com/project/csound/csound/build/6.10.968/artifacts I think #1 is then finished as CsoundQt is now in the installer. (There are a couple of other new issues however, see below.) Regarding #2: I found that CsoundQt on Windows hung whenever rendering was stopped. Deleting vst4cs.dll from the opcode dir fixed that. I suspect that it is the same issue reported by Menno and Rory, and this should make the problem with vst4cs easy to test. New issues: #5 - CsoundQt: VirtualKeyboard doesn't seem to work. This has to do with the one built by AppVeyor. If I use the 0.9.5 version released by Tarmo, VirtualKeyboard works fine. Since this has to do with CsoundQt, I'll leave it to Michael. #6 - I noticed that the HTML manual does not appear in CsoundQt's opcode help. This was reported earlier when users tested an earlier version of the installer. Since this is related to CsoundQt, I will leave it Michael to solve. On Fri, Dec 8, 2017 at 12:31 PM, Michael Gogins |
Date | 2017-12-08 19:54 |
From | Rory Walsh |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
I'll wait for Mike to look into issue number 2 before doing a completely new build of Cabbage. If CsoundQT is still crashing I expect Cabbage will too. Mike, let me know when you have something for me to test. Thanks. On 8 December 2017 at 18:24, Steven Yi <stevenyi@gmail.com> wrote: Regarding #1 (Windows Installer, CsoundQt): CsoundQt is building and |
Date | 2017-12-08 21:13 |
From | Steven Yi |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
Regarding #4: I'm having some problems with logcat at the moment, but what I've found so far is that if I set nchnls_i=1 in harmonizer.csd and ping_pong_delay.csd in the example project, those examples will work though with distorted sound. (Otherwise, those files would default to use the same nchnls_i as nchnls, which is 2). I see multiple problems here: 1. bqRecorderCallback looks to be using GetNchnls, while rtopensl.c was changed to GetNchnls_i in the openSL device opening. 2. Changes related to input happened in openSL last year (see last four commits to the file https://github.com/csound/csound/commits/develop/android/CsoundAndroid/jni/rtopensl.c). The last four commits are done by Michael and Victor. What I suspect: on devices that were used for testing when the changes happened, stereo audio input was possible, but it is not possible on other devices (like the Google Pixel and MotoG4). This might be related to device but it may also be related to OS version too. I've had this MotoG4 for about 11 months and I would have used this when we did the last release. The only difference I can think of is that my OS version upgraded to 7.0 since the last Csound release. Also, prior to the last four commits on rtopensl.c, we defaulted to only opening mono input. This seems to work across all devices, or at least, seemed to work for years since we first started the Csound for Android SDK. I am not sure what should happen here. Since this seems to stem from changes from Victor and Michael, perhaps they could comment on this situation. On Fri, Dec 8, 2017 at 2:54 PM, Rory Walsh |
Date | 2017-12-08 21:41 |
From | Tarmo Johannes |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
Hi, about #1: api-ms-win-crt-heap-l1-1-0.dll api-ms-win-crt-runtime-l1-1-0.dll api-ms-win-crt-math-l1-1-0.dll tarmo 2017-12-08 20:24 GMT+02:00 Steven Yi <stevenyi@gmail.com>: Regarding #1 (Windows Installer, CsoundQt): CsoundQt is building and |
Date | 2017-12-08 21:50 |
From | Rory Walsh |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
Thanks for the heads up Tarmo on the directory change. That's kind of frustrating, what's the reason for the change? I have a lot of different projects set to build against Csound and each time the default location changes it involves me wasting time updating all my build scripts. Can we decide what it will be and just stick to it? On 8 December 2017 at 21:41, Tarmo Johannes <trmjhnns@gmail.com> wrote:
|
Date | 2017-12-08 22:07 |
From | Steven Yi |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
Hi Tarmo: For missing DLL, does it show a kind of message or something? And is this for CsoundQt only, or happen when running commandline csound? I only have Windows 10 here so I am not sure what I can do here to test. On my system, when I went to use the installer it installed into Csound_x64. I don't know if that's because I had a previous install already. Perhaps Michael would know about this as it looks like something related to artifact name changing he discussed here. Thanks, steven On Fri, Dec 8, 2017 at 4:41 PM, Tarmo Johannes |
Date | 2017-12-08 22:08 |
From | Tarmo Johannes |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
Wait, I am now on Windows 10 and I don't have this probleem any more - Csound was installer into Csound6_x64 as before. Maybe I pressed somewhere during installation bedore. If nobody confirms, just please forget about it. Nevertheless - Csound6x_64/doc does not contain manual subfolder - that's why it was not found. I don't get crashes on exit. I renamed the previous installation folder and did clean install. I suspectt the new vst plugin library is in conflict with something left over from previous installation. I had the same on linux- crashes first but afet make uninstall, make clean and reistnall solved the problem. #2 virtual midi keyboard took long time to open and indeed - it does not send events to Csound. Will have closer look. tarmo 2017-12-08 23:50 GMT+02:00 Rory Walsh <rorywalsh@ear.ie>:
|
Date | 2017-12-08 22:31 |
From | Tarmo Johannes |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
Hello, Another strange thing I noticed - the bin folder is missing libsndfile-1.dll Is it actually necessary? i guess when Csound is compiled against the MSVC .lib library of sndfile, it might not be needed. i noticed the probelm when I tried to start CsoundQt 0.9.5 from zip file by CsoundQt release. It was built against Csound 6.09 and via some dpendencies requires libsndfile.dll When I copied the file from Csound 6.09 installation to folder of CsoundQt (mine), then it started fine. This problem happens only when user erases or removes the previous installation, otherwise libsndfile-1.dll just stays there. Thus it is not really a bug, just good to know. t 2017-12-09 0:07 GMT+02:00 Steven Yi <stevenyi@gmail.com>: Hi Tarmo: |
Date | 2017-12-08 22:57 |
From | Tarmo Johannes |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
Hi, #2 (CsoundQt virtual midi) I was not able to get CsoundQt running built against installed Csoun 6.10. So I could not debug. Can it be that the linsndfile-1.lib in my computer (that I have not updated fro some time) conflicts with the one in appveyor build. But the reason might be simple: from Configure->MIDI input interface I see "No RtMidi support" thus CsoundQt was just not built with RtMidi (most likely the necessary sources were not pulled and built by AppVeyor). Can it be? In CsoundQt 0.9.5 from the release it Works fine. If this can be a solution, we can think of leaving CsoundQt out of Appveyor installer and provide separaate installer for CsoundQt. I can think of preparing one. Better of course is that appveyor does the job, so everything comes from one place and has thus less possible conflicts. What do you think? greetings, tarmo 2017-12-09 0:31 GMT+02:00 Tarmo Johannes <trmjhnns@gmail.com>:
|
Date | 2017-12-08 22:58 |
From | Steven Yi |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
HI Tarmo, As mentioned in another thread, having a dynamically linked libsndfile for Csound itself causes a major problem when used from API apps that link to a different C runtime than what was used for libsndfile. (As documented on libsndfile's API.) For Csound 6.09 and earlier, where we used MinGW, libsndfile and dependencies were statically linked. In the VS build, it was initially dynamically linked, I discovered the problem when running from Blue, and thus modified to use static libsndfile. The csound library now works from API and commandline, regardless of what C runtime was linked to the host program. For CsoundQt, because I switched to static libsndfile for Csound, I set the CsoundQt being built on AppVeyor to the same. Does CsoundQt specifically require dynamic linking to libsndfile? I just uninstalled Csound6 to start from a clean slate. Using the installer, it did indeed ask to install into "c:\Program Files\csound-windows-x64". So that looks to be a problem. I have no libsndfile.dll but CsoundQt is still running (but Virtual Keyboard is still broken). steven On Fri, Dec 8, 2017 at 5:31 PM, Tarmo Johannes |
Date | 2017-12-08 23:10 |
From | Tarmo Johannes |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
Thanks for clarification, If I add old libsndfile to the zip of CsoundQt (built against 6.09). There is no more problem. When I build against 6.10, no libsndfile.dll is needed any more so that is also fine. Only thing I need to figure out are crashes on starting Csound files with my local build. But that tomorrow. Thanks! Tqrmo 09.12.2017 0:59 kirjutas kuupäeval "Steven Yi" <stevenyi@gmail.com>: HI Tarmo, |
Date | 2017-12-08 23:37 |
From | Steven Yi |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
I think that I had proposed multiples times that we only use the last official, pre-built, stable version released by CsoundQt, so obviously I am find with that. I was, and am still, critical of CsoundQt being built for the Csound installer by AppVeyor. It was these kinds of problems (having to test multiple CsoundQt builds against Csound...) that I wanted to avoid. Anyways, since Michael designed and put that part of the installer together, I think it's on him now to address what happens here for CsoundQt. One other note: With a clean install, I am not getting the hanging in CsoundQt as I did before with vst4cs being present. Perhaps as Tarmo mentioned it has to do with some interference with another older opcode lib or something like that; regardless, I think there is still some kind of problem with vst4cs if it could possibly cause some kind of hang/crash. And just so we don't lose track, #7 should be Csound installer installing into "c:\Program Files\csound-windows-x64" by default being a problem. On Fri, Dec 8, 2017 at 5:57 PM, Tarmo Johannes |
Date | 2017-12-09 09:35 |
From | Rory Walsh |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
For what it's worth, I'm not seeing any install to csound-windows-x64, so I think we can thankfully mark that as a none issue. I'm also not seeing any crashes on exit with Cabbage, either in standalone mode or when testing plugins. On 8 December 2017 at 23:37, Steven Yi <stevenyi@gmail.com> wrote: I think that I had proposed multiples times that we only use the last |
Date | 2017-12-09 11:58 |
From | Rory Walsh |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
Sorry to throw a spanner in the works here but that vst4cs issue is still present. I didn't notice it before because I didn't try recompiling any instruments in Cabbage. CsoundQT still seem to run fine however. On 9 December 2017 at 09:35, Rory Walsh <rorywalsh@ear.ie> wrote:
|
Date | 2017-12-11 18:30 |
From | Rory Walsh |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
Hi Mike, you mentioned you would look into the vst4cs issue on Sunday, did you make any head way? On 9 December 2017 at 11:58, Rory Walsh <rorywalsh@ear.ie> wrote:
|
Date | 2017-12-11 19:02 |
From | Michael Gogins |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
I haven't had a chance yet, will try today or tomorrow. Best, Mike ----------------------------------------------------- Michael Gogins Irreducible Productions http://michaelgogins.tumblr.com Michael dot Gogins at gmail dot com On Mon, Dec 11, 2017 at 1:30 PM, Rory Walsh |
Date | 2017-12-12 01:43 |
From | Michael Gogins |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
Here is the current status of crashes with the vst4cs opcodes on Linux. I did not test on Windows. TL;DR: -- No problems with CsoundQt. -- No problems with blue. -- Problems with Cabbage but not (as far as I can tell) because of the vst4cs opcodes. The gory details follow. This is on: Linux Sun-Yukong 4.4.0-103-generic #126-Ubuntu SMP Mon Dec 4 16:23:28 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Built with: Using built-in specs. COLLECT_GCC=gcc COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/5/lto-wrapper Target: x86_64-linux-gnu Configured with: ../src/configure -v --with-pkgversion='Ubuntu 5.4.0-6ubuntu1~16.04.5' --with-bugurl=file:///usr/share/doc/gcc-5/README.Bugs --enable-languages=c,ada,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-5 --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-libmpx --enable-plugin --with-system-zlib --disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-5-amd64/jre --enable-java-home --with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-5-amd64 --with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-5-amd64 --with-arch-directory=amd64 --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --enable-objc-gc --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu Thread model: posix gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.5) Csound develop branch commit 16eac02760816f1b665f163b5d6a1b8466487350 I installed the VST2 SDK from: https://download.steinberg.net/sdk_downloads/vstsdk368_08_11_2017_build_121.zip I built Csound with: #!/bin/sh clear cd ~/csound/cs6make rm CMakeCache.txt cmake ../csound -DSCORE_PARSER:BOOL=Yes -DABLETON_LINK_HOME:PATH=/home/mkg/link -DBUILD_ABLETON_LINK_OPCODES:BOOL=Yes -DBUILD_STATIC_LIBRARY:Bool=Yes -DBUILD_TESTS:BOOL=Yes -DCMAKE_BUILD_TYPE=RelWithDebInfo -DBUILD_HDF5_OPCODES:BOOL=Yes -DVSTSDK2X_INCLUDE_DIR:PATH=/home/mkg/VST_SDK/VST2_SDK -DBUILD_CSOUND_VST=1 -DBUILD_VST4CS_OPCODES=1 -DLLVM_DIR=/usr/local/lib/cmake/llvm -DCMAKE_MODULE_LINKER_FLAGS="-L /usr/local/lib" -DFAUST_LIBRARY=/usr/local/lib/libfaust.a -DBUILD_FAUST_OPCODES:BOOL=No make VERBOSE=1 -j6 $1 if [ "$1" = "clean" ] then exit fi I installed Csound with: sudo make install I built CsoundQt master branch commit 9592159dedca3723693f390c8d5c9cc01eb415b3 using qtcreator, and ran CsoundQt from qtcreator. I ran the following test csd: |
Date | 2017-12-12 03:10 |
From | Steven Yi |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
I took a quick look. My guess is your testing didn't do the same things as what we're all using/testing. The code has a static vectors. Menno's report has: # C [libvst4cs.so+0x14fc8] std::vector |
Date | 2017-12-12 06:51 |
From | Victor Lazzarini |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
Did you say they were static? I have not looked at the code. We can’t have static variables anywhere in Csound.
Victor Lazzarini
Dean of Arts, Celtic Studies, and Philosophy
Maynooth University
Ireland
|
Date | 2017-12-12 11:36 |
From | Rory Walsh |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
I've also being referring to Cabbage v2. Cabbage v1, the one I think you are using, is no longer under development. The new version can be found here: cabbageaudio.com/beta/ On 12 December 2017 at 06:51, Victor Lazzarini <Victor.Lazzarini@mu.ie> wrote:
|
Date | 2017-12-12 12:42 |
From | Michael Gogins |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
There has to be shared state because multiple opcode instances must share data, e.g. multiple vstnote opcodes must send midi events to the same vst plugin. There must be separate vstnote opcodes to manage notes staying on both in score driven and midi driven performance. Regards, Mike On Dec 12, 2017 01:51, "Victor Lazzarini" <Victor.Lazzarini@mu.ie> wrote:
|
Date | 2017-12-12 12:47 |
From | John ff |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
Surely a global structure from the heap is required, not astatic? This is used all over everything odd code Sent from TypeApp On Dec 12, 2017, 12:42, at 12:42, Michael Gogins |
Date | 2017-12-12 13:02 |
From | Michael Gogins |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
There also is the requirement that heap allocated by VST plugins themselves (or fluidsynths, or STK opcodes) be deallocated during csoundReset. Best, Mike ----------------------------------------------------- Michael Gogins Irreducible Productions http://michaelgogins.tumblr.com Michael dot Gogins at gmail dot com On Tue, Dec 12, 2017 at 7:42 AM, Michael Gogins |
Date | 2017-12-12 13:12 |
From | Victor Lazzarini |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
You need to find a way of implementing those requirements in such a way that does not break the conditions in which Csound operates. We do sharing of state everywhere in Csound, but use global space allocated and managed in the Csound instance (e.g. csound->CreateGlobalVariable() etc). We cannot ship opcodes that break this and/or leak memory. ======================== Prof. Victor Lazzarini Dean of Arts, Celtic Studies, and Philosophy, Maynooth University, Maynooth, Co Kildare, Ireland Tel: 00 353 7086936 Fax: 00 353 1 7086952 > On 12 Dec 2017, at 13:02, Michael Gogins |
Date | 2017-12-12 15:52 |
From | Steven Yi |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
Attachments | test.py |
We went through this whole discussion a year ago: https://listserv.heanet.ie/cgi-bin/wa?A2=ind1612&L=CSOUND-DEV&P=133264 and it had to do with statics, crashing, using CreateGlobalVariable instead, and so on. In that thread, Michael mentions doing some tests about statics and library loading. I think from reading through the thread, the tests must have been faulty, otherwise the vst4cs opcodes would not get a segfault on csoundModuleUnload and try to deref a NULL pointer. In that email thread, I also spent time to rewrite the code to use CreateGlobalVariables which removed the use of statics. Statics were put back in after that. I have attached a python script that can be used to test the vst4cs problem. The script has: from csnd6 import Csound a = Csound() b = Csound() a.Start() b.Start() a.Reset() b.Reset() del a del b # CRASH You can run this script using "python test.py". This will, underneath the hood, interleave calls to load and unload modules (i.e., load, load, unload, unload). With vst4cs.dll present, it consistently crashes every time. After removing vst4cs, it does not crash at all. (On windows, at the end of script, a dialog pops up saying Python crashed. I don't know if a segfault will be reported or what on Linux/OSX.) I think we need to ban the style of static usage, as found in vst4cs, once and for all from our codebase. These kinds of crashes are hard to describe for users in their reports (if they even bother to report it and don't just give up on Csound immediately), and they are painful to diagnose for API users (mysterious crash? let's try to reproduce. oh okay, I managed to reproduce the problem. It's... some opcode library? And you didn't even use the opcodes? What? And how much time did I just spend looking into this? Can I blame my users if they're confused and giving up on my program because of this? Do I even want to keep using Csound as the basis of my program if this kind of thing keeps happening year after year?). On Tue, Dec 12, 2017 at 8:12 AM, Victor Lazzarini |
Date | 2017-12-12 15:59 |
From | Victor Lazzarini |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
I have to agree. This can also lead to the trouble reported in https://github.com/csound/csound/issues/722 . There is a whole thread of conversation there too. I feel we are going in circles. We need a few ground rules, and no statics, no memory allocation outside the Csound memory system are two basic ones we can’t ignore. ======================== Prof. Victor Lazzarini Dean of Arts, Celtic Studies, and Philosophy, Maynooth University, Maynooth, Co Kildare, Ireland Tel: 00 353 7086936 Fax: 00 353 1 7086952 > On 12 Dec 2017, at 15:52, Steven Yi |
Date | 2017-12-12 16:16 |
From | Michael Gogins |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
I will change the code to observe these rules as far as possible. I am not sure it is always possible if state must be managed across Csound instances. I have opened an issue about this so you can follow what I am doing. Regards, Mike ----------------------------------------------------- Michael Gogins Irreducible Productions http://michaelgogins.tumblr.com Michael dot Gogins at gmail dot com On Tue, Dec 12, 2017 at 10:59 AM, Victor Lazzarini |
Date | 2017-12-12 16:28 |
From | Michael Gogins |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
I ran your script and it behaves as you say. I can use this for testing. Best, Mike ----------------------------------------------------- Michael Gogins Irreducible Productions http://michaelgogins.tumblr.com Michael dot Gogins at gmail dot com On Tue, Dec 12, 2017 at 10:52 AM, Steven Yi |
Date | 2017-12-14 19:28 |
From | Michael Gogins |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
I have removed static variables holding global state from all of the files mentioned by Steven Yi (not all of them had such variables), and moved that global state into Csound global variables. I must apologize for removing similar code written by Steven some time ago. I did that because on Windows it did not seem to make any difference. There is however a difference in how static variables behave in shared objects between Microsoft C++ and Gnu C++. The new code passes `make tests`, passes Steven's example Python script demonstrating the problem, and also works in some of the manual examples for these opcodes. The Windows installer, also, is building on AppVeyor again. Feedback is appreciated! Regards, Mike ----------------------------------------------------- Michael Gogins Irreducible Productions http://michaelgogins.tumblr.com Michael dot Gogins at gmail dot com On Tue, Dec 12, 2017 at 11:28 AM, Michael Gogins |
Date | 2017-12-14 19:53 |
From | Victor Lazzarini |
Subject | Re: [Csnd-dev] 6.10 Release - Remaining issues |
Thanks for this. I’ll see if I can have a look. Victor Lazzarini
Dean of Arts, Celtic Studies, and Philosophy
Maynooth University
Ireland
|