[Cs-dev] Incompatible changes to exprand and bexprnd
Date | 2006-06-28 12:52 |
From | Istvan Varga |
Subject | [Cs-dev] Incompatible changes to exprand and bexprnd |
Attachments | None |
Date | 2006-06-29 18:44 |
From | Andres Cabrera |
Subject | Re: [Cs-dev] Incompatible changes to exprand and bexprnd |
On Wed, 2006-06-28 at 13:52 +0200, Istvan Varga wrote: > I noticed that exprand, bexprnd, and GEN21 were changed by John ffitch > (in addition to a lot of purposeless messing with code that is not > relevant here) to output zero on a negative range parameter, unlike > Csound versions 5.00 to 5.02.1 which inverted the output then. > > Is this change really intended ? If yes, perhaps the difference between > versions should be documented. I agree purposeless reformatting of code is annoying (and John is not the only culprit), maybe code formatting should be standardized? How about sharing the script, or 'indent' parameters or the like... I'm sure much hostility could have been avoided if this had been chosen in time. But, about the behavior Istvan reports, I find this is again a trivial matter of personal preference, specially since the documentation mentions nothing, so using negative numbers can be thought of as undefined behavior. I do however prefer Istvan's solution, because just outputting 0 without a warning might be odd. Cheers, Andres Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Csound-devel mailing list Csound-devel@lists.sourceforge.net |
Date | 2006-06-29 19:51 |
From | matt ingalls |
Subject | Re: [Cs-dev] Incompatible changes to exprand and bexprnd |
> > I agree purposeless reformatting of code is annoying (and John is not > the only culprit), maybe code formatting should be standardized? How i think both a reformatting script and an attempt to formalize it is a waste of time. with all the different text editors and platforms and personal preferences, i doubt no standardization can be found that pleases everyone. running a formatting script also clutters cvs logs and makes it harder to see when real changes have been made to a file. Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Csound-devel mailing list Csound-devel@lists.sourceforge.net |
Date | 2006-06-30 06:50 |
From | jpff@codemist.co.uk |
Subject | Re: [Cs-dev] Incompatible changes to exprand and bexprnd |
I was restoring the original definitions in csound4. I am not aware of any discussions about making this particular incompatible change. The reformating was part of my reading of what was originally my code in order to understand what has happened to it. ==John ffitch Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Csound-devel mailing list Csound-devel@lists.sourceforge.net |
Date | 2006-06-30 14:01 |
From | Andres Cabrera |
Subject | Re: [Cs-dev] Incompatible changes to exprand and bexprnd |
True... Just trying to find a solution.... Cheers, Andres On Thu, 2006-06-29 at 11:51 -0700, matt ingalls wrote: > > > > I agree purposeless reformatting of code is annoying (and John is not > > the only culprit), maybe code formatting should be standardized? How > > i think both a reformatting script and an attempt to formalize it is > a waste of time. with all the different text editors > and platforms and personal preferences, i doubt no standardization can > be found that pleases everyone. > > running a formatting script also clutters cvs logs and makes > it harder to see when real changes have been made to a file. > > > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > _______________________________________________ > Csound-devel mailing list > Csound-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/csound-devel > > Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Csound-devel mailing list Csound-devel@lists.sourceforge.net |