[Cs-dev] Do not use Str in this context

[Cs-dev] Do not use Str in this context

Date	2012-08-23 08:07
From	Tito Latini
Subject	[Cs-dev] Do not use Str in this context
Attachments	None

Date	2012-08-23 09:30
From	Victor Lazzarini
Subject	Re: [Cs-dev] Do not use Str in this context
	virtual_keyboard.cpp is Steven's code, not Michael's: /* virtual_keyboard.cpp: Copyright (C) 2006 Steven Yi ========== As far as I understand 'Str(x)' should be used on all messages. Otherwise translations will not work. I agree with Tito that better communication is also desirable. Victor On 23 Aug 2012, at 08:07, Tito Latini wrote: > Michael, it is your comment in the last git commit. > > http://csound.git.sourceforge.net/git/gitweb.cgi?p=csound/csound5.git;a=commitdiff;h=1a5ca60a5be152e5e > > Please, write the cause of the commit and not what I have to do. > > I used DebugMsg instead of remove the message. > > `Str' is defined in `csdl.h' (not only here), imported in > `virtual_keyboard.cpp'. > > #undef Str > #ifndef GNU_GETTEXT > #define Str(x) (x) > #else > #define Str(x) (csound->LocalizeString(x)) > #endif > > If it is a problem with C++, you can correct your jacko.cpp, > lines 537, 545, 551, 559, 570, 574, 589, 629, 894, 897, 913, 957, 971, > 1064, 1079, 1171, 1186, 1243, 1257. > > See also `widgets.cpp'. > > If it is a problem with `csoundDebugMsg', it uses > `csoundMessageCallback_' as in `csoundMessage' etc and adds a newline char > (I forgot to remove a newline in the string of the message if it is a problem). > > I don't use my personal style but I adapt the code to the rest. > Besides, I fixed your bugs without blames or comments. > > Regards, > Tito Latini > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Csound-devel mailing list > Csound-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/csound-devel Dr Victor Lazzarini Senior Lecturer Dept. of Music NUI Maynooth Ireland tel.: +353 1 708 3545 Victor dot Lazzarini AT nuim dot ie ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Csound-devel mailing list Csound-devel@lists.sourceforge.net

Date	2012-08-23 16:46
From	Steven Yi
Subject	Re: [Cs-dev] Do not use Str in this context
	I wrote the original VK, but haven't touched it in a long while. There was a change by Tito that Michael then changed. I also think descriptive commit messages is always better, as in this situation, I don't think any offense was meant in Michael's commit message. On Thu, Aug 23, 2012 at 4:30 AM, Victor Lazzarini wrote: > virtual_keyboard.cpp is Steven's code, not Michael's: > > /* > virtual_keyboard.cpp: > > Copyright (C) 2006 Steven Yi > > ========== > > As far as I understand 'Str(x)' should be used on all messages. Otherwise translations will not work. > > I agree with Tito that better communication is also desirable. > > Victor > > > On 23 Aug 2012, at 08:07, Tito Latini wrote: > >> Michael, it is your comment in the last git commit. >> >> http://csound.git.sourceforge.net/git/gitweb.cgi?p=csound/csound5.git;a=commitdiff;h=1a5ca60a5be152e5e >> >> Please, write the cause of the commit and not what I have to do. >> >> I used DebugMsg instead of remove the message. >> >> `Str' is defined in `csdl.h' (not only here), imported in >> `virtual_keyboard.cpp'. >> >> #undef Str >> #ifndef GNU_GETTEXT >> #define Str(x) (x) >> #else >> #define Str(x) (csound->LocalizeString(x)) >> #endif >> >> If it is a problem with C++, you can correct your jacko.cpp, >> lines 537, 545, 551, 559, 570, 574, 589, 629, 894, 897, 913, 957, 971, >> 1064, 1079, 1171, 1186, 1243, 1257. >> >> See also `widgets.cpp'. >> >> If it is a problem with `csoundDebugMsg', it uses >> `csoundMessageCallback_' as in `csoundMessage' etc and adds a newline char >> (I forgot to remove a newline in the string of the message if it is a problem). >> >> I don't use my personal style but I adapt the code to the rest. >> Besides, I fixed your bugs without blames or comments. >> >> Regards, >> Tito Latini >> >> ------------------------------------------------------------------------------ >> Live Security Virtual Conference >> Exclusive live event will cover all the ways today's security and >> threat landscape has changed and how IT managers can respond. Discussions >> will include endpoint security, mobile security and the latest in malware >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> _______________________________________________ >> Csound-devel mailing list >> Csound-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/csound-devel > > Dr Victor Lazzarini > Senior Lecturer > Dept. of Music > NUI Maynooth Ireland > tel.: +353 1 708 3545 > Victor dot Lazzarini AT nuim dot ie > > > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Csound-devel mailing list > Csound-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/csound-devel ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Csound-devel mailing list Csound-devel@lists.sourceforge.net

Date	2012-08-23 16:58
From	Michael Gogins
Subject	Re: [Cs-dev] Do not use Str in this context
	No offense was meant, and if any was taken I apologize. I have found several times over the past year or so that using Str with a plain string, i.e. no formatting string with varargs, would not compile. I removed these instances as I did not know what to do about them. Regards, Mike On Thu, Aug 23, 2012 at 11:46 AM, Steven Yi wrote: > I wrote the original VK, but haven't touched it in a long while. There > was a change by Tito that Michael then changed. I also think > descriptive commit messages is always better, as in this situation, I > don't think any offense was meant in Michael's commit message. > > > On Thu, Aug 23, 2012 at 4:30 AM, Victor Lazzarini > wrote: >> virtual_keyboard.cpp is Steven's code, not Michael's: >> >> /* >> virtual_keyboard.cpp: >> >> Copyright (C) 2006 Steven Yi >> >> ========== >> >> As far as I understand 'Str(x)' should be used on all messages. Otherwise translations will not work. >> >> I agree with Tito that better communication is also desirable. >> >> Victor >> >> >> On 23 Aug 2012, at 08:07, Tito Latini wrote: >> >>> Michael, it is your comment in the last git commit. >>> >>> http://csound.git.sourceforge.net/git/gitweb.cgi?p=csound/csound5.git;a=commitdiff;h=1a5ca60a5be152e5e >>> >>> Please, write the cause of the commit and not what I have to do. >>> >>> I used DebugMsg instead of remove the message. >>> >>> `Str' is defined in `csdl.h' (not only here), imported in >>> `virtual_keyboard.cpp'. >>> >>> #undef Str >>> #ifndef GNU_GETTEXT >>> #define Str(x) (x) >>> #else >>> #define Str(x) (csound->LocalizeString(x)) >>> #endif >>> >>> If it is a problem with C++, you can correct your jacko.cpp, >>> lines 537, 545, 551, 559, 570, 574, 589, 629, 894, 897, 913, 957, 971, >>> 1064, 1079, 1171, 1186, 1243, 1257. >>> >>> See also `widgets.cpp'. >>> >>> If it is a problem with `csoundDebugMsg', it uses >>> `csoundMessageCallback_' as in `csoundMessage' etc and adds a newline char >>> (I forgot to remove a newline in the string of the message if it is a problem). >>> >>> I don't use my personal style but I adapt the code to the rest. >>> Besides, I fixed your bugs without blames or comments. >>> >>> Regards, >>> Tito Latini >>> >>> ------------------------------------------------------------------------------ >>> Live Security Virtual Conference >>> Exclusive live event will cover all the ways today's security and >>> threat landscape has changed and how IT managers can respond. Discussions >>> will include endpoint security, mobile security and the latest in malware >>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >>> _______________________________________________ >>> Csound-devel mailing list >>> Csound-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/csound-devel >> >> Dr Victor Lazzarini >> Senior Lecturer >> Dept. of Music >> NUI Maynooth Ireland >> tel.: +353 1 708 3545 >> Victor dot Lazzarini AT nuim dot ie >> >> >> >> >> ------------------------------------------------------------------------------ >> Live Security Virtual Conference >> Exclusive live event will cover all the ways today's security and >> threat landscape has changed and how IT managers can respond. Discussions >> will include endpoint security, mobile security and the latest in malware >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> _______________________________________________ >> Csound-devel mailing list >> Csound-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/csound-devel > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Csound-devel mailing list > Csound-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/csound-devel -- Michael Gogins Irreducible Productions http://www.michael-gogins.com Michael dot Gogins at gmail dot com ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Csound-devel mailing list Csound-devel@lists.sourceforge.net

Date	2012-08-23 17:15
From	Victor Lazzarini
Subject	Re: [Cs-dev] Do not use Str in this context
	Well, that needs to be fixed. Do you have an example? On 23 Aug 2012, at 16:58, Michael Gogins wrote: > No offense was meant, and if any was taken I apologize. > > I have found several times over the past year or so that using Str > with a plain string, i.e. no formatting string with varargs, would not > compile. I removed these instances as I did not know what to do about > them. > > Regards, > Mike > > On Thu, Aug 23, 2012 at 11:46 AM, Steven Yi wrote: >> I wrote the original VK, but haven't touched it in a long while. There >> was a change by Tito that Michael then changed. I also think >> descriptive commit messages is always better, as in this situation, I >> don't think any offense was meant in Michael's commit message. >> >> >> On Thu, Aug 23, 2012 at 4:30 AM, Victor Lazzarini >> wrote: >>> virtual_keyboard.cpp is Steven's code, not Michael's: >>> >>> /* >>> virtual_keyboard.cpp: >>> >>> Copyright (C) 2006 Steven Yi >>> >>> ========== >>> >>> As far as I understand 'Str(x)' should be used on all messages. Otherwise translations will not work. >>> >>> I agree with Tito that better communication is also desirable. >>> >>> Victor >>> >>> >>> On 23 Aug 2012, at 08:07, Tito Latini wrote: >>> >>>> Michael, it is your comment in the last git commit. >>>> >>>> http://csound.git.sourceforge.net/git/gitweb.cgi?p=csound/csound5.git;a=commitdiff;h=1a5ca60a5be152e5e >>>> >>>> Please, write the cause of the commit and not what I have to do. >>>> >>>> I used DebugMsg instead of remove the message. >>>> >>>> `Str' is defined in `csdl.h' (not only here), imported in >>>> `virtual_keyboard.cpp'. >>>> >>>> #undef Str >>>> #ifndef GNU_GETTEXT >>>> #define Str(x) (x) >>>> #else >>>> #define Str(x) (csound->LocalizeString(x)) >>>> #endif >>>> >>>> If it is a problem with C++, you can correct your jacko.cpp, >>>> lines 537, 545, 551, 559, 570, 574, 589, 629, 894, 897, 913, 957, 971, >>>> 1064, 1079, 1171, 1186, 1243, 1257. >>>> >>>> See also `widgets.cpp'. >>>> >>>> If it is a problem with `csoundDebugMsg', it uses >>>> `csoundMessageCallback_' as in `csoundMessage' etc and adds a newline char >>>> (I forgot to remove a newline in the string of the message if it is a problem). >>>> >>>> I don't use my personal style but I adapt the code to the rest. >>>> Besides, I fixed your bugs without blames or comments. >>>> >>>> Regards, >>>> Tito Latini >>>> >>>> ------------------------------------------------------------------------------ >>>> Live Security Virtual Conference >>>> Exclusive live event will cover all the ways today's security and >>>> threat landscape has changed and how IT managers can respond. Discussions >>>> will include endpoint security, mobile security and the latest in malware >>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >>>> _______________________________________________ >>>> Csound-devel mailing list >>>> Csound-devel@lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/csound-devel >>> >>> Dr Victor Lazzarini >>> Senior Lecturer >>> Dept. of Music >>> NUI Maynooth Ireland >>> tel.: +353 1 708 3545 >>> Victor dot Lazzarini AT nuim dot ie >>> >>> >>> >>> >>> ------------------------------------------------------------------------------ >>> Live Security Virtual Conference >>> Exclusive live event will cover all the ways today's security and >>> threat landscape has changed and how IT managers can respond. Discussions >>> will include endpoint security, mobile security and the latest in malware >>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >>> _______________________________________________ >>> Csound-devel mailing list >>> Csound-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/csound-devel >> >> ------------------------------------------------------------------------------ >> Live Security Virtual Conference >> Exclusive live event will cover all the ways today's security and >> threat landscape has changed and how IT managers can respond. Discussions >> will include endpoint security, mobile security and the latest in malware >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> _______________________________________________ >> Csound-devel mailing list >> Csound-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/csound-devel > > > > -- > Michael Gogins > Irreducible Productions > http://www.michael-gogins.com > Michael dot Gogins at gmail dot com > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Csound-devel mailing list > Csound-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/csound-devel Dr Victor Lazzarini Senior Lecturer Dept. of Music NUI Maynooth Ireland tel.: +353 1 708 3545 Victor dot Lazzarini AT nuim dot ie ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Csound-devel mailing list Csound-devel@lists.sourceforge.net

Date	2012-08-23 18:20
From	Tito Latini
Subject	Re: [Cs-dev] Do not use Str in this context
Attachments	None