Csound Csound-dev Csound-tekno Search About

[Cs-dev] remove event changes

Date2006-10-26 22:53
FromAnthony Kozar
Subject[Cs-dev] remove event changes
I've modified the remote event code in such a way as to confine all of the
#ifdefs to remote.h/c.  The code is conditionalized on HAVE_SOCKETS with a
stub interface for when they are not present. I modified SConstruct to check
for the primary headers and define HAVE_SOCKETS if they are found.  The
remote opcodes still exist on all builds but print warnings when sockets are
not available.

Please check that everything compiles and works.  I have not tested the
opcodes yet but they will just print warnings on OS 9.  Please make sure
that they do not print warnings on the other platforms.

I may have made mistakes since this is not an area I know anything about.  I
would especially appreciate John looking over the code to make sure that I
did not introduce any bugs.

If everything is working, I think that I may be done making changes for this
release.  Maybe we can still release next week??

THANKS!

Anthony Kozar
anthonykozar AT sbcglobal DOT net


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net

Date2006-10-27 04:40
FromAnthony Kozar
SubjectRe: [Cs-dev] remove event changes
Hello,

While working on this earlier, I noticed the following static variable in
remote.c.  It's companion REMOT_BUF SVrecvbuf; was moved into the CSOUND
struct.  Should this one be moved as well?

/*////////////////  MUSMON SERVICES  ////////////////*/

static REMOT_BUF CLsendbuf;   /* rt evt output Communications buffer */


Also, in remote.h, it looked like the following lines could be removed but I
wasn't sure:

extern int *insrfd;
extern int *chnrfd;
extern int insrfd_count;
extern int chnrfd_count;

int CLsend(CSOUND *csound, int conn, void *data, int length);


And near the top:

void m_chanmsg(CSOUND *csound, MEVENT *mep);   /* called from midirecv &
musmon */


I also assume that this notice at the top of remote.c/h should be changed?:

    This file is not yet part of Csound.


Thanks.

Anthony Kozar
anthonykozar AT sbcglobal DOT net



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net

Date2006-10-27 11:49
FromVictor Lazzarini
SubjectRe: [Cs-dev] remove event changes
Just a quick note to remind that 'inline' is not C89 and the changed
remote.c has linkage problems with MSVC6.0. I did an ifndef MSVC
here, but if sources are to be kept to C89, these 'inlines' have to be
removed. I am not sure who added them, so I have only ifndef'ed
them.

Victor

At 04:40 27/10/2006, you wrote:
>Hello,
>
>While working on this earlier, I noticed the following static variable in
>remote.c.  It's companion REMOT_BUF SVrecvbuf; was moved into the CSOUND
>struct.  Should this one be moved as well?
>
>/*////////////////  MUSMON SERVICES  ////////////////*/
>
>static REMOT_BUF CLsendbuf;   /* rt evt output Communications buffer */
>
>
>Also, in remote.h, it looked like the following lines could be removed but I
>wasn't sure:
>
>extern int *insrfd;
>extern int *chnrfd;
>extern int insrfd_count;
>extern int chnrfd_count;
>
>int CLsend(CSOUND *csound, int conn, void *data, int length);
>
>
>And near the top:
>
>void m_chanmsg(CSOUND *csound, MEVENT *mep);   /* called from midirecv &
>musmon */
>
>
>I also assume that this notice at the top of remote.c/h should be changed?:
>
>     This file is not yet part of Csound.
>
>
>Thanks.
>
>Anthony Kozar
>anthonykozar AT sbcglobal DOT net
>
>
>
>-------------------------------------------------------------------------
>Using Tomcat but need to do more? Need to support web services, security?
>Get stuff done quickly with pre-integrated technology to make your job easier
>Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
>http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
>_______________________________________________
>Csound-devel mailing list
>Csound-devel@lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/csound-devel

Victor Lazzarini
Music Technology Laboratory
Music Department
National University of Ireland, Maynooth 


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net

Date2006-10-27 18:07
FromAnthony Kozar
SubjectRe: [Cs-dev] remove event changes
Sorry about that!  Mea culpa.

There are inline declarations all over Csound and sysdep.h defines it for
several compilers, so I thought it was OK.  Apparently, the linker cannot
reference an inline function from another file (??).  I did not see these
errors yesterday because inline was actually being #defined to nothing on
MacOS 9.  Now that I have defined it in sysdef.h I get the same errors.

So, I am removing all of the inlines from remote.c (although they would have
been a good idea since those functions are trivial).

Apologies again for the inconvenience!

Anthony


Victor Lazzarini wrote on 10/27/06 6:49 AM:

> Just a quick note to remind that 'inline' is not C89 and the changed
> remote.c has linkage problems with MSVC6.0. I did an ifndef MSVC
> here, but if sources are to be kept to C89, these 'inlines' have to be
> removed. I am not sure who added them, so I have only ifndef'ed
> them.


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net