| Ah yes I see it now. But it is not an optimization (and I don't think
it should be disabled by the flag). I will move it to the main
CMakeLists.txt (and remove the other references).
On Wed, Aug 14, 2013 at 6:10 PM, Steven Yi wrote:
> Hi Felipe,
>
> The visibility stuff should be in csound6/cmake/CompilerOptimizations:
>
> check_c_compiler_flag(-fvisibility=hidden HAS_VISIBILITY_HIDDEN)
> check_cxx_compiler_flag(-fvisibility=hidden HAS_CXX_VISIBILITY_HIDDEN)
> if (HAS_VISIBILITY_HIDDEN)
> set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fvisibility=hidden")
> endif()
> if (HAS_CXX_VISBILITY_HIDDEN)
> set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fvisibility=hidden")
> endif()
>
> Maybe it should be moved from there?
>
> steven
>
>
> On Wed, Aug 14, 2013 at 6:05 PM, Felipe Sateler wrote:
>>
>> Hi Steven,
>>
>> I'm currently looking at the changes, and saw that you removed the
>> -fvisibility flag. I really think that flag should be enabled
>> (otherwise the library exposes a lot of unnecessary symbols).
>>
>> I'm now building....
>>
>>
>> On Mon, Aug 12, 2013 at 10:08 AM, Felipe Sateler
>> wrote:
>> > Hi Steven,
>> >
>> > Unfortunately, I couldn't try it out this weekend, I'll let you know
>> > when I try again.
>> >
>> > On Mon, Aug 12, 2013 at 3:10 AM, Steven Yi wrote:
>> >> Hi Felipe and Alex,
>> >>
>> >> I've made changes that I think should fix issues with Raspberry Pi and
>> >> for Debian Packaging. If you call could try it out that'd be great.
>> >> I'll close the ticket once it's been confirmed.
>> >>
>> >> Thanks!
>> >> steven
>> >>
>> >> On Thu, Aug 8, 2013 at 1:49 AM, Steven Yi wrote:
>> >>> Thanks Felipe! I saw the notes and they're very handy. Hope it will
>> >>> be easy to figure out for whomever gets to it first. :)
>> >>>
>> >>> On Wed, Aug 7, 2013 at 4:28 PM, Felipe Sateler
>> >>> wrote:
>> >>>> OK, I have modified Alex's already reported issue. I've assigned it
>> >>>> to
>> >>>> you and added a comment with some pointers.
>> >>>>
>> >>>> I may find time during this weekend to update csound in debian (we
>> >>>> have cs6 in unstable today but it fails to build in almost all archs
>> >>>> due to this same bug hehe). If I do, I can try to fix this too.
>> >>>>
>> >>>> On Wed, Aug 7, 2013 at 6:43 AM, Steven Yi wrote:
>> >>>>> Hi Felipe,
>> >>>>>
>> >>>>> Sorry I'm behind on emails. Could you file a bug in the tracker for
>> >>>>> this? You can assign it to me (kunstmusik) and I'll plan to have
>> >>>>> the
>> >>>>> modifications for the next release.
>> >>>>>
>> >>>>> Thanks!
>> >>>>> steven
>> >>>>>
>> >>>>> On Mon, Jul 29, 2013 at 6:41 PM, Felipe Sateler
>> >>>>> wrote:
>> >>>>>> I don't know. I find the build configuration options in cmake
>> >>>>>> awkward,
>> >>>>>> as they require specifying every flag at least twice (once for
>> >>>>>> release
>> >>>>>> and once for debug builds), so I wouldn't encourage using it.
>> >>>>>>
>> >>>>>> I think a reasonable approach is to define a list of optimization
>> >>>>>> flags to enable, before including Custom.cmake. That way they can
>> >>>>>> be
>> >>>>>> overriden/extended there.
>> >>>>>>
>> >>>>>>
>> >>>>>> On Sat, Jul 27, 2013 at 4:25 PM, Steven Yi
>> >>>>>> wrote:
>> >>>>>>> Hi Felipe,
>> >>>>>>>
>> >>>>>>> This makes me curious, what is the "standard" approach (if there
>> >>>>>>> are
>> >>>>>>> any) for compiler optimizations for CMake? I know there are
>> >>>>>>> certain
>> >>>>>>> flags we'll want to set as the norm, others will have to depend if
>> >>>>>>> the
>> >>>>>>> processor supports it, and others will be supplied by the user's
>> >>>>>>> platform. The part I'm not sure about is what are the defaults
>> >>>>>>> per
>> >>>>>>> platform, if any. Do you know if there is a standard practice in
>> >>>>>>> regards to this?
>> >>>>>>>
>> >>>>>>> Thanks!
>> >>>>>>> steven
>> >>>>>>>
>> >>>>>>> On Fri, Jul 26, 2013 at 5:53 PM, Felipe Sateler
>> >>>>>>> wrote:
>> >>>>>>>> Please add an option to disable adding any optimizations, so that
>> >>>>>>>> downstreams can build with whatever flags we watn
>> >>>>>>>>
>> >>>>>>>> On Fri, Jul 26, 2013 at 4:53 PM, Steven Yi
>> >>>>>>>> wrote:
>> >>>>>>>>> Hi Alex,
>> >>>>>>>>>
>> >>>>>>>>> Could you file a bug in the tracker for this with the
>> >>>>>>>>> information from
>> >>>>>>>>> this email? I agree with Justin that this should be
>> >>>>>>>>> automatically
>> >>>>>>>>> done.
>> >>>>>>>>>
>> >>>>>>>>> Thanks!
>> >>>>>>>>> steven
>> >>>>>>>>>
>> >>>>>>>>> On Thu, Jul 25, 2013 at 1:06 PM, Alex Hofmann
>> >>>>>>>>> wrote:
>> >>>>>>>>>> Hi,
>> >>>>>>>>>>
>> >>>>>>>>>> I've build CSnd6 on a Raspberry Pi today, but had some trouble
>> >>>>>>>>>> with Cmake
>> >>>>>>>>>> and the compiler, I'd like to report.
>> >>>>>>>>>> With the standard cmake, make.. the following error occured:
>> >>>>>>>>>> "cc1: error: unrecognized command line option ‘-mfpmath=sse’"
>> >>>>>>>>>>
>> >>>>>>>>>> I replaced in “CMakeLists.txt” lines 1014 &1015:
>> >>>>>>>>>>
>> >>>>>>>>>> 1014 add_compiler_flags(${libcsound_CFLAGS}
>> >>>>>>>>>> -fvisibility=hidden
>> >>>>>>>>>>
>> >>>>>>>>>> 1015 -ffast-math -mfpmath=sse -fomit-frame-pointer
>> >>>>>>>>>> TARGETS
>> >>>>>>>>>> ${CSOUNDLIB})
>> >>>>>>>>>>
>> >>>>>>>>>>
>> >>>>>>>>>>
>> >>>>>>>>>>
>> >>>>>>>>>> by: add_compiler_flags(${libcsound_CFLAGS} TARGETS
>> >>>>>>>>>> ${CSOUNDLIB})
>> >>>>>>>>>> Than it worked. And runs nicely on the Raspberry! :-)
>> >>>>>>>>>>
>> >>>>>>>>>>
>> >>>>>>>>>>
>> >>>>>>>>>> Seems like the Rasp does not support scalar floating point
>> >>>>>>>>>> instructions
>> >>>>>>>>>> present in the SSE instruction set?
>> >>>>>>>>>>
>> >>>>>>>>>> Maybe disable SSE could be an additional Cmake option?
>> >>>>>>>>>>
>> >>>>>>>>>>
>> >>>>>>>>>> Best wishes,
>> >>>>>>>>>> Alex
>> >>>>>>>>>>
>> >>>>>>>>>>
>> >>>>>>>>>>
>> >>>>>>>>>> ------------------------------------------------------------------------------
>> >>>>>>>>>> See everything from the browser to the database with
>> >>>>>>>>>> AppDynamics
>> >>>>>>>>>> Get end-to-end visibility with application monitoring from
>> >>>>>>>>>> AppDynamics
>> >>>>>>>>>> Isolate bottlenecks and diagnose root cause in seconds.
>> >>>>>>>>>> Start your free trial of AppDynamics Pro today!
>> >>>>>>>>>>
>> >>>>>>>>>> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
>> >>>>>>>>>> _______________________________________________
>> >>>>>>>>>> Csound-devel mailing list
>> >>>>>>>>>> Csound-devel@lists.sourceforge.net
>> >>>>>>>>>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>> >>>>>>>>>>
>> >>>>>>>>>
>> >>>>>>>>>
>> >>>>>>>>> ------------------------------------------------------------------------------
>> >>>>>>>>> See everything from the browser to the database with AppDynamics
>> >>>>>>>>> Get end-to-end visibility with application monitoring from
>> >>>>>>>>> AppDynamics
>> >>>>>>>>> Isolate bottlenecks and diagnose root cause in seconds.
>> >>>>>>>>> Start your free trial of AppDynamics Pro today!
>> >>>>>>>>>
>> >>>>>>>>> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
>> >>>>>>>>> _______________________________________________
>> >>>>>>>>> Csound-devel mailing list
>> >>>>>>>>> Csound-devel@lists.sourceforge.net
>> >>>>>>>>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>> --
>> >>>>>>>>
>> >>>>>>>> Saludos,
>> >>>>>>>> Felipe Sateler
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>> ------------------------------------------------------------------------------
>> >>>>>>>> See everything from the browser to the database with AppDynamics
>> >>>>>>>> Get end-to-end visibility with application monitoring from
>> >>>>>>>> AppDynamics
>> >>>>>>>> Isolate bottlenecks and diagnose root cause in seconds.
>> >>>>>>>> Start your free trial of AppDynamics Pro today!
>> >>>>>>>>
>> >>>>>>>> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
>> >>>>>>>> _______________________________________________
>> >>>>>>>> Csound-devel mailing list
>> >>>>>>>> Csound-devel@lists.sourceforge.net
>> >>>>>>>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>> >>>>>>>
>> >>>>>>>
>> >>>>>>> ------------------------------------------------------------------------------
>> >>>>>>> See everything from the browser to the database with AppDynamics
>> >>>>>>> Get end-to-end visibility with application monitoring from
>> >>>>>>> AppDynamics
>> >>>>>>> Isolate bottlenecks and diagnose root cause in seconds.
>> >>>>>>> Start your free trial of AppDynamics Pro today!
>> >>>>>>>
>> >>>>>>> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
>> >>>>>>> _______________________________________________
>> >>>>>>> Csound-devel mailing list
>> >>>>>>> Csound-devel@lists.sourceforge.net
>> >>>>>>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>> >>>>>>
>> >>>>>>
>> >>>>>>
>> >>>>>> --
>> >>>>>>
>> >>>>>> Saludos,
>> >>>>>> Felipe Sateler
>> >>>>>>
>> >>>>>>
>> >>>>>> ------------------------------------------------------------------------------
>> >>>>>> Get your SQL database under version control now!
>> >>>>>> Version control is standard for application code, but databases
>> >>>>>> havent
>> >>>>>> caught up. So what steps can you take to put your SQL databases
>> >>>>>> under
>> >>>>>> version control? Why should you start doing it? Read more to find
>> >>>>>> out.
>> >>>>>>
>> >>>>>> http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
>> >>>>>> _______________________________________________
>> >>>>>> Csound-devel mailing list
>> >>>>>> Csound-devel@lists.sourceforge.net
>> >>>>>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>> >>>>>
>> >>>>>
>> >>>>> ------------------------------------------------------------------------------
>> >>>>> Get 100% visibility into Java/.NET code with AppDynamics Lite!
>> >>>>> It's a free troubleshooting tool designed for production.
>> >>>>> Get down to code-level detail for bottlenecks, with <2% overhead.
>> >>>>> Download for free and get started troubleshooting in minutes.
>> >>>>>
>> >>>>> http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
>> >>>>> _______________________________________________
>> >>>>> Csound-devel mailing list
>> >>>>> Csound-devel@lists.sourceforge.net
>> >>>>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>> >>>>
>> >>>>
>> >>>>
>> >>>> --
>> >>>>
>> >>>> Saludos,
>> >>>> Felipe Sateler
>> >>>>
>> >>>>
>> >>>> ------------------------------------------------------------------------------
>> >>>> Get 100% visibility into Java/.NET code with AppDynamics Lite!
>> >>>> It's a free troubleshooting tool designed for production.
>> >>>> Get down to code-level detail for bottlenecks, with <2% overhead.
>> >>>> Download for free and get started troubleshooting in minutes.
>> >>>>
>> >>>> http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
>> >>>> _______________________________________________
>> >>>> Csound-devel mailing list
>> >>>> Csound-devel@lists.sourceforge.net
>> >>>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>> >>
>> >>
>> >> ------------------------------------------------------------------------------
>> >> Get 100% visibility into Java/.NET code with AppDynamics Lite!
>> >> It's a free troubleshooting tool designed for production.
>> >> Get down to code-level detail for bottlenecks, with <2% overhead.
>> >> Download for free and get started troubleshooting in minutes.
>> >>
>> >> http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
>> >> _______________________________________________
>> >> Csound-devel mailing list
>> >> Csound-devel@lists.sourceforge.net
>> >> https://lists.sourceforge.net/lists/listinfo/csound-devel
>> >
>> >
>> >
>> > --
>> >
>> > Saludos,
>> > Felipe Sateler
>>
>>
>>
>> --
>>
>> Saludos,
>> Felipe Sateler
>>
>>
>> ------------------------------------------------------------------------------
>> Get 100% visibility into Java/.NET code with AppDynamics Lite!
>> It's a free troubleshooting tool designed for production.
>> Get down to code-level detail for bottlenecks, with <2% overhead.
>> Download for free and get started troubleshooting in minutes.
>>
>> http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
>> _______________________________________________
>> Csound-devel mailing list
>> Csound-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>
>
>
> ------------------------------------------------------------------------------
> Get 100% visibility into Java/.NET code with AppDynamics Lite!
> It's a free troubleshooting tool designed for production.
> Get down to code-level detail for bottlenecks, with <2% overhead.
> Download for free and get started troubleshooting in minutes.
> http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
> _______________________________________________
> Csound-devel mailing list
> Csound-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/csound-devel
>
--
Saludos,
Felipe Sateler
------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/csound-dev |