| Just FYI: I was looking through my pieces and it looks like I've had
this bit of errant code for many years now (earliest piece I found
that has it crashing is from 2006).
I guess this is a bigger issue to deal with as the behavior of Csound
has changed. I imagine other pieces by others might be affected. I'm
wondering what is the best course of action. Obviously division by
zero is allowed in C, as we were using that before, though the result
is undefined. In other languages, a division by zero throws an
exception.
On the one hand, I like that a division by zero would give an error to
the user. It'd help to debug Csound code. On the other hand, I
dislike that my pieces won't compile and thus backwards compatibility
is broken.
I'd like to then make the case that we return to the older behavior
and simply return the division by zero result that C gives, with the
idea that backwards compatibility is more important here. We could
issue warnings if division by zero is found. For older pieces like
mine, it would cause lots of errors especially if done a k-time, but
at least the piece would run.
On Tue, May 6, 2014 at 10:39 AM, Steven Yi wrote:
> Thanks John and Victor for looking at this!
>
> The iEndAmp line looks like something I used to use in older pieces
> but I had changed how it was used later. It seems then that this is a
> case that I had bad Csound code for a while now without realizing it.
>
> In that case, Csound crashing on error is the bug, but with valid
> code that won't be a problem. I think since we already released
> 6.03.0, we should wait to finish off the release, then commit fixed
> code to a hotfix branch (6.03.1). That way we won't have any
> confusion over the releases and what's "really" in the release. Sound
> good?
>
> On Tue, May 6, 2014 at 8:32 AM, wrote:
>>
>> Quoting Victor Lazzarini :
>>
>>> This line seems to be culprit:
>>>
>>> 529: iEndAmp = iNewAmp / iOldAmp
>>>
>>>
>>
>> even odder is that the value of iEndAmp in not used!
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Is your legacy SCM system holding you back? Join Perforce May 7 to find out:
>> 3 signs your SCM is hindering your productivity
>> Requirements for releasing software faster
>> Expert tips and advice for migrating your SCM now
>> http://p.sf.net/sfu/perforce
>> _______________________________________________
>> Csound-devel mailing list
>> Csound-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/csound-devel
------------------------------------------------------------------------------
Is your legacy SCM system holding you back? Join Perforce May 7 to find out:
3 signs your SCM is hindering your productivity
Requirements for releasing software faster
Expert tips and advice for migrating your SCM now
http://p.sf.net/sfu/perforce
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net |