Csound Csound-dev Csound-tekno Search About

Re: [Cs-dev] Changes submitted to CVS

Date2005-01-28 15:54
From"gogins@pipeline.com"
SubjectRe: [Cs-dev] Changes submitted to CVS
I don't think we need to worry about int being short any more.

Original Message:
-----------------
From: Anthony Kozar anthony.kozar@utoledo.edu
Date: Fri, 28 Jan 2005 00:00:26 -0500
To: csound-devel@lists.sourceforge.net
Subject: Re: [Cs-dev] Changes submitted to CVS


Istvan, 

I am glad that you are back and contributing to Csound again.  However, a
number of these changes are pretty major redesigns.  Perhaps it would have
been better to discuss them on the list before committing them.


On 1/27/05 2:51 PM, Istvan Varga  etched in stone:

> 2005-01-27      Istvan Varga    
> * Engine/entry1.c:
> * Engine/entry2.c:
> * Engine/express.c:
> * Engine/otran.c:
> * Engine/rdorch.c:
> use '.' instead of '_' in internal opcode names (e.g. osc.kk
> instead of osc_kk); this allows the use of the underscore
> character in real opcode names. Many files in Opcodes/ were
> also changed.

This is a rather significant change which has been discussed but not
pursued.

> * strings/makedb.c:
> * strings/all_strings, strings/english-strings, strings/french-strings:
> * H/text.h:
> * Top/getstring.c:
> new implementation for localized messages. Uses Str("...")
> instead of Str(X_nnnn,"..."). This also needed replacement
> of Str() in a large number of files.

I've looked at your old code for this recently, and I have to wonder if
indexing strings via the strings themselves is really a better idea than
indexing them by numbers.

For one thing, I am pretty sure that you just completely broke the getstring
code on MacOS 9.  The current Mac implementation requires that the strings
be numbered.

Could you please explain why you feel this change is necessary?

> * Engine/oload.c, Engine/otran.c, H/csoundCore.h:
> use 'int' type for variable indexes instead of 'short';
> needs some testing

If you really want to make sure that a larger integer size is used, you
should use long, not int.  int is the same size as short on some platforms.


Anthony Kozar
anthony.kozar@utoledo.edu
http://akozar.spymac.net/



-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/csound-devel

--------------------------------------------------------------------
mail2web - Check your email from the web at
http://mail2web.com/ .




-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net