[Csnd-dev] 6.10 draft release notes
Date | 2017-10-14 21:59 |
From | jpff |
Subject | [Csnd-dev] 6.10 draft release notes |
I have updated the notes for the changes in the last month. Incomplete naturally. git-log records in need of noting or deleting below. Any assistance welcome ==John ffitch commit 1191a12cf38048437286295297b55f9997e101e0 (HEAD -> develop, origin/develop) Author: veplaini |
Date | 2017-10-16 04:32 |
From | joachim heintz |
Subject | Re: [Csnd-dev] 6.10 draft release notes |
would it be possible to include eduardo moguillansky's contributions (sc_...)? i think there were some problems in the work flow, but many were interested to see these new opcodes in csound (and have a contribution from a new developer). joachim On 14/10/17 22:59, jpff wrote: > I have updated the notes for the changes in the last month. Incomplete > naturally. git-log records in need of noting or deleting below. Any > assistance welcome > > ==John ffitch > > commit 1191a12cf38048437286295297b55f9997e101e0 (HEAD -> develop, origin/develop) > Author: veplaini |
Date | 2017-10-16 16:25 |
From | jpff |
Subject | Re: [Csnd-dev] 6.10 draft release notes |
The sc_ opcodes were in 6.09 and in release Notes. I am not aware of any others On Mon, 16 Oct 2017, joachim heintz wrote: > would it be possible to include eduardo moguillansky's contributions > (sc_...)? i think there were some problems in the work flow, but many were > interested to see these new opcodes in csound (and have a contribution from a > new developer). > > joachim > > > On 14/10/17 22:59, jpff wrote: >> I have updated the notes for the changes in the last month. Incomplete >> naturally. git-log records in need of noting or deleting below. Any >> assistance welcome >> >> ==John ffitch |
Date | 2017-10-16 17:22 |
From | Steven Yi |
Subject | Re: [Csnd-dev] 6.10 draft release notes |
Eduardo had tried to use Pull Requests but both times didn't work out (the first modified every single file in the code base; the second one needed multiple changes). Both PRs were reviewed and changes were requested. These are in 846 and 847: https://github.com/csound/csound/pull/846 https://github.com/csound/csound/pull/847 There were a number of rounds of changes requested and required and, IMO, with all good reason. (No, we can't take code when there are licensing issues. No, we can't apply a PR when there are extraneous files. No, we don't as a rule take opcodes without documentation.) Eduardo was great to reply and work through the changes but the process dragged on a while. When asked for additional fixes to the PR in 847 and for documentation on the new opcodes the PR was withdrawn. I asked off-list if he wanted to have his work integrated directly by one of us since the PR revisions didn't get to a point where they could be merged, but I have not heard anything. At this point, I don't think there's much more to do on our side. We went through the PR process and did it the right way to pre-review changes before integrating contributions into the code base. We did indeed catch issues. Everyone spent a lot of their personal time to move it forward. I think we'd all be happy for the contributions to make their way into Csound but right now, since they've been withdrawn, there's nothing to do as far as I can see. On Mon, Oct 16, 2017 at 11:25 AM, jpff |
Date | 2017-10-16 18:02 |
From | joachim heintz |
Subject | Re: [Csnd-dev] 6.10 draft release notes |
ok — i did not know this end of the story in detail. thanks for the explanations. so it is as it is. On 16/10/17 18:22, Steven Yi wrote: > Eduardo had tried to use Pull Requests but both times didn't work out > (the first modified every single file in the code base; the second one > needed multiple changes). Both PRs were reviewed and changes were > requested. These are in 846 and 847: > > https://github.com/csound/csound/pull/846 > https://github.com/csound/csound/pull/847 > > There were a number of rounds of changes requested and required and, > IMO, with all good reason. (No, we can't take code when there are > licensing issues. No, we can't apply a PR when there are extraneous > files. No, we don't as a rule take opcodes without documentation.) > Eduardo was great to reply and work through the changes but the > process dragged on a while. When asked for additional fixes to the PR > in 847 and for documentation on the new opcodes the PR was withdrawn. > > I asked off-list if he wanted to have his work integrated directly by > one of us since the PR revisions didn't get to a point where they > could be merged, but I have not heard anything. > > At this point, I don't think there's much more to do on our side. We > went through the PR process and did it the right way to pre-review > changes before integrating contributions into the code base. We did > indeed catch issues. Everyone spent a lot of their personal time to > move it forward. I think we'd all be happy for the contributions to > make their way into Csound but right now, since they've been > withdrawn, there's nothing to do as far as I can see. > > > > On Mon, Oct 16, 2017 at 11:25 AM, jpff |