Csound Csound-dev Csound-tekno Search About

Re: [Cs-dev] Broken: csound/csound#884 (develop - 5b4cae7)

Date2015-05-25 20:48
Fromjpff
SubjectRe: [Cs-dev] Broken: csound/csound#884 (develop - 5b4cae7)
Running diret under valgrind I see something slightly different

==6631== Thread 2:
==6631== Invalid read of size 8
==6631==    at 0x4E9D154: spoutsf (libsnd.c:78)
==6631==    by 0x4F9776A: kperf_nodebug (csound.c:1588)
==6631==    by 0x4F98D9B: csoundPerformKsmps (csound.c:1927)
==6631==    by 0x5753D9D: CsoundPerformanceThread::Perform() (csPerfThread.cpp:431)
==6631==    by 0x57557D8: CsPerfThread_PerformScore::Perform() (csPerfThread.cpp:478)
==6631==    by 0x5753FF3: csoundPerformanceThread_ (csPerfThread.cpp:495)
==6631==    by 0x550C0A3: start_thread (in /lib64/libpthread-2.19.so)
==6631==    by 0x626F06C: clone (in /lib64/libc-2.19.so)
==6631==  Address 0x9b23e80 is 0 bytes after a block of size 528 alloc'd
==6631==    at 0x4C2B200: calloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==6631==    by 0x4E8B957: mcalloc (memalloc.c:113)
==6631==    by 0x4E8E43F: musmon (musmon.c:205)
==6631==    by 0x4F9B6F3: csoundStart (main.c:484)
==6631==    by 0x407CE1: Csound::Start() (csound.hpp:269)
==6631==    by 0x40743B: test_record() (perfthread_test.cpp:68)
==6631==    by 0x52F6260: ??? (in /usr/lib64/libcunit.so.1.0.1)
==6631==    by 0x52F656E: ??? (in /usr/lib64/libcunit.so.1.0.1)
==6631==    by 0x52F68A5: CU_run_all_tests (in /usr/lib64/libcunit.so.1.0.1)
==6631==    by 0x407653: main (perfthread_test.cpp:117)

==John ffitch

------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net

Date2015-05-26 16:52
FromSteven Yi
SubjectRe: [Cs-dev] Broken: csound/csound#884 (develop - 5b4cae7)
AttachmentsNone  None  
I took a little bit of a look and don't have much to add.  I guess something to point out is that both of the valgind messages seem to happen from the test_record() function in perfthread_test.cpp.  I'm guessing the locking stuff is off?  I guess a simple way to test is commenting out:

    performanceThread1.Record("testrec.wav");

and

    performanceThread1.StopRecord();

(lines 70 and 76) and seeing if valgrind still complains. 


On Mon, May 25, 2015 at 3:48 PM, jpff <jpff@codemist.co.uk> wrote:
Running diret under valgrind I see something slightly different

==6631== Thread 2:
==6631== Invalid read of size 8
==6631==    at 0x4E9D154: spoutsf (libsnd.c:78)
==6631==    by 0x4F9776A: kperf_nodebug (csound.c:1588)
==6631==    by 0x4F98D9B: csoundPerformKsmps (csound.c:1927)
==6631==    by 0x5753D9D: CsoundPerformanceThread::Perform() (csPerfThread.cpp:431)
==6631==    by 0x57557D8: CsPerfThread_PerformScore::Perform() (csPerfThread.cpp:478)
==6631==    by 0x5753FF3: csoundPerformanceThread_ (csPerfThread.cpp:495)
==6631==    by 0x550C0A3: start_thread (in /lib64/libpthread-2.19.so)
==6631==    by 0x626F06C: clone (in /lib64/libc-2.19.so)
==6631==  Address 0x9b23e80 is 0 bytes after a block of size 528 alloc'd
==6631==    at 0x4C2B200: calloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==6631==    by 0x4E8B957: mcalloc (memalloc.c:113)
==6631==    by 0x4E8E43F: musmon (musmon.c:205)
==6631==    by 0x4F9B6F3: csoundStart (main.c:484)
==6631==    by 0x407CE1: Csound::Start() (csound.hpp:269)
==6631==    by 0x40743B: test_record() (perfthread_test.cpp:68)
==6631==    by 0x52F6260: ??? (in /usr/lib64/libcunit.so.1.0.1)
==6631==    by 0x52F656E: ??? (in /usr/lib64/libcunit.so.1.0.1)
==6631==    by 0x52F68A5: CU_run_all_tests (in /usr/lib64/libcunit.so.1.0.1)
==6631==    by 0x407653: main (perfthread_test.cpp:117)

==John ffitch

------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/csound-devel


Date2015-05-26 17:03
FromFelipe Sateler
SubjectRe: [Cs-dev] Broken: csound/csound#884 (develop - 5b4cae7)
I made a small test yesterday, and encased the performance thread
usages in {} blocks. This reduced the number of warnings by valgrind
(But not entirely).

When I get back I can upload the valgrind logs.

Saludos

On 26 May 2015 at 12:52, Steven Yi  wrote:
> I took a little bit of a look and don't have much to add.  I guess something
> to point out is that both of the valgind messages seem to happen from the
> test_record() function in perfthread_test.cpp.  I'm guessing the locking
> stuff is off?  I guess a simple way to test is commenting out:
>
>     performanceThread1.Record("testrec.wav");
>
> and
>
>     performanceThread1.StopRecord();
>
> (lines 70 and 76) and seeing if valgrind still complains.
>
>
> On Mon, May 25, 2015 at 3:48 PM, jpff  wrote:
>>
>> Running diret under valgrind I see something slightly different
>>
>> ==6631== Thread 2:
>> ==6631== Invalid read of size 8
>> ==6631==    at 0x4E9D154: spoutsf (libsnd.c:78)
>> ==6631==    by 0x4F9776A: kperf_nodebug (csound.c:1588)
>> ==6631==    by 0x4F98D9B: csoundPerformKsmps (csound.c:1927)
>> ==6631==    by 0x5753D9D: CsoundPerformanceThread::Perform()
>> (csPerfThread.cpp:431)
>> ==6631==    by 0x57557D8: CsPerfThread_PerformScore::Perform()
>> (csPerfThread.cpp:478)
>> ==6631==    by 0x5753FF3: csoundPerformanceThread_ (csPerfThread.cpp:495)
>> ==6631==    by 0x550C0A3: start_thread (in /lib64/libpthread-2.19.so)
>> ==6631==    by 0x626F06C: clone (in /lib64/libc-2.19.so)
>> ==6631==  Address 0x9b23e80 is 0 bytes after a block of size 528 alloc'd
>> ==6631==    at 0x4C2B200: calloc (in
>> /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
>> ==6631==    by 0x4E8B957: mcalloc (memalloc.c:113)
>> ==6631==    by 0x4E8E43F: musmon (musmon.c:205)
>> ==6631==    by 0x4F9B6F3: csoundStart (main.c:484)
>> ==6631==    by 0x407CE1: Csound::Start() (csound.hpp:269)
>> ==6631==    by 0x40743B: test_record() (perfthread_test.cpp:68)
>> ==6631==    by 0x52F6260: ??? (in /usr/lib64/libcunit.so.1.0.1)
>> ==6631==    by 0x52F656E: ??? (in /usr/lib64/libcunit.so.1.0.1)
>> ==6631==    by 0x52F68A5: CU_run_all_tests (in
>> /usr/lib64/libcunit.so.1.0.1)
>> ==6631==    by 0x407653: main (perfthread_test.cpp:117)
>>
>> ==John ffitch
>>
>>
>> ------------------------------------------------------------------------------
>> One dashboard for servers and applications across Physical-Virtual-Cloud
>> Widest out-of-the-box monitoring support with 50+ applications
>> Performance metrics, stats and reports that give you Actionable Insights
>> Deep dive visibility with transaction tracing using APM Insight.
>> http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
>> _______________________________________________
>> Csound-devel mailing list
>> Csound-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>
>
>
> ------------------------------------------------------------------------------
> One dashboard for servers and applications across Physical-Virtual-Cloud
> Widest out-of-the-box monitoring support with 50+ applications
> Performance metrics, stats and reports that give you Actionable Insights
> Deep dive visibility with transaction tracing using APM Insight.
> http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
> _______________________________________________
> Csound-devel mailing list
> Csound-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/csound-devel
>



-- 

Saludos,
Felipe Sateler

------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net

Date2015-05-26 22:40
FromAndres Cabrera
SubjectRe: [Cs-dev] Broken: csound/csound#884 (develop - 5b4cae7)
AttachmentsNone  None  
I think I've fixed this issue.

However there are still some leaks from creating threads. I think CsoundJoinThread should free the thread after joining (since there is no CsoundDestroyThread function), but this doesn't seem to be the case.

Cheers,
Andrés

On Tue, May 26, 2015 at 9:03 AM, Felipe Sateler <fsateler@gmail.com> wrote:
I made a small test yesterday, and encased the performance thread
usages in {} blocks. This reduced the number of warnings by valgrind
(But not entirely).

When I get back I can upload the valgrind logs.

Saludos

On 26 May 2015 at 12:52, Steven Yi <stevenyi@gmail.com> wrote:
> I took a little bit of a look and don't have much to add.  I guess something
> to point out is that both of the valgind messages seem to happen from the
> test_record() function in perfthread_test.cpp.  I'm guessing the locking
> stuff is off?  I guess a simple way to test is commenting out:
>
>     performanceThread1.Record("testrec.wav");
>
> and
>
>     performanceThread1.StopRecord();
>
> (lines 70 and 76) and seeing if valgrind still complains.
>
>
> On Mon, May 25, 2015 at 3:48 PM, jpff <jpff@codemist.co.uk> wrote:
>>
>> Running diret under valgrind I see something slightly different
>>
>> ==6631== Thread 2:
>> ==6631== Invalid read of size 8
>> ==6631==    at 0x4E9D154: spoutsf (libsnd.c:78)
>> ==6631==    by 0x4F9776A: kperf_nodebug (csound.c:1588)
>> ==6631==    by 0x4F98D9B: csoundPerformKsmps (csound.c:1927)
>> ==6631==    by 0x5753D9D: CsoundPerformanceThread::Perform()
>> (csPerfThread.cpp:431)
>> ==6631==    by 0x57557D8: CsPerfThread_PerformScore::Perform()
>> (csPerfThread.cpp:478)
>> ==6631==    by 0x5753FF3: csoundPerformanceThread_ (csPerfThread.cpp:495)
>> ==6631==    by 0x550C0A3: start_thread (in /lib64/libpthread-2.19.so)
>> ==6631==    by 0x626F06C: clone (in /lib64/libc-2.19.so)
>> ==6631==  Address 0x9b23e80 is 0 bytes after a block of size 528 alloc'd
>> ==6631==    at 0x4C2B200: calloc (in
>> /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
>> ==6631==    by 0x4E8B957: mcalloc (memalloc.c:113)
>> ==6631==    by 0x4E8E43F: musmon (musmon.c:205)
>> ==6631==    by 0x4F9B6F3: csoundStart (main.c:484)
>> ==6631==    by 0x407CE1: Csound::Start() (csound.hpp:269)
>> ==6631==    by 0x40743B: test_record() (perfthread_test.cpp:68)
>> ==6631==    by 0x52F6260: ??? (in /usr/lib64/libcunit.so.1.0.1)
>> ==6631==    by 0x52F656E: ??? (in /usr/lib64/libcunit.so.1.0.1)
>> ==6631==    by 0x52F68A5: CU_run_all_tests (in
>> /usr/lib64/libcunit.so.1.0.1)
>> ==6631==    by 0x407653: main (perfthread_test.cpp:117)
>>
>> ==John ffitch
>>
>>
>> ------------------------------------------------------------------------------
>> One dashboard for servers and applications across Physical-Virtual-Cloud
>> Widest out-of-the-box monitoring support with 50+ applications
>> Performance metrics, stats and reports that give you Actionable Insights
>> Deep dive visibility with transaction tracing using APM Insight.
>> http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
>> _______________________________________________
>> Csound-devel mailing list
>> Csound-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>
>
>
> ------------------------------------------------------------------------------
> One dashboard for servers and applications across Physical-Virtual-Cloud
> Widest out-of-the-box monitoring support with 50+ applications
> Performance metrics, stats and reports that give you Actionable Insights
> Deep dive visibility with transaction tracing using APM Insight.
> http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
> _______________________________________________
> Csound-devel mailing list
> Csound-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/csound-devel
>



--

Saludos,
Felipe Sateler

------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/csound-devel