Csound Csound-dev Csound-tekno Search About

Re: [Cs-dev] counterpoint target indentation

Date2008-03-18 11:38
From"Michael Gogins"
SubjectRe: [Cs-dev] counterpoint target indentation
Are you a Csound developer -- that is, do you have CVS commit permission? 
If so, please feel free to make these changes yourself in the future. I will 
take care of this one.

We've had discussions of development co-operation in Csound in the past. 
Most people seem to think it's OK to fix other people's bugs without 
permission or notification. It's not to OK to remove or drastically rewrite 
other people's work without talking it over first.

Regards,
Mike

----- Original Message ----- 
From: "DavidW" 
To: "Developer discussions" 
Sent: Monday, March 17, 2008 10:44 PM
Subject: Re: [Cs-dev] counterpoint target indentation


> Thanks Mike.
> given, line 2112 ++
>
>> csoundvst = vstEnvironment.SharedLibrary('CsoundVST',
>> csoundVstSources)
>> libs.append(csoundvst)
>> Depends(csoundvst, csoundInterfaces)
>> Depends(csoundvst, csoundLibrary)
>> guiProgramEnvironment.Append(LINKFLAGS = libCsoundLinkFlags)
>> if commonEnvironment['useDouble'] != '0':
>> csoundvstGui = guiProgramEnvironment.Program(
>>    'CsoundVSTShell', ['frontends/CsoundVST/csoundvst_main.cpp'],
>>    LIBS = Split('csound64 csnd CsoundVST'))
>> else:
>> csoundvstGui = guiProgramEnvironment.Program(
>>    'CsoundVSTShell', ['frontends/CsoundVST/csoundvst_main.cpp'],
>>    LIBS = Split('csound32 csnd CsoundVST'))
>> executables.append(csoundvstGui)
>> Depends(csoundvstGui, csoundvst)
>>
>
> given that csoundvst is defined in this block, shouldn't the last if-
> else block + 2 lines be indented also?
> I get a 'csoundvstGui not found' interpreter  error if it isn't.
> David
>
>
> On 18/03/2008, at 12:43 PM, Michael Gogins wrote:
>
>> The problem reported by Steven Yi with acEnvironment and the
>> counterpoint
>> target has been fixed in SConstruct in Csound CVS. The counterpoint
>> demo
>> program should not build without CsoundAC upon which it depends.
>>
>> Regards,
>> Mike
>>
>>
>> -------------------------------------------------------------------------
>> This SF.net email is sponsored by: Microsoft
>> Defy all challenges. Microsoft(R) Visual Studio 2008.
>> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
>> _______________________________________________
>> Csound-devel mailing list
>> Csound-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>>
>
> ___________
> David Worrall
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Csound-devel mailing list
> Csound-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/csound-devel 


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net

Date2008-03-18 12:21
FromDavidW
SubjectRe: [Cs-dev] counterpoint target indentation
No I don't have developer /CVS commit permission.
I'm not sure I'm a safe bet in this regard at the moment -
I don't really consider myself enough on top of all the implications.
I'm happy to begin slowly.  I'll leave it up to others (John?) to  
decide.
I'm working across about 10 development groups so I tend to come an go  
a bit.

Perhaps if the bugtracker mechanism was encouraged, it would make this
list look less like a the debris of a codewar!

cheers,

David

On 18/03/2008, at 10:38 PM, Michael Gogins wrote:

> Are you a Csound developer -- that is, do you have CVS commit  
> permission?
> If so, please feel free to make these changes yourself in the  
> future. I will
> take care of this one.
>
> We've had discussions of development co-operation in Csound in the  
> past.
> Most people seem to think it's OK to fix other people's bugs without
> permission or notification. It's not to OK to remove or drastically  
> rewrite
> other people's work without talking it over first.
>
> Regards,
> Mike
>
> ----- Original Message -----
> From: "DavidW" 
> To: "Developer discussions" 
> Sent: Monday, March 17, 2008 10:44 PM
> Subject: Re: [Cs-dev] counterpoint target indentation
>
>
>> Thanks Mike.
>> given, line 2112 ++
>>
>>> csoundvst = vstEnvironment.SharedLibrary('CsoundVST',
>>> csoundVstSources)
>>> libs.append(csoundvst)
>>> Depends(csoundvst, csoundInterfaces)
>>> Depends(csoundvst, csoundLibrary)
>>> guiProgramEnvironment.Append(LINKFLAGS = libCsoundLinkFlags)
>>> if commonEnvironment['useDouble'] != '0':
>>> csoundvstGui = guiProgramEnvironment.Program(
>>>   'CsoundVSTShell', ['frontends/CsoundVST/csoundvst_main.cpp'],
>>>   LIBS = Split('csound64 csnd CsoundVST'))
>>> else:
>>> csoundvstGui = guiProgramEnvironment.Program(
>>>   'CsoundVSTShell', ['frontends/CsoundVST/csoundvst_main.cpp'],
>>>   LIBS = Split('csound32 csnd CsoundVST'))
>>> executables.append(csoundvstGui)
>>> Depends(csoundvstGui, csoundvst)
>>>
>>
>> given that csoundvst is defined in this block, shouldn't the last if-
>> else block + 2 lines be indented also?
>> I get a 'csoundvstGui not found' interpreter  error if it isn't.
>> David
>>
>>
>> On 18/03/2008, at 12:43 PM, Michael Gogins wrote:
>>
>>> The problem reported by Steven Yi with acEnvironment and the
>>> counterpoint
>>> target has been fixed in SConstruct in Csound CVS. The counterpoint
>>> demo
>>> program should not build without CsoundAC upon which it depends.
>>>
>>> Regards,
>>> Mike
>>>
>>>




-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net