With all respect, and as Steve points out, I contributed the pull request 4 days ago. I did not assume that it would be merged, and I did not merge it. Indeed, I _cannot_ merge pull requests into https://github.com/csound/manual, and one cannot announce changes that one cannot make. I would add that after every commit to https://github.com/csound/manual/pull/108, both the PDF and HTML versions of the manually were successfully built o

Don't worry Nate, your contributions are very much appreciated. The
travis change alone is super valuable. You did the right things.
Thanks!

If anyone wants to blame someone here, you're welcome to blame me for
not announcing the merge or upcoming change.  My mistake.  It compiled
here on Windows and compiled on Travis (which I was aware of, and
thus, assumed meant it worked for those on Linux).  Everyone here was
also following the PR and the comments were overall positive with the
issues over coloring addressed, so it felt fine to merge.  I'm not
sure what more could be done besides testing on the primary OSs which
is what happened.  Anyways, let's figure out what's left to address as
apparently there's more system configurations (e.g., Victor's
situation with outdated pygments) that weren't covered.

On Thu, Jan 19, 2017 at 10:59 AM, Nate Whetsell
 wrote:
> With all respect, and as Steve points out, I contributed the pull request 4 days ago. I did not assume that it would be merged, and I did not merge it. Indeed, I _cannot_ merge pull requests into https://github.com/csound/manual, and one cannot announce changes that one cannot make. I would add that after every commit to https://github.com/csound/manual/pull/108, both the PDF and HTML versions of the manually were successfully built on Travis: 

I appreciate your contributions as well. Csound is now a moderately
complex software system with respect to lines of code and a rather
complex system with respect to languages, dependencies, tooling,
platforms, etc.

I think it gets easier to break Csound, and takes more care to keep
things straight. Care includes keeping everyone up to date with
potentially breaking changes.

Regards,
Mike

-----------------------------------------------------
Michael Gogins
Irreducible Productions
http://michaelgogins.tumblr.com
Michael dot Gogins at gmail dot com


On Thu, Jan 19, 2017 at 11:32 AM, Steven Yi  wrote:
> Don't worry Nate, your contributions are very much appreciated. The
> travis change alone is super valuable. You did the right things.
> Thanks!
>
> If anyone wants to blame someone here, you're welcome to blame me for
> not announcing the merge or upcoming change.  My mistake.  It compiled
> here on Windows and compiled on Travis (which I was aware of, and
> thus, assumed meant it worked for those on Linux).  Everyone here was
> also following the PR and the comments were overall positive with the
> issues over coloring addressed, so it felt fine to merge.  I'm not
> sure what more could be done besides testing on the primary OSs which
> is what happened.  Anyways, let's figure out what's left to address as
> apparently there's more system configurations (e.g., Victor's
> situation with outdated pygments) that weren't covered.
>
> On Thu, Jan 19, 2017 at 10:59 AM, Nate Whetsell
>  wrote:
>> With all respect, and as Steve points out, I contributed the pull request 4 days ago. I did not assume that it would be merged, and I did not merge it. Indeed, I _cannot_ merge pull requests into https://github.com/csound/manual, and one cannot announce changes that one cannot make. I would add that after every commit to https://github.com/csound/manual/pull/108, both the PDF and HTML versions of the manually were successfully built on Travis: