Csound Csound-dev Csound-tekno Search About

[Cs-dev] Code Cleanup Candidates

Date2013-04-24 20:42
FromSteven Yi
Subject[Cs-dev] Code Cleanup Candidates
Hi All,

I'm going through looking at dead code and want to verify it's alright
to delete:

-csmodule.c : OLD_MACH_CODE related code

I don't think we should keep support for OS9 any longer; if someone
*really* wants this, we can move this code into a csmoduleOS9.c file
and whomever is building can just use that in place of csmodule.c

-csound.c : code blocked by #ifdef never

lines 3829-3899 aren't used, and there is an empty ifdef block at 2484
that looks useless

-sread.c : #if never (lines 767-781), code surrounded by MACDEBUG, line 35-61

The first surrounds an sread_init function that looks no longer used,
and the MACDEBUG code looks like it was developer logging code.  Lines
35-61 are already commented out so look like they can go too.


There's a bunch of "#if 0" and a few "#if never" and "#ifdef never" in
the code base that looks like candidates to remove too.

Thanks!
steven

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net

Date2013-04-24 21:13
FromVictor Lazzarini
SubjectRe: [Cs-dev] Code Cleanup Candidates
OLD_MACH_CODE can certainly go now.
On 24 Apr 2013, at 20:42, Steven Yi wrote:

> Hi All,
> 
> I'm going through looking at dead code and want to verify it's alright
> to delete:
> 
> -csmodule.c : OLD_MACH_CODE related code
> 
> I don't think we should keep support for OS9 any longer; if someone
> *really* wants this, we can move this code into a csmoduleOS9.c file
> and whomever is building can just use that in place of csmodule.c
> 
> -csound.c : code blocked by #ifdef never
> 
> lines 3829-3899 aren't used, and there is an empty ifdef block at 2484
> that looks useless
> 
> -sread.c : #if never (lines 767-781), code surrounded by MACDEBUG, line 35-61
> 
> The first surrounds an sread_init function that looks no longer used,
> and the MACDEBUG code looks like it was developer logging code.  Lines
> 35-61 are already commented out so look like they can go too.
> 
> 
> There's a bunch of "#if 0" and a few "#if never" and "#ifdef never" in
> the code base that looks like candidates to remove too.
> 
> Thanks!
> steven
> 
> ------------------------------------------------------------------------------
> Try New Relic Now & We'll Send You this Cool Shirt
> New Relic is the only SaaS-based application performance monitoring service 
> that delivers powerful full stack analytics. Optimize and monitor your
> browser, app, & servers with just a few lines of code. Try New Relic
> and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
> _______________________________________________
> Csound-devel mailing list
> Csound-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/csound-devel

Dr Victor Lazzarini
Senior Lecturer
Dept. of Music
NUI Maynooth Ireland
tel.: +353 1 708 3545
Victor dot Lazzarini AT nuim dot ie




------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net

Date2013-04-24 22:08
FromSteven Yi
SubjectRe: [Cs-dev] Code Cleanup Candidates
Ah, my mistake, OLD_MACH_CODE is obviously not OS9 related.  I'm
working on removing it now though.

Thanks!
steven


On Wed, Apr 24, 2013 at 9:13 PM, Victor Lazzarini
 wrote:
> OLD_MACH_CODE can certainly go now.
> On 24 Apr 2013, at 20:42, Steven Yi wrote:
>
>> Hi All,
>>
>> I'm going through looking at dead code and want to verify it's alright
>> to delete:
>>
>> -csmodule.c : OLD_MACH_CODE related code
>>
>> I don't think we should keep support for OS9 any longer; if someone
>> *really* wants this, we can move this code into a csmoduleOS9.c file
>> and whomever is building can just use that in place of csmodule.c
>>
>> -csound.c : code blocked by #ifdef never
>>
>> lines 3829-3899 aren't used, and there is an empty ifdef block at 2484
>> that looks useless
>>
>> -sread.c : #if never (lines 767-781), code surrounded by MACDEBUG, line 35-61
>>
>> The first surrounds an sread_init function that looks no longer used,
>> and the MACDEBUG code looks like it was developer logging code.  Lines
>> 35-61 are already commented out so look like they can go too.
>>
>>
>> There's a bunch of "#if 0" and a few "#if never" and "#ifdef never" in
>> the code base that looks like candidates to remove too.
>>
>> Thanks!
>> steven
>>
>> ------------------------------------------------------------------------------
>> Try New Relic Now & We'll Send You this Cool Shirt
>> New Relic is the only SaaS-based application performance monitoring service
>> that delivers powerful full stack analytics. Optimize and monitor your
>> browser, app, & servers with just a few lines of code. Try New Relic
>> and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
>> _______________________________________________
>> Csound-devel mailing list
>> Csound-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>
> Dr Victor Lazzarini
> Senior Lecturer
> Dept. of Music
> NUI Maynooth Ireland
> tel.: +353 1 708 3545
> Victor dot Lazzarini AT nuim dot ie
>
>
>
>
> ------------------------------------------------------------------------------
> Try New Relic Now & We'll Send You this Cool Shirt
> New Relic is the only SaaS-based application performance monitoring service
> that delivers powerful full stack analytics. Optimize and monitor your
> browser, app, & servers with just a few lines of code. Try New Relic
> and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
> _______________________________________________
> Csound-devel mailing list
> Csound-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/csound-devel

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net

Date2013-04-24 22:18
FromSteven Yi
SubjectRe: [Cs-dev] Code Cleanup Candidates
I also went ahead and removed the dead code from csound.c  I'll leave
the MACDEBUG stuff alone and the rest of sread.c and move on to other
things.

Thanks!
steven

On Wed, Apr 24, 2013 at 10:08 PM, Steven Yi  wrote:
> Ah, my mistake, OLD_MACH_CODE is obviously not OS9 related.  I'm
> working on removing it now though.
>
> Thanks!
> steven
>
>
> On Wed, Apr 24, 2013 at 9:13 PM, Victor Lazzarini
>  wrote:
>> OLD_MACH_CODE can certainly go now.
>> On 24 Apr 2013, at 20:42, Steven Yi wrote:
>>
>>> Hi All,
>>>
>>> I'm going through looking at dead code and want to verify it's alright
>>> to delete:
>>>
>>> -csmodule.c : OLD_MACH_CODE related code
>>>
>>> I don't think we should keep support for OS9 any longer; if someone
>>> *really* wants this, we can move this code into a csmoduleOS9.c file
>>> and whomever is building can just use that in place of csmodule.c
>>>
>>> -csound.c : code blocked by #ifdef never
>>>
>>> lines 3829-3899 aren't used, and there is an empty ifdef block at 2484
>>> that looks useless
>>>
>>> -sread.c : #if never (lines 767-781), code surrounded by MACDEBUG, line 35-61
>>>
>>> The first surrounds an sread_init function that looks no longer used,
>>> and the MACDEBUG code looks like it was developer logging code.  Lines
>>> 35-61 are already commented out so look like they can go too.
>>>
>>>
>>> There's a bunch of "#if 0" and a few "#if never" and "#ifdef never" in
>>> the code base that looks like candidates to remove too.
>>>
>>> Thanks!
>>> steven
>>>
>>> ------------------------------------------------------------------------------
>>> Try New Relic Now & We'll Send You this Cool Shirt
>>> New Relic is the only SaaS-based application performance monitoring service
>>> that delivers powerful full stack analytics. Optimize and monitor your
>>> browser, app, & servers with just a few lines of code. Try New Relic
>>> and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
>>> _______________________________________________
>>> Csound-devel mailing list
>>> Csound-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>>
>> Dr Victor Lazzarini
>> Senior Lecturer
>> Dept. of Music
>> NUI Maynooth Ireland
>> tel.: +353 1 708 3545
>> Victor dot Lazzarini AT nuim dot ie
>>
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Try New Relic Now & We'll Send You this Cool Shirt
>> New Relic is the only SaaS-based application performance monitoring service
>> that delivers powerful full stack analytics. Optimize and monitor your
>> browser, app, & servers with just a few lines of code. Try New Relic
>> and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
>> _______________________________________________
>> Csound-devel mailing list
>> Csound-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/csound-devel

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net

Date2013-04-24 22:24
FromVictor Lazzarini
SubjectRe: [Cs-dev] Code Cleanup Candidates
Thanks.

Victor
On 24 Apr 2013, at 22:18, Steven Yi wrote:

> I also went ahead and removed the dead code from csound.c  I'll leave
> the MACDEBUG stuff alone and the rest of sread.c and move on to other
> things.
> 
> Thanks!
> steven
> 
> On Wed, Apr 24, 2013 at 10:08 PM, Steven Yi  wrote:
>> Ah, my mistake, OLD_MACH_CODE is obviously not OS9 related.  I'm
>> working on removing it now though.
>> 
>> Thanks!
>> steven
>> 
>> 
>> On Wed, Apr 24, 2013 at 9:13 PM, Victor Lazzarini
>>  wrote:
>>> OLD_MACH_CODE can certainly go now.
>>> On 24 Apr 2013, at 20:42, Steven Yi wrote:
>>> 
>>>> Hi All,
>>>> 
>>>> I'm going through looking at dead code and want to verify it's alright
>>>> to delete:
>>>> 
>>>> -csmodule.c : OLD_MACH_CODE related code
>>>> 
>>>> I don't think we should keep support for OS9 any longer; if someone
>>>> *really* wants this, we can move this code into a csmoduleOS9.c file
>>>> and whomever is building can just use that in place of csmodule.c
>>>> 
>>>> -csound.c : code blocked by #ifdef never
>>>> 
>>>> lines 3829-3899 aren't used, and there is an empty ifdef block at 2484
>>>> that looks useless
>>>> 
>>>> -sread.c : #if never (lines 767-781), code surrounded by MACDEBUG, line 35-61
>>>> 
>>>> The first surrounds an sread_init function that looks no longer used,
>>>> and the MACDEBUG code looks like it was developer logging code.  Lines
>>>> 35-61 are already commented out so look like they can go too.
>>>> 
>>>> 
>>>> There's a bunch of "#if 0" and a few "#if never" and "#ifdef never" in
>>>> the code base that looks like candidates to remove too.
>>>> 
>>>> Thanks!
>>>> steven
>>>> 
>>>> ------------------------------------------------------------------------------
>>>> Try New Relic Now & We'll Send You this Cool Shirt
>>>> New Relic is the only SaaS-based application performance monitoring service
>>>> that delivers powerful full stack analytics. Optimize and monitor your
>>>> browser, app, & servers with just a few lines of code. Try New Relic
>>>> and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
>>>> _______________________________________________
>>>> Csound-devel mailing list
>>>> Csound-devel@lists.sourceforge.net
>>>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>>> 
>>> Dr Victor Lazzarini
>>> Senior Lecturer
>>> Dept. of Music
>>> NUI Maynooth Ireland
>>> tel.: +353 1 708 3545
>>> Victor dot Lazzarini AT nuim dot ie
>>> 
>>> 
>>> 
>>> 
>>> ------------------------------------------------------------------------------
>>> Try New Relic Now & We'll Send You this Cool Shirt
>>> New Relic is the only SaaS-based application performance monitoring service
>>> that delivers powerful full stack analytics. Optimize and monitor your
>>> browser, app, & servers with just a few lines of code. Try New Relic
>>> and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
>>> _______________________________________________
>>> Csound-devel mailing list
>>> Csound-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/csound-devel
> 
> ------------------------------------------------------------------------------
> Try New Relic Now & We'll Send You this Cool Shirt
> New Relic is the only SaaS-based application performance monitoring service 
> that delivers powerful full stack analytics. Optimize and monitor your
> browser, app, & servers with just a few lines of code. Try New Relic
> and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
> _______________________________________________
> Csound-devel mailing list
> Csound-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/csound-devel

Dr Victor Lazzarini
Senior Lecturer
Dept. of Music
NUI Maynooth Ireland
tel.: +353 1 708 3545
Victor dot Lazzarini AT nuim dot ie




------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net