Coverity has uncovered a number of problems with the code, some of
which I have fixed.  But this one worries me.

In dssilist (line ~1035) we see
    pcLADSPAPath = getenv("LADSPA_PATH");
    pcDSSIPath = getenv("DSSI_PATH");
so the strings associated with these variables is allocated somewhere
not here and I assume of minimal length.  On lin ~1048 we read
      pcLADSPAPath = strcat((char *) pcLADSPAPath, ":");
      pcLADSPAPath = strcat((char *) pcLADSPAPath, pcDSSIPath);
How can one be sure there is enough space?  Surely one needs something
like malloc(strlen(pcLADSPAPath)+strlen(pcDSSIPath)+2) to be allocated
and then strcpy/strcat/strcat ?  Or am I totally misunderstanding the
code?

Slight;y different, Coverity says thattdssiinit can leak memory from
variable PluginLibrary.  This needs a review by someone who
understands the code
   
==John ffitch

------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net