| OK, changes are committed to CVS now.
Victor
On 28 Jul 2010, at 12:05, Andres Cabrera wrote:
> Great! Thanks for the info.
>
> Cheers,
> Andrés
>
> On Wed, Jul 28, 2010 at 11:57 AM, Victor Lazzarini
> wrote:
>> I don't think so, because the sndfile header in csoundCore.h was only
>> there to provide the definitions for these two structure pointers.
>> The
>> replacement now with Erik's suggestion should be seamless and no API
>> bump of any form is needed.
>>
>> Victor
>>
>> On 28 Jul 2010, at 11:28, Andres Cabrera wrote:
>>
>>> I don't know about this, so this may be a silly question, but would
>>> this have any effect on binary compatibility of plugins or front-
>>> ends?
>>>
>>> Cheers,
>>> Andrés
>>>
>>> On Wed, Jul 28, 2010 at 12:09 AM, Victor Lazzarini
>>> wrote:
>>>> Ok, thanks.
>>>>
>>>> Victor
>>>> On 27 Jul 2010, at 23:58, Erik de Castro Lopo wrote:
>>>>
>>>>> Victor Lazzarini wrote:
>>>>>
>>>>>> I have removed the sndifle.h header include line from
>>>>>> csoundCore.h to
>>>>>> allow opcodes to be built without libsndfile headers
>>>>>>
>>>>>> Some changes were needed. As it turned out only two CSOUND
>>>>>> functions
>>>>>> used sndfile.h data structures, so I think it was worth a go.
>>>>>> This
>>>>>> was
>>>>>> what I changed,
>>>>>> I believe there is no need for but a minor API bump:
>>>>>>
>>>>>> SNDMEMFILE *csoundLoadSoundFile(CSOUND *csound, const char
>>>>>> *fileName,
>>>>>> void *sfinfo_)
>>>>>> last argument changed from SF_INFO * to void *
>>>>>>
>>>>>> void rewriteheader(void *ofd);
>>>>>> argument changed from SNDFILE * to void *
>>>>>
>>>>> There is a better way to do this. You can forward declare the
>>>>> struct using:
>>>>>
>>>>> struct SF_INFO ;
>>>>>
>>>>> and the change the
>>>>>
>>>>> void *sfinfo_
>>>>>
>>>>> to
>>>>>
>>>>> struct SFINFO * sfinfo_
>>>>>
>>>>> Similar for the SNDFILE pointer.
>>>>>
>>>>> Casting from void pointer to structs makes my skin crawl.
>>>>>
>>>>> Erik
>>>>> --
>>>>> ----------------------------------------------------------------------
>>>>> Erik de Castro Lopo
>>>>> http://www.mega-nerd.com/
>>>>>
>>>>> ------------------------------------------------------------------------------
>>>>> The Palm PDK Hot Apps Program offers developers who use the
>>>>> Plug-In Development Kit to bring their C/C++ apps to Palm for a
>>>>> share
>>>>> of $1 Million in cash or HP Products. Visit us here for more
>>>>> details:
>>>>> http://ad.doubleclick.net/clk;226879339;13503038;l?
>>>>> http://clk.atdmt.com/CRS/go/247765532/direct/01/
>>>>> _______________________________________________
>>>>> Csound-devel mailing list
>>>>> Csound-devel@lists.sourceforge.net
>>>>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> The Palm PDK Hot Apps Program offers developers who use the
>>>> Plug-In Development Kit to bring their C/C++ apps to Palm for a
>>>> share
>>>> of $1 Million in cash or HP Products. Visit us here for more
>>>> details:
>>>> http://ad.doubleclick.net/clk;226879339;13503038;l?
>>>> http://clk.atdmt.com/CRS/go/247765532/direct/01/
>>>> _______________________________________________
>>>> Csound-devel mailing list
>>>> Csound-devel@lists.sourceforge.net
>>>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>>>>
>>>
>>>
>>>
>>> --
>>>
>>>
>>> Andrés
>>>
>>> ------------------------------------------------------------------------------
>>> The Palm PDK Hot Apps Program offers developers who use the
>>> Plug-In Development Kit to bring their C/C++ apps to Palm for a
>>> share
>>> of $1 Million in cash or HP Products. Visit us here for more
>>> details:
>>> http://ad.doubleclick.net/clk;226879339;13503038;l?
>>> http://clk.atdmt.com/CRS/go/247765532/direct/01/
>>> _______________________________________________
>>> Csound-devel mailing list
>>> Csound-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>>
>>
>> ------------------------------------------------------------------------------
>> The Palm PDK Hot Apps Program offers developers who use the
>> Plug-In Development Kit to bring their C/C++ apps to Palm for a share
>> of $1 Million in cash or HP Products. Visit us here for more details:
>> http://ad.doubleclick.net/clk;226879339;13503038;l?
>> http://clk.atdmt.com/CRS/go/247765532/direct/01/
>> _______________________________________________
>> Csound-devel mailing list
>> Csound-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>>
>
>
>
> --
>
>
> Andrés
>
> ------------------------------------------------------------------------------
> The Palm PDK Hot Apps Program offers developers who use the
> Plug-In Development Kit to bring their C/C++ apps to Palm for a share
> of $1 Million in cash or HP Products. Visit us here for more details:
> http://ad.doubleclick.net/clk;226879339;13503038;l?
> http://clk.atdmt.com/CRS/go/247765532/direct/01/
> _______________________________________________
> Csound-devel mailing list
> Csound-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/csound-devel
------------------------------------------------------------------------------
The Palm PDK Hot Apps Program offers developers who use the
Plug-In Development Kit to bring their C/C++ apps to Palm for a share
of $1 Million in cash or HP Products. Visit us here for more details:
http://ad.doubleclick.net/clk;226879339;13503038;l?
http://clk.atdmt.com/CRS/go/247765532/direct/01/
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net |