Hi All,

I've modified how float-version.h is done by removing the pre-built
headers from the include folder and adding a float-version.h.in that
will be generated to the build directory/include folder.
Modifications are in:

https://github.com/csound/csound/commit/35a879e51a217be852e293499573c6951e6bf924

I had to modify things for Android, iOS, and PNaCl builds to use a
pre-generated float-version.h.

One thing to note: I updated build scripts that I could test. I am not
sure what is necessary for the Windows installer.  Michael: Could you
update your installer script to include the generated float-version.h
that will be in the build dir/include folder?

Tested for OSX, Android, iOS. Also the commit succeeded in building on
Linux 64-bit Travi-CI server.

One thing I did not test is that "make install" puts the generated
header on Linux.  If someone on Linux could test that, that'd be
great.  You'll find in the float-version.h an #ifdef for
FLOAT_VERSION_H_DOUBLE.

Let me know if there are any issues. Thanks!
steven

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.  Get 
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net

Hi Steven,

It builds and installs OK on debian. I've got 2 questions, though:

1. Why didn't you add float-version.h to csheaders aand instead
manually added the file to other places?
2. I'm not quite sure what the purpose of FLOAT_VERSION_H_DOUBLE is.
What was insufficient about just #cmakedefine USE_DOUBLE?



On Tue, Apr 29, 2014 at 9:54 AM, Steven Yi  wrote:
> Hi All,
>
> I've modified how float-version.h is done by removing the pre-built
> headers from the include folder and adding a float-version.h.in that
> will be generated to the build directory/include folder.
> Modifications are in:
>
> https://github.com/csound/csound/commit/35a879e51a217be852e293499573c6951e6bf924
>
> I had to modify things for Android, iOS, and PNaCl builds to use a
> pre-generated float-version.h.
>
> One thing to note: I updated build scripts that I could test. I am not
> sure what is necessary for the Windows installer.  Michael: Could you
> update your installer script to include the generated float-version.h
> that will be in the build dir/include folder?
>
> Tested for OSX, Android, iOS. Also the commit succeeded in building on
> Linux 64-bit Travi-CI server.
>
> One thing I did not test is that "make install" puts the generated
> header on Linux.  If someone on Linux could test that, that'd be
> great.  You'll find in the float-version.h an #ifdef for
> FLOAT_VERSION_H_DOUBLE.
>
> Let me know if there are any issues. Thanks!
> steven
>
> ------------------------------------------------------------------------------
> "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
> Instantly run your Selenium tests across 300+ browser/OS combos.  Get
> unparalleled scalability from the best Selenium testing platform available.
> Simple to use. Nothing to install. Get started now for free."
> http://p.sf.net/sfu/SauceLabs
> _______________________________________________
> Csound-devel mailing list
> Csound-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/csound-devel



-- 

Saludos,
Felipe Sateler

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.  Get 
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net

Hi Felipe,

Answers inline below, thanks!

steven

On Tue, Apr 29, 2014 at 10:38 AM, Felipe Sateler  wrote:
> Hi Steven,
>
> It builds and installs OK on debian. I've got 2 questions, though:
>
> 1. Why didn't you add float-version.h to csheaders aand instead
> manually added the file to other places?

I tried adding to csheaders first, but it interfered with the Apple
Framework stuff we do in the main CMakeLists.txt.  So I added the
addition of the headers to the other locations.  Maybe it's not the
cleanest, but what I could come up on the sleep I've had. :P  If you
have a better solution, I have no problems with a rewrite.

> 2. I'm not quite sure what the purpose of FLOAT_VERSION_H_DOUBLE is.
> What was insufficient about just #cmakedefine USE_DOUBLE?

Ahhhhhhh... I think you're right. :) I had gotten too into the
undef/define code to just see that it's a much simpler thing.  I'll
change that and do a quick test now, then will commit.

>
>
> On Tue, Apr 29, 2014 at 9:54 AM, Steven Yi  wrote:
>> Hi All,
>>
>> I've modified how float-version.h is done by removing the pre-built
>> headers from the include folder and adding a float-version.h.in that
>> will be generated to the build directory/include folder.
>> Modifications are in:
>>
>> https://github.com/csound/csound/commit/35a879e51a217be852e293499573c6951e6bf924
>>
>> I had to modify things for Android, iOS, and PNaCl builds to use a
>> pre-generated float-version.h.
>>
>> One thing to note: I updated build scripts that I could test. I am not
>> sure what is necessary for the Windows installer.  Michael: Could you
>> update your installer script to include the generated float-version.h
>> that will be in the build dir/include folder?
>>
>> Tested for OSX, Android, iOS. Also the commit succeeded in building on
>> Linux 64-bit Travi-CI server.
>>
>> One thing I did not test is that "make install" puts the generated
>> header on Linux.  If someone on Linux could test that, that'd be
>> great.  You'll find in the float-version.h an #ifdef for
>> FLOAT_VERSION_H_DOUBLE.
>>
>> Let me know if there are any issues. Thanks!
>> steven
>>
>> ------------------------------------------------------------------------------
>> "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
>> Instantly run your Selenium tests across 300+ browser/OS combos.  Get
>> unparalleled scalability from the best Selenium testing platform available.
>> Simple to use. Nothing to install. Get started now for free."
>> http://p.sf.net/sfu/SauceLabs
>> _______________________________________________
>> Csound-devel mailing list
>> Csound-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>
>
>
> --
>
> Saludos,
> Felipe Sateler
>
> ------------------------------------------------------------------------------
> "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
> Instantly run your Selenium tests across 300+ browser/OS combos.  Get
> unparalleled scalability from the best Selenium testing platform available.
> Simple to use. Nothing to install. Get started now for free."
> http://p.sf.net/sfu/SauceLabs
> _______________________________________________
> Csound-devel mailing list
> Csound-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/csound-devel

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.  Get 
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net

I've updated the header to be as Felipe suggested (much nicer!).  I've
also removed -DUSE_DOUBLE as it becomes redundant to the value in
float-version.h (and compiler complained a lot about it :P).

Thanks Felipe for the review!
steven

On Tue, Apr 29, 2014 at 10:49 AM, Steven Yi  wrote:
> Hi Felipe,
>
> Answers inline below, thanks!
>
> steven
>
> On Tue, Apr 29, 2014 at 10:38 AM, Felipe Sateler  wrote:
>> Hi Steven,
>>
>> It builds and installs OK on debian. I've got 2 questions, though:
>>
>> 1. Why didn't you add float-version.h to csheaders aand instead
>> manually added the file to other places?
>
> I tried adding to csheaders first, but it interfered with the Apple
> Framework stuff we do in the main CMakeLists.txt.  So I added the
> addition of the headers to the other locations.  Maybe it's not the
> cleanest, but what I could come up on the sleep I've had. :P  If you
> have a better solution, I have no problems with a rewrite.
>
>> 2. I'm not quite sure what the purpose of FLOAT_VERSION_H_DOUBLE is.
>> What was insufficient about just #cmakedefine USE_DOUBLE?
>
> Ahhhhhhh... I think you're right. :) I had gotten too into the
> undef/define code to just see that it's a much simpler thing.  I'll
> change that and do a quick test now, then will commit.
>
>>
>>
>> On Tue, Apr 29, 2014 at 9:54 AM, Steven Yi  wrote:
>>> Hi All,
>>>
>>> I've modified how float-version.h is done by removing the pre-built
>>> headers from the include folder and adding a float-version.h.in that
>>> will be generated to the build directory/include folder.
>>> Modifications are in:
>>>
>>> https://github.com/csound/csound/commit/35a879e51a217be852e293499573c6951e6bf924
>>>
>>> I had to modify things for Android, iOS, and PNaCl builds to use a
>>> pre-generated float-version.h.
>>>
>>> One thing to note: I updated build scripts that I could test. I am not
>>> sure what is necessary for the Windows installer.  Michael: Could you
>>> update your installer script to include the generated float-version.h
>>> that will be in the build dir/include folder?
>>>
>>> Tested for OSX, Android, iOS. Also the commit succeeded in building on
>>> Linux 64-bit Travi-CI server.
>>>
>>> One thing I did not test is that "make install" puts the generated
>>> header on Linux.  If someone on Linux could test that, that'd be
>>> great.  You'll find in the float-version.h an #ifdef for
>>> FLOAT_VERSION_H_DOUBLE.
>>>
>>> Let me know if there are any issues. Thanks!
>>> steven
>>>
>>> ------------------------------------------------------------------------------
>>> "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
>>> Instantly run your Selenium tests across 300+ browser/OS combos.  Get
>>> unparalleled scalability from the best Selenium testing platform available.
>>> Simple to use. Nothing to install. Get started now for free."
>>> http://p.sf.net/sfu/SauceLabs
>>> _______________________________________________
>>> Csound-devel mailing list
>>> Csound-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/csound-devel
>>
>>
>>
>> --
>>
>> Saludos,
>> Felipe Sateler
>>
>> ------------------------------------------------------------------------------
>> "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
>> Instantly run your Selenium tests across 300+ browser/OS combos.  Get
>> unparalleled scalability from the best Selenium testing platform available.
>> Simple to use. Nothing to install. Get started now for free."
>> http://p.sf.net/sfu/SauceLabs
>> _______________________________________________
>> Csound-devel mailing list
>> Csound-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/csound-devel

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.  Get 
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Csound-devel mailing list
Csound-devel@lists.sourceforge.net