On Friday 28 March 2008 20:58:12 victor wrote:
> I noticed a problem with SConstruct on Windows, the line
>
> libCsoundLibs.append(csoundLibrary)
>
> will not work on gcc, as it ass Csound32.dll.5.1 which does not
> link (at least here with my current loader). So I added the fix.
>
> if getPlatform() != 'win32':
>  libCsoundLibs.append(csoundLibrary)
> else:
>  libCsoundLibs.append('csound32')

This is strange. I thought scons was supposed to handle these things (after 
all, this is one of the reasons why a simple Makefile is not enough!). 
Perhaps this is a bug in scons?
Your fix would break when building the double version of the library (it would 
need 'csound64'). Maybe it would be better to do:

if getPlatform() == 'win32':
    libCsoundLibs.append(csoundLibraryName)   # This is how it was done before
else:
    libCsoundLibs.append(csoundLibrary)


Note that all changes I'm making now will be done in the SConstruct2 and 
SConscript files, to avoid this kind of breakage.

>
> Another thing to bear in mind (Please!) is that the OLPC
> build John added last week, does not get broken, as we
> depend on that for the RPM release.

I haven't had any troubles with it yet.

-- 
Felipe Sateler