Thanks for your work. However, there are a couple of issues. I don't know 
about the rest here, but I normally try to not exceed 80 columns in a text 
file, because it makes editing on a terminal easier (I tend to use vim, so 
this is important for me). For example, some of your changes change lines of 
the form

if someReallyLongTest:
    doSomething()

into

if someReallyLongTest:       doSomething()

Which runs far over the 80-column limit several times.
Also I'm not really sure your formatting adds to readability (I think it 
actually makes it more difficult: it mixes the casing and the actual code).

I like the platform thing, though. I'll implement this for now, and fix the 
error you found in the static library part, but I'm afraid I can't just 
include your changes, because of the formatting problem.

On Sunday 06 April 2008 08:48:30 DavidW wrote:
> Hi Felipe,
>
> Attached is some work on SConstruct2
> The file is named Construct2.py  because I've been working on it in a
> keyword-aware editor.
> I've gone for making the logical flow clearer by getting as much on a
> screen as possible.
> This means making the lines longer - actually there were all sorts of
> length 'standards' so
> All I've done is adopt the longest one. I hope you agree it's more
> readable.
> We can always shorten them later if anyone objects.
>
> There is an error around line 966 ++ which I've clearly marked. It
> looks like you hadn't finished implementing an idea,
> so I've left the logic as you had. And noted where I think the problem
> is.
>
> We can do some more factoring later. For eg I was wondering about a
> set of classes, one for each platform, which inherit from a generic one.
>
> If you're happy with this, you could take out the lines with  #drw' on
> them, drop the .py off the end and submit is to the repository.
> (I don't have write access.)
>
> regards,
>
> David



-- 
Felipe Sateler