Csound Csound-dev Csound-tekno Search About

[Csnd-dev] failure in building on i386/Debian

Date2022-11-02 20:05
FromJohn
Subject[Csnd-dev] failure in building on i386/Debian
When  try i get

CMake Error at
/usr/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:165
(message):
  Could NOT find GTest (missing: GTEST_LIBRARY GTEST_INCLUDE_DIR
  GTEST_MAIN_LIBRARY)
Call Stack (most recent call first):
  /usr/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:458
(_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake-3.18/Modules/FindGTest.cmake:205
(FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  tests/c/CMakeLists.txt:30 (find_package)


-- Configuring incomplete, errors occurred!
See also "/home/jpff/csound6/CMakeFiles/CMakeOutput.log".
See also "/home/jpff/csound6/CMakeFiles/CMakeError.log".
make: *** [Makefile:9624: cmake_check_build_system] Error 1


Is this a new dependency and if so of what?

==John ffitch

Date2022-11-03 00:13
FromVictor Lazzarini
SubjectRe: [Csnd-dev] [EXTERNAL] [Csnd-dev] failure in building on i386/Debian
Looks like. I think it came with this commit

https://github.com/csound/csound/commit/1e0124c3762dacc053cd66a41fc8ba5c18ac2aa7

Prof. Victor Lazzarini
Maynooth University
Ireland

On 2 Nov 2022, at 20:05, John <jpff@codemist.co.uk> wrote:

*Warning*

This email originated from outside of Maynooth University's Mail System. Do not reply, click links or open attachments unless you recognise the sender and know the content is safe.

When  try i get

CMake Error at
/usr/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:165
(message):
 Could NOT find GTest (missing: GTEST_LIBRARY GTEST_INCLUDE_DIR
 GTEST_MAIN_LIBRARY)
Call Stack (most recent call first):
 /usr/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:458
(_FPHSA_FAILURE_MESSAGE)
 /usr/share/cmake-3.18/Modules/FindGTest.cmake:205
(FIND_PACKAGE_HANDLE_STANDARD_ARGS)
 tests/c/CMakeLists.txt:30 (find_package)


-- Configuring incomplete, errors occurred!
See also "/home/jpff/csound6/CMakeFiles/CMakeOutput.log".
See also "/home/jpff/csound6/CMakeFiles/CMakeError.log".
make: *** [Makefile:9624: cmake_check_build_system] Error 1


Is this a new dependency and if so of what?

==John ffitch

Date2022-11-03 00:28
FromSteven Yi
SubjectRe: [Csnd-dev] [EXTERNAL] [Csnd-dev] failure in building on i386/Debian
It's the Google Test library. Stephen Kyne discussed this change back in August:

https://listserv.heanet.ie/cgi-bin/wa?A2=ind2208&L=CSOUND-DEV&P=39404

The build shouldn't fail if it's not found (that's a bug). Indeed, the
coding of tests/c/CMakeLists.txt should be updated to check for GTest
and disable tests if not found.

For now you should be able to get around it by setting -DBUILD_TESTS=0
when running cmake to disable the tests.

On Wed, Nov 2, 2022 at 8:14 PM Victor Lazzarini  wrote:
>
> Looks like. I think it came with this commit
>
> https://github.com/csound/csound/commit/1e0124c3762dacc053cd66a41fc8ba5c18ac2aa7
>
> Prof. Victor Lazzarini
> Maynooth University
> Ireland
>
> On 2 Nov 2022, at 20:05, John  wrote:
>
> *Warning*
>
> This email originated from outside of Maynooth University's Mail System. Do not reply, click links or open attachments unless you recognise the sender and know the content is safe.
>
> When  try i get
>
> CMake Error at
> /usr/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:165
> (message):
>  Could NOT find GTest (missing: GTEST_LIBRARY GTEST_INCLUDE_DIR
>  GTEST_MAIN_LIBRARY)
> Call Stack (most recent call first):
>  /usr/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:458
> (_FPHSA_FAILURE_MESSAGE)
>  /usr/share/cmake-3.18/Modules/FindGTest.cmake:205
> (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
>  tests/c/CMakeLists.txt:30 (find_package)
>
>
> -- Configuring incomplete, errors occurred!
> See also "/home/jpff/csound6/CMakeFiles/CMakeOutput.log".
> See also "/home/jpff/csound6/CMakeFiles/CMakeError.log".
> make: *** [Makefile:9624: cmake_check_build_system] Error 1
>
>
> Is this a new dependency and if so of what?
>
> ==John ffitch

Date2022-11-04 00:00
FromStephen Kyne
SubjectRe: [Csnd-dev] [EXTERNAL] [Csnd-dev] failure in building on i386/Debian
This was kind of intentional but it's maybe not that DX friendly. What is happening is that the find_package(GTest) calls include the REQUIRED flag so it fails if it doesn't manage to locate it.

I've relaxed this now and it will simply not build the unit tests if a requirement isn't found.

Thanks,
Stephen

From: Csound-developers <CSOUND-DEV@LISTSERV.HEANET.IE> on behalf of Steven Yi <stevenyi@GMAIL.COM>
Sent: Thursday 3 November 2022 00:28
To: CSOUND-DEV@LISTSERV.HEANET.IE <CSOUND-DEV@LISTSERV.HEANET.IE>
Subject: Re: [Csnd-dev] [EXTERNAL] [Csnd-dev] failure in building on i386/Debian
 
It's the Google Test library. Stephen Kyne discussed this change back in August:

https://listserv.heanet.ie/cgi-bin/wa?A2=ind2208&L=CSOUND-DEV&P=39404

The build shouldn't fail if it's not found (that's a bug). Indeed, the
coding of tests/c/CMakeLists.txt should be updated to check for GTest
and disable tests if not found.

For now you should be able to get around it by setting -DBUILD_TESTS=0
when running cmake to disable the tests.

On Wed, Nov 2, 2022 at 8:14 PM Victor Lazzarini <Victor.Lazzarini@mu.ie> wrote:
>
> Looks like. I think it came with this commit
>
> https://github.com/csound/csound/commit/1e0124c3762dacc053cd66a41fc8ba5c18ac2aa7
>
> Prof. Victor Lazzarini
> Maynooth University
> Ireland
>
> On 2 Nov 2022, at 20:05, John <jpff@codemist.co.uk> wrote:
>
> *Warning*
>
> This email originated from outside of Maynooth University's Mail System. Do not reply, click links or open attachments unless you recognise the sender and know the content is safe.
>
> When  try i get
>
> CMake Error at
> /usr/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:165
> (message):
>  Could NOT find GTest (missing: GTEST_LIBRARY GTEST_INCLUDE_DIR
>  GTEST_MAIN_LIBRARY)
> Call Stack (most recent call first):
>  /usr/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:458
> (_FPHSA_FAILURE_MESSAGE)
>  /usr/share/cmake-3.18/Modules/FindGTest.cmake:205
> (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
>  tests/c/CMakeLists.txt:30 (find_package)
>
>
> -- Configuring incomplete, errors occurred!
> See also "/home/jpff/csound6/CMakeFiles/CMakeOutput.log".
> See also "/home/jpff/csound6/CMakeFiles/CMakeError.log".
> make: *** [Makefile:9624: cmake_check_build_system] Error 1
>
>
> Is this a new dependency and if so of what?
>
> ==John ffitch